Browse Source

Fix bug with accessing vchData[0] when vchData is empty.

Fix typo in CBase58Data::CompareTo
miguelfreitas
Abraham Jewowich 14 years ago
parent
commit
03f8b54565
  1. 5
      src/base58.h

5
src/base58.h

@ -173,6 +173,7 @@ protected: @@ -173,6 +173,7 @@ protected:
~CBase58Data()
{
if (!vchData.empty())
memset(&vchData[0], 0, vchData.size());
}
@ -180,6 +181,7 @@ protected: @@ -180,6 +181,7 @@ protected:
{
nVersion = nVersionIn;
vchData.resize(nSize);
if (!vchData.empty())
memcpy(&vchData[0], pdata, nSize);
}
@ -201,6 +203,7 @@ public: @@ -201,6 +203,7 @@ public:
}
nVersion = vchTemp[0];
vchData.resize(vchTemp.size() - 1);
if (!vchData.empty())
memcpy(&vchData[0], &vchTemp[1], vchData.size());
memset(&vchTemp[0], 0, vchTemp.size());
return true;
@ -221,7 +224,7 @@ public: @@ -221,7 +224,7 @@ public:
int CompareTo(const CBase58Data& b58) const
{
if (nVersion < b58.nVersion) return -1;
if (nVersion < b58.nVersion) return 1;
if (nVersion > b58.nVersion) return 1;
if (vchData < b58.vchData) return -1;
if (vchData > b58.vchData) return 1;
return 0;

Loading…
Cancel
Save