Browse Source

Performance improved for conversations switching

Now storing last N (N = 10 at the moment) conversations in DOM to be
able to show them really fast.
master
Igor Zhukov 10 years ago
parent
commit
91f32b4fe5
  1. 152
      app/js/controllers.js
  2. 4
      app/js/directives.js
  3. 7
      app/partials/im.html

152
app/js/controllers.js

@ -722,7 +722,7 @@ angular.module('myApp.controllers', [])
IdleManager.start(); IdleManager.start();
StatusManager.start(); StatusManager.start();
$scope.history = []; $scope.peerHistories = [];
$scope.skippedHistory = false; $scope.skippedHistory = false;
$scope.selectedMsgs = {}; $scope.selectedMsgs = {};
$scope.selectedCount = 0; $scope.selectedCount = 0;
@ -750,6 +750,7 @@ angular.module('myApp.controllers', [])
$scope.$on('history_return_recent', returnToRecent); $scope.$on('history_return_recent', returnToRecent);
var peerID, var peerID,
peerHistory = false,
hasMore = false, hasMore = false,
hasLess = false, hasLess = false,
maxID = 0, maxID = 0,
@ -792,6 +793,47 @@ angular.module('myApp.controllers', [])
} }
} }
function historiesQueuePush (peerID) {
var pos = -1,
maxLen = 10,
i,
history,
diff;
for (i = 0; i < $scope.peerHistories.length; i++) {
if ($scope.peerHistories[i].peerID == peerID) {
pos = i;
break;
}
}
if (pos > -1) {
history = $scope.peerHistories[pos];
if (pos) {
$scope.peerHistories.splice(pos, 1);
$scope.peerHistories.unshift(history);
}
return history;
}
history = {peerID: peerID, messages: []};
$scope.peerHistories.unshift(history);
diff = $scope.peerHistories.length - maxLen;
if (diff > 0) {
$scope.peerHistories.splice(maxLen - 1, diff);
}
return history;
}
function historiesQueueFind (peerID) {
var i;
for (i = 0; i < $scope.peerHistories.length; i++) {
if ($scope.peerHistories[i].peerID == peerID) {
return $scope.peerHistories[i];
}
}
return false;
}
function updateHistoryPeer(preload) { function updateHistoryPeer(preload) {
var peerData = AppPeersManager.getPeer(peerID); var peerData = AppPeersManager.getPeer(peerID);
// console.log('update', preload, peerData); // console.log('update', preload, peerData);
@ -800,7 +842,7 @@ angular.module('myApp.controllers', [])
return false; return false;
} }
$scope.history = []; peerHistory = historiesQueuePush(peerID);
safeReplaceObject($scope.historyPeer, { safeReplaceObject($scope.historyPeer, {
id: peerID, id: peerID,
@ -816,14 +858,17 @@ angular.module('myApp.controllers', [])
$scope.historyState.typing.splice(0, $scope.historyState.typing.length); $scope.historyState.typing.splice(0, $scope.historyState.typing.length);
$scope.$broadcast('ui_peer_change'); $scope.$broadcast('ui_peer_change');
$scope.$broadcast('ui_history_change'); $scope.$broadcast('ui_history_change');
safeReplaceObject($scope.state, {loaded: true}); safeReplaceObject($scope.state, {loaded: true, empty: !peerHistory.messages.length});
} }
} }
function messageFocusHistory () { function messageFocusHistory () {
var i, found = false; var i,
for (i = 0; i < $scope.history.length; i++) { found = false,
if ($scope.curDialog.messageID == $scope.history[i].id) { history = historiesQueueFind();
for (i = 0; i < history.messages.length; i++) {
if ($scope.curDialog.messageID == history.messages[i].id) {
found = true; found = true;
break; break;
} }
@ -854,7 +899,7 @@ angular.module('myApp.controllers', [])
for (i = historyResult.history.length - 1; i >= 0; i--) { for (i = historyResult.history.length - 1; i >= 0; i--) {
id = historyResult.history[i]; id = historyResult.history[i];
if (id > minID) { if (id > minID) {
$scope.history.push(AppMessagesManager.wrapForHistory(id)); peerHistory.messages.push(AppMessagesManager.wrapForHistory(id));
} }
} }
@ -862,7 +907,8 @@ angular.module('myApp.controllers', [])
minID = historyResult.history.length >= backLimit minID = historyResult.history.length >= backLimit
? historyResult.history[0] ? historyResult.history[0]
: 0; : 0;
AppMessagesManager.regroupWrappedHistory($scope.history, -backLimit); AppMessagesManager.regroupWrappedHistory(peerHistory.messages, -backLimit);
delete $scope.state.empty;
$scope.$broadcast('ui_history_append'); $scope.$broadcast('ui_history_append');
} else { } else {
minID = 0; minID = 0;
@ -888,15 +934,16 @@ angular.module('myApp.controllers', [])
if (curJump != jump || curMoreJump != moreJump) return; if (curJump != jump || curMoreJump != moreJump) return;
angular.forEach(historyResult.history, function (id) { angular.forEach(historyResult.history, function (id) {
$scope.history.unshift(AppMessagesManager.wrapForHistory(id)); peerHistory.messages.unshift(AppMessagesManager.wrapForHistory(id));
}); });
hasMore = historyResult.count === null || hasMore = historyResult.count === null ||
historyResult.history.length && $scope.history.length < historyResult.count; historyResult.history.length && peerHistory.messages.length < historyResult.count;
if (historyResult.history.length) { if (historyResult.history.length) {
maxID = historyResult.history[historyResult.history.length - 1]; maxID = historyResult.history[historyResult.history.length - 1];
AppMessagesManager.regroupWrappedHistory($scope.history, historyResult.history.length + 1); AppMessagesManager.regroupWrappedHistory(peerHistory.messages, historyResult.history.length + 1);
delete $scope.state.empty;
$scope.$broadcast('ui_history_prepend'); $scope.$broadcast('ui_history_prepend');
} }
}); });
@ -909,6 +956,8 @@ angular.module('myApp.controllers', [])
$scope.skippedHistory = hasLess = false; $scope.skippedHistory = hasLess = false;
maxID = 0; maxID = 0;
minID = 0; minID = 0;
peerHistory = historiesQueuePush(peerID);
var limit = 0, backLimit = 0; var limit = 0, backLimit = 0;
@ -923,6 +972,9 @@ angular.module('myApp.controllers', [])
else if (Config.Navigator.mobile) { else if (Config.Navigator.mobile) {
limit = 20; limit = 20;
} }
else if (peerHistory.messages.length > 0) {
limit = Math.min(20, peerHistory.messages.length);
}
var curJump = ++jump, var curJump = ++jump,
inputMediaFilter = $scope.historyFilter.mediaType && {_: inputMediaFilters[$scope.historyFilter.mediaType]}, inputMediaFilter = $scope.historyFilter.mediaType && {_: inputMediaFilters[$scope.historyFilter.mediaType]},
@ -935,6 +987,8 @@ angular.module('myApp.controllers', [])
getMessagesPromise.then(function (historyResult) { getMessagesPromise.then(function (historyResult) {
if (curJump != jump) return; if (curJump != jump) return;
var fetchedLength = historyResult.history.length;
minID = (historyResult.unreadSkip || maxID && historyResult.history.indexOf(maxID) >= backLimit - 1) minID = (historyResult.unreadSkip || maxID && historyResult.history.indexOf(maxID) >= backLimit - 1)
? historyResult.history[0] ? historyResult.history[0]
: 0; : 0;
@ -942,22 +996,22 @@ angular.module('myApp.controllers', [])
$scope.skippedHistory = hasLess = minID > 0; $scope.skippedHistory = hasLess = minID > 0;
hasMore = historyResult.count === null || hasMore = historyResult.count === null ||
historyResult.history.length && historyResult.history.length < historyResult.count; fetchedLength && fetchedLength < historyResult.count;
updateHistoryPeer(); updateHistoryPeer();
safeReplaceObject($scope.state, {loaded: true}); safeReplaceObject($scope.state, {loaded: true, empty: !fetchedLength});
$scope.history = []; peerHistory.messages = [];
angular.forEach(historyResult.history, function (id) { angular.forEach(historyResult.history, function (id) {
var message = AppMessagesManager.wrapForHistory(id); var message = AppMessagesManager.wrapForHistory(id);
if ($scope.skippedHistory) { if ($scope.skippedHistory) {
delete message.unread; delete message.unread;
} }
$scope.history.push(message); peerHistory.messages.push(message);
}); });
$scope.history.reverse(); peerHistory.messages.reverse();
AppMessagesManager.regroupWrappedHistory($scope.history); AppMessagesManager.regroupWrappedHistory(peerHistory.messages);
if (historyResult.unreadOffset) { if (historyResult.unreadOffset) {
$scope.historyUnreadAfter = historyResult.history[historyResult.unreadOffset - 1]; $scope.historyUnreadAfter = historyResult.history[historyResult.unreadOffset - 1];
@ -978,7 +1032,7 @@ angular.module('myApp.controllers', [])
function showEmptyHistory () { function showEmptyHistory () {
safeReplaceObject($scope.state, {notSelected: true}); safeReplaceObject($scope.state, {notSelected: true});
$scope.history = []; peerHistory = false;
hasMore = false; hasMore = false;
$scope.$broadcast('ui_history_change'); $scope.$broadcast('ui_history_change');
@ -1012,16 +1066,16 @@ angular.module('myApp.controllers', [])
var dir = lastSelectID > messageID, var dir = lastSelectID > messageID,
i, startPos, curMessageID; i, startPos, curMessageID;
for (i = 0; i < $scope.history.length; i++) { for (i = 0; i < peerHistory.messages.length; i++) {
if ($scope.history[i].id == lastSelectID) { if (peerHistory.messages[i].id == lastSelectID) {
startPos = i; startPos = i;
break; break;
} }
} }
i = startPos; i = startPos;
while ($scope.history[i] && while (peerHistory.messages[i] &&
(curMessageID = $scope.history[i].id) != messageID) { (curMessageID = peerHistory.messages[i].id) != messageID) {
if (!$scope.selectedMsgs[curMessageID]) { if (!$scope.selectedMsgs[curMessageID]) {
$scope.selectedMsgs[curMessageID] = true; $scope.selectedMsgs[curMessageID] = true;
$scope.selectedCount++; $scope.selectedCount++;
@ -1099,7 +1153,8 @@ angular.module('myApp.controllers', [])
function toggleMedia (mediaType) { function toggleMedia (mediaType) {
$scope.historyFilter.mediaType = mediaType || false; $scope.historyFilter.mediaType = mediaType || false;
$scope.history = []; peerHistory.messages = [];
$scope.state.empty = true;
loadHistory(); loadHistory();
} }
@ -1119,7 +1174,12 @@ angular.module('myApp.controllers', [])
var typingTimeouts = {}; var typingTimeouts = {};
$scope.$on('history_append', function (e, addedMessage) { $scope.$on('history_append', function (e, addedMessage) {
if (addedMessage.peerID == $scope.curDialog.peerID) { var history = historiesQueueFind(addedMessage.peerID);
if (!history) {
return;
}
var curPeer = addedMessage.peerID == $scope.curDialog.peerID;
if (curPeer) {
if ($scope.historyFilter.mediaType || $scope.skippedHistory) { if ($scope.historyFilter.mediaType || $scope.skippedHistory) {
if (addedMessage.my) { if (addedMessage.my) {
returnToRecent(); returnToRecent();
@ -1128,10 +1188,14 @@ angular.module('myApp.controllers', [])
} }
return; return;
} }
// console.log('append', addedMessage); delete $scope.state.empty;
// console.trace(); }
$scope.history.push(AppMessagesManager.wrapForHistory(addedMessage.messageID)); // console.log('append', addedMessage);
AppMessagesManager.regroupWrappedHistory($scope.history, -3); // console.trace();
history.messages.push(AppMessagesManager.wrapForHistory(addedMessage.messageID));
AppMessagesManager.regroupWrappedHistory(history.messages, -3);
if (curPeer) {
$scope.historyState.typing.splice(0, $scope.historyState.typing.length); $scope.historyState.typing.splice(0, $scope.historyState.typing.length);
$scope.$broadcast('ui_history_append_new', {my: addedMessage.my}); $scope.$broadcast('ui_history_append_new', {my: addedMessage.my});
if (addedMessage.my) { if (addedMessage.my) {
@ -1148,22 +1212,32 @@ angular.module('myApp.controllers', [])
}); });
$scope.$on('history_delete', function (e, historyUpdate) { $scope.$on('history_delete', function (e, historyUpdate) {
if (historyUpdate.peerID == $scope.curDialog.peerID) { var history = historiesQueueFind(historyUpdate.peerID);
var newHistory = []; if (!history) {
return;
}
var newMessages = [],
i;
for (var i = 0; i < $scope.history.length; i++) { for (i = 0; i < history.messages.length; i++) {
if (!historyUpdate.msgs[$scope.history[i].id]) { if (!historyUpdate.msgs[history.messages[i].id]) {
newHistory.push($scope.history[i]); newMessages.push(history.messages[i]);
} }
}; };
$scope.history = newHistory; history.messages = newMessages;
AppMessagesManager.regroupWrappedHistory($scope.history); AppMessagesManager.regroupWrappedHistory(history.messages);
if (historyUpdate.peerID == $scope.curDialog.peerID) {
$scope.state.empty = !newMessages.length;
} }
}); });
$scope.$on('dialog_flush', function (e, dialog) { $scope.$on('dialog_flush', function (e, dialog) {
if (dialog.peerID == $scope.curDialog.peerID) { var history = historiesQueueFind(dialog.peerID);
$scope.history = []; if (history) {
history.messages = [];
if (dialog.peerID == $scope.curDialog.peerID) {
$scope.state.empty = true;
}
} }
}); });

4
app/js/directives.js

@ -505,10 +505,10 @@ angular.module('myApp.directives', ['myApp.filters'])
function changeScroll () { function changeScroll () {
var unreadSplit, focusMessage; var unreadSplit, focusMessage;
if (focusMessage = $('.im_message_focus', scrollableWrap)[0]) { if (focusMessage = $('.im_message_focus:visible', scrollableWrap)[0]) {
scrollableWrap.scrollTop = Math.max(0, focusMessage.offsetTop - Math.floor(scrollableWrap.clientHeight / 2) + 26); scrollableWrap.scrollTop = Math.max(0, focusMessage.offsetTop - Math.floor(scrollableWrap.clientHeight / 2) + 26);
atBottom = false; atBottom = false;
} else if (unreadSplit = $('.im_message_unread_split', scrollableWrap)[0]) { } else if (unreadSplit = $('.im_message_unread_split:visible', scrollableWrap)[0]) {
scrollableWrap.scrollTop = Math.max(0, unreadSplit.offsetTop - 52); scrollableWrap.scrollTop = Math.max(0, unreadSplit.offsetTop - 52);
atBottom = false; atBottom = false;
} else { } else {

7
app/partials/im.html

@ -157,14 +157,17 @@
<div class="im_history_scrollable"> <div class="im_history_scrollable">
<div class="im_history" ng-class="{im_history_selectable: historyState.selectActions}"> <div class="im_history" ng-class="{im_history_selectable: historyState.selectActions}">
<div ng-if="!history.length" class="im_history_empty" ng-switch="state.mayBeHasMore" my-vertical-position="0.25" padding="true"> <div ng-if="state.empty" class="im_history_empty" ng-switch="state.mayBeHasMore" my-vertical-position="0.25" padding="true">
<span ng-switch-when="true">Loading history<span my-loading-dots></span></span> <span ng-switch-when="true">Loading history<span my-loading-dots></span></span>
<span ng-switch-default>No messages here yet...</span> <span ng-switch-default>No messages here yet...</span>
</div> </div>
<div class="im_history_messages" ng-class="{im_history_messages_group: historyPeer.id < 0}"> <div class="im_history_messages" ng-class="{im_history_messages_group: historyPeer.id < 0}">
<div class="im_history_message_wrap" my-message ng-repeat="historyMessage in history"></div> <div ng-show="peerHistory.peerID == historyPeer.id" ng-repeat="peerHistory in peerHistories">
<div class="im_history_message_wrap" my-message ng-repeat="historyMessage in peerHistory.messages"></div>
</div>
</div> </div>
</div> </div>
<div class="im_history_typing_wrap"> <div class="im_history_typing_wrap">

Loading…
Cancel
Save