Commit Graph

582 Commits

Author SHA1 Message Date
Miłosz Sieradzki
3c8e46188a Fix that NullPointerException should NEVER be thrown by programmer, make exceptions more informative, simplify code logic, flip equals() on strings
...and other small fixes
2014-07-25 20:18:44 +02:00
Miłosz Sieradzki
c7b97621c7 Make util class non-instantiatable and non-extendable, flip equals() on strings, remove redundant code 2014-07-25 20:17:03 +02:00
Miłosz Sieradzki
d47d03b7af Add missing 'private' and 'public' access' modifiers, fix warnings 2014-07-25 20:16:09 +02:00
Miłosz Sieradzki
e0ae78cfcd Remove redundant variable initialization, flip equals() on strings 2014-07-25 20:15:20 +02:00
Miłosz Sieradzki
299c5ae6eb Add logging exception, fix typo in comment 2014-07-25 20:14:35 +02:00
Miłosz Sieradzki
f36fd4bb8a Use interface instead of concrete class, add missing @Override 2014-07-25 20:02:57 +02:00
Miłosz Sieradzki
4c409c209f Make util class non-instantiatable and non-extendable 2014-07-25 20:00:58 +02:00
Miłosz Sieradzki
82d8af3057 Fix method names, redundant initialization of variables, typos in comments and other improvements 2014-07-25 19:59:55 +02:00
Miłosz Sieradzki
a33f3a340a Fix "'handlers.size() == 0' can be replaced with 'handlers.isEmpty()'" 2014-07-25 19:35:41 +02:00
Miłosz Sieradzki
b9320522c7 Add missing equals() and hashCode() methods for class that implements Comparable<T> 2014-07-25 19:34:49 +02:00
Miłosz Sieradzki
406af6e699 Add missing @Override annotation, remove unnecessary code 2014-07-25 19:33:53 +02:00
Miłosz Sieradzki
f90f9fa877 Make util class non-instantiatable and non-extendable. 2014-07-25 19:33:29 +02:00
Miłosz Sieradzki
3d14b3aa11 Remove unnecessary code 2014-07-25 19:31:59 +02:00
Miłosz Sieradzki
c883c82d67 Add missing @Override annotation 2014-07-25 19:31:33 +02:00
Anthony Restaino
532d6adbea Merge pull request #113 from DF1E/master
remove useless layouts
2014-07-24 09:45:34 -04:00
Anthony Restaino
9068c830f5 Merge pull request #114 from pejakm/srtr
[Translations] Update Serbian
2014-07-24 09:43:27 -04:00
Mladen Pejaković
1a2e84872a [Translations] Update Serbian 2014-07-23 12:54:23 +02:00
DF1E
3c28cb7ef6 remove useless layouts 2014-07-23 10:23:53 +02:00
Anthony Restaino
17789d848b Lint fixes 2014-07-22 19:19:24 -04:00
Anthony Restaino
60574c0db9 Fixed Video full-screen not working 2014-07-22 18:50:20 -04:00
Anthony Restaino
ae40af0b9e Removed libs... apparently crashes the build 2014-07-22 18:40:51 -04:00
Anthony Restaino
c939e7e225 Updated with lib addition 2014-07-22 18:36:36 -04:00
Anthony Restaino
2876fa9609 Merge pull request #112 from kuc/travis-ci
Add automated continuous integration testing using Travis CI
2014-07-22 18:20:20 -04:00
Anthony Restaino
4069adaa06 Merge pull request #111 from kuc/fix-adblock
Fix AdBlock
2014-07-22 18:13:50 -04:00
Miłosz Sieradzki
f8c1506a8a Update target in properties and scripts to match value from AndroidManifest.xml; make exception for Travis 2014-07-22 21:05:49 +02:00
Miłosz Sieradzki
d85019ec72 Add logging 2014-07-21 18:55:22 +02:00
Miłosz Sieradzki
9c1b0c703e Fix overwriting AdBlock instance by every new created LightningView object 2014-07-21 18:27:09 +02:00
Miłosz Sieradzki
09f23553a4 Fix AdBlock collection type and other problems 2014-07-21 18:22:12 +02:00
Miłosz Sieradzki
c03acc0f44 Merge branch 'master' into travis-ci 2014-07-21 17:41:46 +02:00
Anthony Restaino
d128000c73 Merge pull request #109 from DF1E/master
fix spelling in german string
2014-07-21 07:20:09 -04:00
DF1E
93860a3efa fix spelling in german string 2014-07-21 08:38:37 +02:00
Anthony Restaino
fbd74df422 Improved comment readability in IDE editor 2014-07-20 20:08:12 -04:00
Anthony Restaino
a21ddb3a13 Note on intent utils 2014-07-20 19:58:19 -04:00
Anthony Restaino
a3080175f3 removed useless layout params 2014-07-20 19:23:46 -04:00
Anthony Restaino
a56352de6c Merge pull request #108 from kuc/code-cleanup
Code cleanup - part 1
2014-07-20 19:21:40 -04:00
Miłosz Sieradzki
371a8b0ef6 Add windows version of setup-ant.sh file 2014-07-20 15:57:59 +02:00
Miłosz Sieradzki
4e303ae4c2 Fix all lint errors 'Error: "STRING" is translated here but not found in default locale [ExtraTranslation]' 2014-07-20 13:27:31 +02:00
Miłosz Sieradzki
6f8c66cb99 Fix lint error in settings activity layout 2014-07-20 13:20:50 +02:00
Miłosz Sieradzki
046f839ccf Fix typo 2014-07-20 13:18:21 +02:00
Miłosz Sieradzki
c9bc6e5699 Fix lint errors and warnings in license activity layout 2014-07-20 13:17:53 +02:00
Miłosz Sieradzki
a0b0deab90 Fix path to library 2014-07-20 13:05:19 +02:00
Miłosz Sieradzki
00e66547af Fix "Error: No .class files were found in project ".", so none of the classfile based checks could be run." 2014-07-20 13:04:45 +02:00
Miłosz Sieradzki
335beb1a00 Configure android lint 2014-07-20 01:09:01 +02:00
Miłosz Sieradzki
b9086baf0b Add empty missing file ant.properties 2014-07-19 22:28:01 +02:00
Miłosz Sieradzki
a40a9e70ed Allow accepting any android-sdk-license in tests, remove unused sysimg 2014-07-19 22:07:22 +02:00
Miłosz Sieradzki
b4032aeb6e Simple Travis CI setup: test if project will compile to APK successfully 2014-07-19 21:54:48 +02:00
Miłosz Sieradzki
0cf218018c Clean up SettingsActivity and AdvancedSettingsActivity
* field that are overwritten from every class instance SHOULD NOT be "static"
* some field could and was converted to local variables
* add missing "private" qualifier here and there
* action bar may be null, added checking for this
* remove wrapping all method body in try-catch, moved it to method call
* removed redundant field and local variable initializations
* single-char string replaced with char
* redundant qualifiers ("SettingsActivity.this" etc.) was removed
2014-07-19 18:22:33 +02:00
Miłosz Sieradzki
dafd684096 Clean up AdBlock class
* use interface instead of concrete class
* inline initialization of static variable
* remove redundant field and variable initialization
* replace single-character string with char
2014-07-19 17:39:51 +02:00
Miłosz Sieradzki
de031977ce Fix file name not matching class name 2014-07-19 17:32:26 +02:00
Miłosz Sieradzki
005e75fc8d Restore consistency in code formatting
* remove all trailing spaces
* some files used spaces instead of tabs like the rest of codebase - fixed
* make use of IDE "optimize import" feature
* make use of IDE "auto format" feature to fix some missing spaces here and there
2014-07-19 16:49:33 +02:00