r4sas/lightning-i2p
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Don't clear the HashMap, instead just change the reference

Browse Source
This commit is contained in:
Anthony Restaino 2015-09-09 21:32:05 -04:00
parent 5dff2db5df
commit dbf0457d79
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/acr/browser/lightning/database/BookmarkManager.java
View File

@ -51,7 +51,7 @@ public class BookmarkManager {
private final String DEFAULT_BOOKMARK_TITLE; private final String DEFAULT_BOOKMARK_TITLE;
private final Map<String, HistoryItem> mBookmarksMap = new HashMap<>(); private Map<String, HistoryItem> mBookmarksMap;
// private final List<HistoryItem> mBookmarkList = new ArrayList<>(); // private final List<HistoryItem> mBookmarkList = new ArrayList<>();
private String mCurrentFolder = ""; private String mCurrentFolder = "";
private final ExecutorService mExecutor; private final ExecutorService mExecutor;
@ -131,8 +131,7 @@ public class BookmarkManager {
} finally { } finally {
Utils.close(bookmarksReader); Utils.close(bookmarksReader);
} }
mBookmarksMap.clear(); mBookmarksMap = bookmarks;
mBookmarksMap.putAll(bookmarks);
mReady = true; mReady = true;
} }
} }
@ -283,8 +282,7 @@ public class BookmarkManager {
bookmarks.put(url, item); bookmarks.put(url, item);
} }
} }
mBookmarksMap.clear(); mBookmarksMap = bookmarks;
mBookmarksMap.putAll(bookmarks);
mExecutor.execute(new BookmarksWriter(new LinkedList<>(mBookmarksMap.values()))); mExecutor.execute(new BookmarksWriter(new LinkedList<>(mBookmarksMap.values())));
} }