From c684472f6e4e280e098add0f6596088e76d28f13 Mon Sep 17 00:00:00 2001 From: Anthony Restaino Date: Sat, 6 Feb 2016 22:27:08 -0500 Subject: [PATCH] Add new tab button to desktop tabs view --- .../lightning/activity/BrowserActivity.java | 5 ++++ .../lightning/controller/UIController.java | 2 ++ .../lightning/fragment/TabsFragment.java | 8 ++++++ app/src/main/res/layout/tab_strip.xml | 25 ++++++++++++++++--- 4 files changed, 36 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java b/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java index b70ec36..15b217a 100644 --- a/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java +++ b/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java @@ -1023,6 +1023,11 @@ public abstract class BrowserActivity extends ThemableBrowserActivity implements return mPresenter.newTab(url, show); } + @Override + public void newTabClicked() { + mPresenter.newTab(null, true); + } + // TODO move this to presenter private synchronized void deleteTab(int position) { mPresenter.deleteTab(position); diff --git a/app/src/main/java/acr/browser/lightning/controller/UIController.java b/app/src/main/java/acr/browser/lightning/controller/UIController.java index 19a080a..9a00027 100644 --- a/app/src/main/java/acr/browser/lightning/controller/UIController.java +++ b/app/src/main/java/acr/browser/lightning/controller/UIController.java @@ -53,4 +53,6 @@ public interface UIController { void showCloseDialog(int position); + void newTabClicked(); + } diff --git a/app/src/main/java/acr/browser/lightning/fragment/TabsFragment.java b/app/src/main/java/acr/browser/lightning/fragment/TabsFragment.java index 566c71d..f0397cd 100644 --- a/app/src/main/java/acr/browser/lightning/fragment/TabsFragment.java +++ b/app/src/main/java/acr/browser/lightning/fragment/TabsFragment.java @@ -112,6 +112,14 @@ public class TabsFragment extends Fragment implements View.OnClickListener, View } else { view = inflater.inflate(R.layout.tab_strip, container, false); layoutManager = new LinearLayoutManager(getContext(), LinearLayoutManager.HORIZONTAL, false); + ImageView newTab = (ImageView) view.findViewById(R.id.new_tab_button); + newTab.setColorFilter(ThemeUtils.getIconDarkThemeColor(getActivity())); + newTab.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + mUiController.newTabClicked(); + } + }); } RecyclerView recyclerView = (RecyclerView) view.findViewById(R.id.tabs_list); recyclerView.setLayoutManager(layoutManager); diff --git a/app/src/main/res/layout/tab_strip.xml b/app/src/main/res/layout/tab_strip.xml index 99f6e3c..49256fc 100644 --- a/app/src/main/res/layout/tab_strip.xml +++ b/app/src/main/res/layout/tab_strip.xml @@ -1,9 +1,26 @@ - + android:orientation="horizontal" + android:weightSum="1"> + + + + +