From bee7d4b8dd8ef428697807ca3b3271d212f643b4 Mon Sep 17 00:00:00 2001
From: anthony restaino <anthonyrestaino11@gmail.com>
Date: Tue, 6 Jun 2017 20:26:31 -0400
Subject: [PATCH] Ensuring that bookmark export failures are handled

---
 .../lightning/fragment/BookmarkSettingsFragment.java  | 11 +++++++++++
 app/src/main/res/values/strings.xml                   |  1 +
 2 files changed, 12 insertions(+)

diff --git a/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java b/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java
index 4e965ff..48c4e5e 100644
--- a/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java
+++ b/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java
@@ -211,6 +211,17 @@ public class BookmarkSettingsFragment extends PreferenceFragment implements Pref
                                                             + ' ' + exportFile.getPath());
                                                     }
                                                 }
+
+                                                @Override
+                                                public void onError(@NonNull Throwable throwable) {
+                                                    Log.e(TAG, "onError: exporting bookmarks", throwable);
+                                                    Activity activity = getActivity();
+                                                    if (activity != null) {
+                                                        Utils.createInformativeDialog(activity, R.string.title_error, R.string.bookmark_export_failure);
+                                                    } else {
+                                                        Utils.showToast(mApplication, R.string.bookmark_export_failure);
+                                                    }
+                                                }
                                             });
                                     }
                                 });
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 51cf5bb..cda38c4 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -176,6 +176,7 @@
     <string name="export_bookmarks">Export bookmarks to backup</string>
     <string name="import_backup">Import bookmarks from backup</string>
     <string name="bookmark_export_path">Bookmarks exported to</string>
+    <string name="bookmark_export_failure">Sorry, bookmarks could not be exported!</string>
     <string name="bookmark_settings">Bookmark Settings</string>
     <string name="import_bookmark_error">Could not import bookmarks from file</string>
     <string name="title_chooser">Choose a file</string>