Use OkHttp to download images

app/build.gradle

@@ -94,6 +94,8 @@ dependencies {
     // proxy support
     compile 'net.i2p.android:client:0.8'
 
+    compile 'com.squareup.okhttp3:okhttp:3.7.0'
+
     // tor proxy
     def netcipherVersion = '2.0.0-alpha1'
     compile "info.guardianproject.netcipher:netcipher:$netcipherVersion"

app/src/main/java/acr/browser/lightning/favicon/FaviconUtils.java

@@ -6,9 +6,8 @@ import android.support.annotation.Nullable;
 import android.text.TextUtils;
 
 /**
- * Created by anthonycr on 4/13/17.
+ * Simple utils for favicon fetching.
  */
-
 class FaviconUtils {
     @Nullable
     static Uri safeUri(@NonNull String url) {

app/src/main/java/acr/browser/lightning/favicon/ImageFetcher.java

@@ -9,10 +9,11 @@ import android.util.Log;
 
 import java.io.File;
 import java.io.InputStream;
-import java.net.HttpURLConnection;
-import java.net.URL;
 
 import acr.browser.lightning.utils.Utils;
+import okhttp3.OkHttpClient;
+import okhttp3.Request;
+import okhttp3.Response;
 
 /**
  * An image fetcher that creates image
@@ -23,9 +24,9 @@ class ImageFetcher {
     private static final String TAG = "ImageFetcher";
 
     @NonNull private final BitmapFactory.Options mLoaderOptions = new BitmapFactory.Options();
+    @NonNull private final OkHttpClient mHttpClient = new OkHttpClient();
 
-    ImageFetcher() {
+    ImageFetcher() {}
-    }
 
     @Nullable
     Bitmap retrieveFaviconFromCache(@NonNull File cacheFile) {
@@ -45,37 +46,50 @@ class ImageFetcher {
     Bitmap retrieveBitmapFromGoogle(@NonNull Uri uri) {
         FaviconUtils.assertUriSafe(uri);
 
-        String googleFaviconUrl = "https://www.google.com/s2/favicons?domain_url=" + uri.toString();
+        String googleFaviconUrl = "https://www.google.com/s2/favicons?domain_url=" + uri.getHost();
 
         return retrieveBitmapFromUrl(googleFaviconUrl);
     }
 
-
     @Nullable
     private Bitmap retrieveBitmapFromUrl(@NonNull String url) {
-        InputStream in = null;
         Bitmap icon = null;
 
+        InputStream boundsStream = null;
+        InputStream iconStream = null;
+
         try {
-            final URL urlDownload = new URL(url);
+            mLoaderOptions.inSampleSize = 1;
-            final HttpURLConnection connection = (HttpURLConnection) urlDownload.openConnection();
+            mLoaderOptions.inJustDecodeBounds = true;
-            connection.setDoInput(true);
+
-            connection.setConnectTimeout(1000);
+            Request imageRequest = new Request.Builder().url(url).build();
-            connection.setReadTimeout(1000);
+
-            connection.connect();
+            Response boundsResponse = mHttpClient.newCall(imageRequest).execute();
-            in = connection.getInputStream();
+            boundsStream = boundsResponse.body().byteStream();
-
+
-            if (in != null) {
+            BitmapFactory.decodeStream(boundsStream, null, mLoaderOptions);
-                icon = BitmapFactory.decodeStream(in, null, mLoaderOptions);
+
-            }
+            boundsResponse.body().close();
-        } catch (Exception ignored) {
+
-            Log.d(TAG, "Could not download icon from: " + url);
+            int size = Utils.dpToPx(24);
+
+            mLoaderOptions.inJustDecodeBounds = false;
+            mLoaderOptions.inSampleSize = Utils.calculateInSampleSize(mLoaderOptions, size, size);
+
+            Response imageResponse = mHttpClient.newCall(imageRequest).execute();
+            iconStream = imageResponse.body().byteStream();
+
+            icon = BitmapFactory.decodeStream(iconStream, null, mLoaderOptions);
+
+            imageResponse.body().close();
+        } catch (Exception e) {
+            Log.d(TAG, "Unable to download icon: " + url);
         } finally {
-            Utils.close(in);
+            Utils.close(boundsStream);
+            Utils.close(iconStream);
         }
 
         return icon;
     }
 
-
 }

app/src/main/java/acr/browser/lightning/utils/Utils.java

@@ -256,6 +256,7 @@ public final class Utils {
      * @param bitmap is the bitmap to pad.
      * @return the padded bitmap.
      */
+    @NonNull
     public static Bitmap padFavicon(@NonNull Bitmap bitmap) {
         int padding = Utils.dpToPx(4);