From 5c8fd41c6b9288715646904709bafe315342f684 Mon Sep 17 00:00:00 2001
From: Anthony Restaino <anthonyrestaino11@gmail.com>
Date: Tue, 15 Sep 2015 23:02:49 -0400
Subject: [PATCH] Made inner classes static to discourage access within of
 enclosing class

---
 .../java/acr/browser/lightning/activity/BrowserActivity.java  | 2 +-
 .../browser/lightning/fragment/BookmarkSettingsFragment.java  | 2 +-
 .../main/java/acr/browser/lightning/object/SearchAdapter.java | 4 ++--
 .../acr/browser/lightning/reading/ArticleTextExtractor.java   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java b/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java
index bc6ba27..29b6e61 100644
--- a/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java
+++ b/app/src/main/java/acr/browser/lightning/activity/BrowserActivity.java
@@ -1930,7 +1930,7 @@ public abstract class BrowserActivity extends ThemableBrowserActivity implements
     /**
      * a class extending FramLayout used to display fullscreen videos
      */
-    private class FullscreenHolder extends FrameLayout {
+    private static class FullscreenHolder extends FrameLayout {
 
         public FullscreenHolder(Context ctx) {
             super(ctx);
diff --git a/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java b/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java
index d3b7e65..a2926a2 100644
--- a/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java
+++ b/app/src/main/java/acr/browser/lightning/fragment/BookmarkSettingsFragment.java
@@ -114,7 +114,7 @@ public class BookmarkSettingsFragment extends PreferenceFragment implements Pref
         }
     }
 
-    private class SortName implements Comparator<File> {
+    private static class SortName implements Comparator<File> {
 
         @Override
         public int compare(File a, File b) {
diff --git a/app/src/main/java/acr/browser/lightning/object/SearchAdapter.java b/app/src/main/java/acr/browser/lightning/object/SearchAdapter.java
index 2ef2151..abb2e61 100644
--- a/app/src/main/java/acr/browser/lightning/object/SearchAdapter.java
+++ b/app/src/main/java/acr/browser/lightning/object/SearchAdapter.java
@@ -108,7 +108,7 @@ public class SearchAdapter extends BaseAdapter implements Filterable {
         }
     }
 
-    private class NameFilter implements FilenameFilter {
+    private static class NameFilter implements FilenameFilter {
 
         @Override
         public boolean accept(File dir, String filename) {
@@ -273,7 +273,7 @@ public class SearchAdapter extends BaseAdapter implements Filterable {
 
     }
 
-    private class SuggestionHolder {
+    private static class SuggestionHolder {
         ImageView mImage;
         TextView mTitle;
         TextView mUrl;
diff --git a/app/src/main/java/acr/browser/lightning/reading/ArticleTextExtractor.java b/app/src/main/java/acr/browser/lightning/reading/ArticleTextExtractor.java
index 6ce4321..9e33e92 100644
--- a/app/src/main/java/acr/browser/lightning/reading/ArticleTextExtractor.java
+++ b/app/src/main/java/acr/browser/lightning/reading/ArticleTextExtractor.java
@@ -1208,7 +1208,7 @@ public class ArticleTextExtractor {
      *
      * @author Chris Alexander, chris@chris-alexander.co.uk
      */
-    private class ImageComparator implements Comparator<ImageResult> {
+    private static class ImageComparator implements Comparator<ImageResult> {
 
         @Override
         public int compare(ImageResult o1, ImageResult o2) {