r4sas/lightning-i2p
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Changes to make Incognito mode more secure and less likely to leak data to websites.

Browse Source 
Changes for Incognito Settings
* Always disable location (even if explicitly set in settings)
* Never save passwords or form data
* Always set mixed content mode to NEVER ALLOW
* Disable DOM storage
This commit is contained in:
Anthony Restaino 2015-01-31 22:36:19 -05:00
parent 43950d4f71
commit 489a814f54
1 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/acr/browser/lightning/LightningView.java
View File

@ -275,8 +275,12 @@ public class LightningView {
setColorMode(mPreferences.getInt(PreferenceConstants.RENDERING_MODE, 0)); setColorMode(mPreferences.getInt(PreferenceConstants.RENDERING_MODE, 0));
mSettings.setGeolocationEnabled(mPreferences if (!mBrowserController.isIncognito()) {
.getBoolean(PreferenceConstants.LOCATION, false)); mSettings.setGeolocationEnabled(mPreferences.getBoolean(PreferenceConstants.LOCATION,
false));
} else {
mSettings.setGeolocationEnabled(false);
}
if (API < 19) { if (API < 19) {
switch (mPreferences.getInt(PreferenceConstants.ADOBE_FLASH_SUPPORT, 0)) { switch (mPreferences.getInt(PreferenceConstants.ADOBE_FLASH_SUPPORT, 0)) {
case 0: case 0:
@ -313,11 +317,17 @@ public class LightningView {
break; break;
} }
if (mPreferences.getBoolean(PreferenceConstants.SAVE_PASSWORDS, false)) { if (mPreferences.getBoolean(PreferenceConstants.SAVE_PASSWORDS, false)
&& !mBrowserController.isIncognito()) {
if (API < 18) { if (API < 18) {
mSettings.setSavePassword(true); mSettings.setSavePassword(true);
} }
mSettings.setSaveFormData(true); mSettings.setSaveFormData(true);
} else {
if (API < 18) {
mSettings.setSavePassword(false);
}
mSettings.setSaveFormData(false);
} }
if (mPreferences.getBoolean(PreferenceConstants.JAVASCRIPT, true)) { if (mPreferences.getBoolean(PreferenceConstants.JAVASCRIPT, true)) {
@ -388,12 +398,18 @@ public class LightningView {
if (API < 19) { if (API < 19) {
settings.setDatabasePath(context.getCacheDir() + "/databases"); settings.setDatabasePath(context.getCacheDir() + "/databases");
} }
if (API >= Build.VERSION_CODES.LOLLIPOP) { if (API >= Build.VERSION_CODES.LOLLIPOP && !mBrowserController.isIncognito()) {
mWebView.getSettings() settings.setMixedContentMode(WebSettings.MIXED_CONTENT_COMPATIBILITY_MODE);
.setMixedContentMode(WebSettings.MIXED_CONTENT_COMPATIBILITY_MODE); } else if (API >= Build.VERSION_CODES.LOLLIPOP) {
// We're in Incognito mode, reject
settings.setMixedContentMode(WebSettings.MIXED_CONTENT_NEVER_ALLOW);
} }
// TODO // TODO
settings.setDomStorageEnabled(true); if (!mBrowserController.isIncognito()) {
settings.setDomStorageEnabled(true);
} else {
settings.setDomStorageEnabled(false);
}
settings.setAppCacheEnabled(true); settings.setAppCacheEnabled(true);
settings.setAppCachePath(context.getCacheDir().toString()); settings.setAppCachePath(context.getCacheDir().toString());
settings.setCacheMode(WebSettings.LOAD_DEFAULT); settings.setCacheMode(WebSettings.LOAD_DEFAULT);