From 3c48ee23e9516a3357bf894a09d279a5dcf4e95c Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Fri, 3 Nov 2023 09:47:01 +0100 Subject: [PATCH 1/2] Small cleanup --- .../kotlin/io/element/android/appconfig/LockScreenConfig.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt b/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt index 04446072b6..7a274ddfbc 100644 --- a/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt +++ b/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt @@ -33,7 +33,7 @@ data class LockScreenConfig( val isPinMandatory: Boolean, /** - * Some PINs are blacklisted. + * Some PINs are forbidden. */ val pinBlacklist: Set, @@ -56,6 +56,7 @@ data class LockScreenConfig( * Authentication with strong methods (fingerprint, some face/iris unlock implementations) is supported. */ val isStrongBiometricsEnabled: Boolean, + /** * Authentication with weak methods (most face/iris unlock implementations) is supported. */ From e0a975835beb0f4f5c73f4ea338cc40a57da5cc0 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Fri, 3 Nov 2023 09:47:08 +0100 Subject: [PATCH 2/2] Set lock grace period to 0 #1732 --- .../kotlin/io/element/android/appconfig/LockScreenConfig.kt | 2 +- changelog.d/1732.misc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelog.d/1732.misc diff --git a/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt b/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt index 7a274ddfbc..edeb0c0643 100644 --- a/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt +++ b/appconfig/src/main/kotlin/io/element/android/appconfig/LockScreenConfig.kt @@ -73,7 +73,7 @@ object LockScreenConfigModule { pinBlacklist = setOf("0000", "1234"), pinSize = 4, maxPinCodeAttemptsBeforeLogout = 3, - gracePeriod = 90.seconds, + gracePeriod = 0.seconds, isStrongBiometricsEnabled = true, isWeakBiometricsEnabled = true, ) diff --git a/changelog.d/1732.misc b/changelog.d/1732.misc new file mode 100644 index 0000000000..f5fa5be982 --- /dev/null +++ b/changelog.d/1732.misc @@ -0,0 +1 @@ +Set lock grace period to 0.