From cf3b2bba91595f5f4080c45b72107737febb6cbb Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 23 May 2024 00:20:24 +0200
Subject: [PATCH] Add test on isRelevant

---
 .../troubleshoot/FirebaseAvailabilityTestTest.kt    | 12 ++++++++++++
 .../firebase/troubleshoot/FirebaseTokenTestTest.kt  | 13 +++++++++++++
 .../unifiedpush/troubleshoot/UnifiedPushTestTest.kt |  2 +-
 3 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTestTest.kt b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTestTest.kt
index 4b85683942..fae5ba9f12 100644
--- a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTestTest.kt
+++ b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTestTest.kt
@@ -19,7 +19,9 @@ package io.element.android.libraries.pushproviders.firebase.troubleshoot
 import app.cash.turbine.test
 import com.google.common.truth.Truth.assertThat
 import io.element.android.libraries.pushproviders.firebase.FakeIsPlayServiceAvailable
+import io.element.android.libraries.pushproviders.firebase.FirebaseConfig
 import io.element.android.libraries.troubleshoot.api.test.NotificationTroubleshootTestState
+import io.element.android.libraries.troubleshoot.api.test.TestFilterData
 import io.element.android.services.toolbox.test.strings.FakeStringProvider
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.test.runTest
@@ -59,4 +61,14 @@ class FirebaseAvailabilityTestTest {
             assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
         }
     }
+
+    @Test
+    fun `test FirebaseAvailabilityTest isRelevant`() {
+        val sut = FirebaseAvailabilityTest(
+            isPlayServiceAvailable = FakeIsPlayServiceAvailable(false),
+            stringProvider = FakeStringProvider(),
+        )
+        assertThat(sut.isRelevant(TestFilterData(currentPushProviderName = "unknown"))).isFalse()
+        assertThat(sut.isRelevant(TestFilterData(currentPushProviderName = FirebaseConfig.NAME))).isTrue()
+    }
 }
diff --git a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTestTest.kt b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTestTest.kt
index 2d8de62ad9..245a6095d4 100644
--- a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTestTest.kt
+++ b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTestTest.kt
@@ -19,8 +19,10 @@ package io.element.android.libraries.pushproviders.firebase.troubleshoot
 import app.cash.turbine.test
 import com.google.common.truth.Truth.assertThat
 import io.element.android.libraries.pushproviders.firebase.FakeFirebaseTroubleshooter
+import io.element.android.libraries.pushproviders.firebase.FirebaseConfig
 import io.element.android.libraries.pushproviders.firebase.InMemoryFirebaseStore
 import io.element.android.libraries.troubleshoot.api.test.NotificationTroubleshootTestState
+import io.element.android.libraries.troubleshoot.api.test.TestFilterData
 import io.element.android.services.toolbox.test.strings.FakeStringProvider
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.test.runTest
@@ -75,6 +77,17 @@ class FirebaseTokenTestTest {
         }
     }
 
+    @Test
+    fun `test FirebaseTokenTest isRelevant`() {
+        val sut = FirebaseTokenTest(
+            firebaseStore = InMemoryFirebaseStore(null),
+            firebaseTroubleshooter = FakeFirebaseTroubleshooter(),
+            stringProvider = FakeStringProvider(),
+        )
+        assertThat(sut.isRelevant(TestFilterData(currentPushProviderName = "unknown"))).isFalse()
+        assertThat(sut.isRelevant(TestFilterData(currentPushProviderName = FirebaseConfig.NAME))).isTrue()
+    }
+
     companion object {
         private const val FAKE_TOKEN = "abcdefghijk"
     }
diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTestTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTestTest.kt
index 7fc4d2c0a5..9f79f7363b 100644
--- a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTestTest.kt
+++ b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTestTest.kt
@@ -85,7 +85,7 @@ class UnifiedPushTestTest {
     }
 
     @Test
-    fun `test isRelevant`() = runTest {
+    fun `test isRelevant`() {
         val sut = UnifiedPushTest(
             unifiedPushDistributorProvider = FakeUnifiedPushDistributorProvider(),
             openDistributorWebPageAction = FakeOpenDistributorWebPageAction(),