Browse Source

Fix test by making the whole ListItem clickable.

Also improve height of View to let the test see the View.
pull/2922/head
Benoit Marty 4 months ago
parent
commit
b30076ecca
  1. 3
      features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsViewTest.kt
  2. 2
      libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/PreferenceCheckbox.kt
  3. 2
      libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/PreferenceSwitch.kt

3
features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsViewTest.kt

@ -82,6 +82,7 @@ class DeveloperSettingsViewTest { @@ -82,6 +82,7 @@ class DeveloperSettingsViewTest {
}
}
@Config(qualifiers = "h1024dp")
@Test
fun `clicking on configure tracing invokes the expected callback`() {
val eventsRecorder = EventsRecorder<DeveloperSettingsEvents>(expectEvents = false)
@ -96,7 +97,7 @@ class DeveloperSettingsViewTest { @@ -96,7 +97,7 @@ class DeveloperSettingsViewTest {
}
}
@Config(qualifiers = "h1024dp")
@Config(qualifiers = "h1500dp")
@Test
fun `clicking on clear cache emits the expected event`() {
val eventsRecorder = EventsRecorder<DeveloperSettingsEvents>()

2
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/PreferenceCheckbox.kt

@ -47,6 +47,7 @@ fun PreferenceCheckbox( @@ -47,6 +47,7 @@ fun PreferenceCheckbox(
) {
ListItem(
modifier = modifier,
onClick = onCheckedChange.takeIf { enabled }?.let { { onCheckedChange(!isChecked) } },
leadingContent = preferenceIcon(
icon = icon,
iconResourceId = iconResourceId,
@ -71,7 +72,6 @@ fun PreferenceCheckbox( @@ -71,7 +72,6 @@ fun PreferenceCheckbox(
},
trailingContent = ListItemContent.Checkbox(
checked = isChecked,
onChange = onCheckedChange,
enabled = enabled,
),
)

2
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/PreferenceSwitch.kt

@ -46,6 +46,7 @@ fun PreferenceSwitch( @@ -46,6 +46,7 @@ fun PreferenceSwitch(
ListItem(
modifier = modifier,
enabled = enabled,
onClick = onCheckedChange.takeIf { enabled }?.let { { onCheckedChange(!isChecked) } },
leadingContent = preferenceIcon(
icon = icon,
iconResourceId = iconResourceId,
@ -68,7 +69,6 @@ fun PreferenceSwitch( @@ -68,7 +69,6 @@ fun PreferenceSwitch(
},
trailingContent = ListItemContent.Switch(
checked = isChecked,
onChange = onCheckedChange,
enabled = enabled,
)
)

Loading…
Cancel
Save