From b2d9b41946761b4df33e008c27fbc41a865a3e3f Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 4 Dec 2023 15:21:25 +0100 Subject: [PATCH] Add Konsist test to use isFalse() instead of isEqualTo(false), and fix existing issues. --- .../impl/send/SendLocationPresenterTest.kt | 18 +++--- .../impl/show/ShowLocationPresenterTest.kt | 36 +++++------ .../impl/unlock/PinUnlockPresenterTest.kt | 4 +- .../MessageComposerPresenterTest.kt | 2 +- .../timeline/DefaultVoiceMessagePlayerTest.kt | 62 +++++++++---------- .../impl/root/PreferencesRootPresenterTest.kt | 2 +- .../edit/RoomDetailsEditPresenterTest.kt | 18 +++--- .../impl/DefaultFeatureFlagServiceTest.kt | 4 +- .../android/tests/konsist/KonsistTestTest.kt | 12 ++++ 9 files changed, 85 insertions(+), 73 deletions(-) diff --git a/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/send/SendLocationPresenterTest.kt b/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/send/SendLocationPresenterTest.kt index 37453b2e22..772152eed2 100644 --- a/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/send/SendLocationPresenterTest.kt +++ b/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/send/SendLocationPresenterTest.kt @@ -132,14 +132,14 @@ class SendLocationPresenterTest { val initialState = awaitItem() assertThat(initialState.permissionDialog).isEqualTo(SendLocationState.Dialog.None) assertThat(initialState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(initialState.hasLocationPermission).isEqualTo(false) + assertThat(initialState.hasLocationPermission).isFalse() // Click on the button to switch mode initialState.eventSink(SendLocationEvents.SwitchToMyLocationMode) val myLocationState = awaitItem() assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionDenied) assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(myLocationState.hasLocationPermission).isEqualTo(false) + assertThat(myLocationState.hasLocationPermission).isFalse() } } @@ -158,14 +158,14 @@ class SendLocationPresenterTest { val initialState = awaitItem() assertThat(initialState.permissionDialog).isEqualTo(SendLocationState.Dialog.None) assertThat(initialState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(initialState.hasLocationPermission).isEqualTo(false) + assertThat(initialState.hasLocationPermission).isFalse() // Click on the button to switch mode initialState.eventSink(SendLocationEvents.SwitchToMyLocationMode) val myLocationState = awaitItem() assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionRationale) assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(myLocationState.hasLocationPermission).isEqualTo(false) + assertThat(myLocationState.hasLocationPermission).isFalse() } } @@ -189,14 +189,14 @@ class SendLocationPresenterTest { val myLocationState = awaitItem() assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionRationale) assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(myLocationState.hasLocationPermission).isEqualTo(false) + assertThat(myLocationState.hasLocationPermission).isFalse() // Dismiss the dialog myLocationState.eventSink(SendLocationEvents.DismissDialog) val dialogDismissedState = awaitItem() assertThat(dialogDismissedState.permissionDialog).isEqualTo(SendLocationState.Dialog.None) assertThat(dialogDismissedState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false) + assertThat(dialogDismissedState.hasLocationPermission).isFalse() } } @@ -220,7 +220,7 @@ class SendLocationPresenterTest { val myLocationState = awaitItem() assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionRationale) assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(myLocationState.hasLocationPermission).isEqualTo(false) + assertThat(myLocationState.hasLocationPermission).isFalse() // Continue the dialog sends permission request to the permissions presenter myLocationState.eventSink(SendLocationEvents.RequestPermissions) @@ -248,14 +248,14 @@ class SendLocationPresenterTest { val myLocationState = awaitItem() assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionDenied) assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(myLocationState.hasLocationPermission).isEqualTo(false) + assertThat(myLocationState.hasLocationPermission).isFalse() // Dismiss the dialog myLocationState.eventSink(SendLocationEvents.DismissDialog) val dialogDismissedState = awaitItem() assertThat(dialogDismissedState.permissionDialog).isEqualTo(SendLocationState.Dialog.None) assertThat(dialogDismissedState.mode).isEqualTo(SendLocationState.Mode.PinLocation) - assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false) + assertThat(dialogDismissedState.hasLocationPermission).isFalse() } } diff --git a/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/show/ShowLocationPresenterTest.kt b/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/show/ShowLocationPresenterTest.kt index 400a53a49a..cdc71e2099 100644 --- a/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/show/ShowLocationPresenterTest.kt +++ b/features/location/impl/src/test/kotlin/io/element/android/features/location/impl/show/ShowLocationPresenterTest.kt @@ -68,8 +68,8 @@ class ShowLocationPresenterTest { val initialState = awaitItem() assertThat(initialState.location).isEqualTo(location) assertThat(initialState.description).isEqualTo(A_DESCRIPTION) - assertThat(initialState.hasLocationPermission).isEqualTo(false) - assertThat(initialState.isTrackMyLocation).isEqualTo(false) + assertThat(initialState.hasLocationPermission).isFalse() + assertThat(initialState.isTrackMyLocation).isFalse() } } @@ -88,8 +88,8 @@ class ShowLocationPresenterTest { val initialState = awaitItem() assertThat(initialState.location).isEqualTo(location) assertThat(initialState.description).isEqualTo(A_DESCRIPTION) - assertThat(initialState.hasLocationPermission).isEqualTo(false) - assertThat(initialState.isTrackMyLocation).isEqualTo(false) + assertThat(initialState.hasLocationPermission).isFalse() + assertThat(initialState.isTrackMyLocation).isFalse() } } @@ -104,7 +104,7 @@ class ShowLocationPresenterTest { assertThat(initialState.location).isEqualTo(location) assertThat(initialState.description).isEqualTo(A_DESCRIPTION) assertThat(initialState.hasLocationPermission).isEqualTo(true) - assertThat(initialState.isTrackMyLocation).isEqualTo(false) + assertThat(initialState.isTrackMyLocation).isFalse() } } @@ -119,7 +119,7 @@ class ShowLocationPresenterTest { assertThat(initialState.location).isEqualTo(location) assertThat(initialState.description).isEqualTo(A_DESCRIPTION) assertThat(initialState.hasLocationPermission).isEqualTo(true) - assertThat(initialState.isTrackMyLocation).isEqualTo(false) + assertThat(initialState.isTrackMyLocation).isFalse() } } @@ -145,7 +145,7 @@ class ShowLocationPresenterTest { }.test { val initialState = awaitItem() assertThat(initialState.hasLocationPermission).isEqualTo(true) - assertThat(initialState.isTrackMyLocation).isEqualTo(false) + assertThat(initialState.isTrackMyLocation).isFalse() initialState.eventSink(ShowLocationEvents.TrackMyLocation(true)) val trackMyLocationState = awaitItem() @@ -159,7 +159,7 @@ class ShowLocationPresenterTest { initialState.eventSink(ShowLocationEvents.TrackMyLocation(false)) val trackLocationDisabledState = awaitItem() assertThat(trackLocationDisabledState.permissionDialog).isEqualTo(ShowLocationState.Dialog.None) - assertThat(trackLocationDisabledState.isTrackMyLocation).isEqualTo(false) + assertThat(trackLocationDisabledState.isTrackMyLocation).isFalse() assertThat(trackLocationDisabledState.hasLocationPermission).isEqualTo(true) } } @@ -183,15 +183,15 @@ class ShowLocationPresenterTest { initialState.eventSink(ShowLocationEvents.TrackMyLocation(true)) val trackLocationState = awaitItem() assertThat(trackLocationState.permissionDialog).isEqualTo(ShowLocationState.Dialog.PermissionRationale) - assertThat(trackLocationState.isTrackMyLocation).isEqualTo(false) - assertThat(trackLocationState.hasLocationPermission).isEqualTo(false) + assertThat(trackLocationState.isTrackMyLocation).isFalse() + assertThat(trackLocationState.hasLocationPermission).isFalse() // Dismiss the dialog initialState.eventSink(ShowLocationEvents.DismissDialog) val dialogDismissedState = awaitItem() assertThat(dialogDismissedState.permissionDialog).isEqualTo(ShowLocationState.Dialog.None) - assertThat(dialogDismissedState.isTrackMyLocation).isEqualTo(false) - assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false) + assertThat(dialogDismissedState.isTrackMyLocation).isFalse() + assertThat(dialogDismissedState.hasLocationPermission).isFalse() } } @@ -214,8 +214,8 @@ class ShowLocationPresenterTest { initialState.eventSink(ShowLocationEvents.TrackMyLocation(true)) val trackLocationState = awaitItem() assertThat(trackLocationState.permissionDialog).isEqualTo(ShowLocationState.Dialog.PermissionRationale) - assertThat(trackLocationState.isTrackMyLocation).isEqualTo(false) - assertThat(trackLocationState.hasLocationPermission).isEqualTo(false) + assertThat(trackLocationState.isTrackMyLocation).isFalse() + assertThat(trackLocationState.hasLocationPermission).isFalse() // Continue the dialog sends permission request to the permissions presenter trackLocationState.eventSink(ShowLocationEvents.RequestPermissions) @@ -242,15 +242,15 @@ class ShowLocationPresenterTest { initialState.eventSink(ShowLocationEvents.TrackMyLocation(true)) val trackLocationState = awaitItem() assertThat(trackLocationState.permissionDialog).isEqualTo(ShowLocationState.Dialog.PermissionDenied) - assertThat(trackLocationState.isTrackMyLocation).isEqualTo(false) - assertThat(trackLocationState.hasLocationPermission).isEqualTo(false) + assertThat(trackLocationState.isTrackMyLocation).isFalse() + assertThat(trackLocationState.hasLocationPermission).isFalse() // Dismiss the dialog initialState.eventSink(ShowLocationEvents.DismissDialog) val dialogDismissedState = awaitItem() assertThat(dialogDismissedState.permissionDialog).isEqualTo(ShowLocationState.Dialog.None) - assertThat(dialogDismissedState.isTrackMyLocation).isEqualTo(false) - assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false) + assertThat(dialogDismissedState.isTrackMyLocation).isFalse() + assertThat(dialogDismissedState.hasLocationPermission).isFalse() } } diff --git a/features/lockscreen/impl/src/test/kotlin/io/element/android/features/lockscreen/impl/unlock/PinUnlockPresenterTest.kt b/features/lockscreen/impl/src/test/kotlin/io/element/android/features/lockscreen/impl/unlock/PinUnlockPresenterTest.kt index 021f0132a2..0f68e9edd5 100644 --- a/features/lockscreen/impl/src/test/kotlin/io/element/android/features/lockscreen/impl/unlock/PinUnlockPresenterTest.kt +++ b/features/lockscreen/impl/src/test/kotlin/io/element/android/features/lockscreen/impl/unlock/PinUnlockPresenterTest.kt @@ -95,7 +95,7 @@ class PinUnlockPresenterTest { awaitLastSequentialItem().also { state -> assertThat(state.remainingAttempts.dataOrNull()).isEqualTo(0) assertThat(state.showSignOutPrompt).isEqualTo(true) - assertThat(state.isSignOutPromptCancellable).isEqualTo(false) + assertThat(state.isSignOutPromptCancellable).isFalse() } } } @@ -117,7 +117,7 @@ class PinUnlockPresenterTest { state.eventSink(PinUnlockEvents.ClearSignOutPrompt) } awaitLastSequentialItem().also { state -> - assertThat(state.showSignOutPrompt).isEqualTo(false) + assertThat(state.showSignOutPrompt).isFalse() state.eventSink(PinUnlockEvents.OnForgetPin) } awaitLastSequentialItem().also { state -> diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/textcomposer/MessageComposerPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/textcomposer/MessageComposerPresenterTest.kt index ef7891b953..aeb0f60319 100644 --- a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/textcomposer/MessageComposerPresenterTest.kt +++ b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/textcomposer/MessageComposerPresenterTest.kt @@ -379,7 +379,7 @@ class MessageComposerPresenterTest { }.test { skipItems(1) val initialState = awaitItem() - assertThat(initialState.showAttachmentSourcePicker).isEqualTo(false) + assertThat(initialState.showAttachmentSourcePicker).isFalse() initialState.eventSink(MessageComposerEvents.AddAttachment) assertThat(awaitItem().showAttachmentSourcePicker).isEqualTo(true) } diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/DefaultVoiceMessagePlayerTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/DefaultVoiceMessagePlayerTest.kt index 52b0d8d54e..40966d124c 100644 --- a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/DefaultVoiceMessagePlayerTest.kt +++ b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/DefaultVoiceMessagePlayerTest.kt @@ -100,8 +100,8 @@ class DefaultVoiceMessagePlayerTest { matchReadyState(fakeTotalDurationMs = 1000) player.play() awaitItem().let { - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() assertThat(it.isEnded).isEqualTo(true) assertThat(it.currentPosition).isEqualTo(1000) assertThat(it.duration).isEqualTo(1000) @@ -125,8 +125,8 @@ class DefaultVoiceMessagePlayerTest { matchReadyState(1_000L) player1.play() awaitItem().let { // it plays until the end. - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() assertThat(it.isEnded).isEqualTo(true) assertThat(it.currentPosition).isEqualTo(1000) assertThat(it.duration).isEqualTo(1000) @@ -138,24 +138,24 @@ class DefaultVoiceMessagePlayerTest { matchInitialState() assertThat(player2.prepare().isSuccess).isTrue() awaitItem().let { // Additional spurious state due to MediaPlayer owner change. - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() assertThat(it.isEnded).isEqualTo(true) assertThat(it.currentPosition).isEqualTo(1000) assertThat(it.duration).isEqualTo(1000) } awaitItem().let {// Additional spurious state due to MediaPlayer owner change. - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(0) assertThat(it.duration).isEqualTo(null) } matchReadyState(1_000L) player2.play() awaitItem().let { // it plays until the end. - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() assertThat(it.isEnded).isEqualTo(true) assertThat(it.currentPosition).isEqualTo(1000) assertThat(it.duration).isEqualTo(1000) @@ -165,25 +165,25 @@ class DefaultVoiceMessagePlayerTest { // Play player1 again. player1.state.test { awaitItem().let {// Last previous state/ - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() assertThat(it.isEnded).isEqualTo(true) assertThat(it.currentPosition).isEqualTo(1000) assertThat(it.duration).isEqualTo(1000) } assertThat(player1.prepare().isSuccess).isTrue() awaitItem().let {// Additional spurious state due to MediaPlayer owner change. - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(0) assertThat(it.duration).isEqualTo(null) } matchReadyState(1_000L) player1.play() awaitItem().let { // it played again until the end. - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() assertThat(it.isEnded).isEqualTo(true) assertThat(it.currentPosition).isEqualTo(1000) assertThat(it.duration).isEqualTo(1000) @@ -202,7 +202,7 @@ class DefaultVoiceMessagePlayerTest { skipItems(1) // skip play state player.pause() awaitItem().let { - assertThat(it.isPlaying).isEqualTo(false) + assertThat(it.isPlaying).isFalse() assertThat(it.currentPosition).isEqualTo(1000) } } @@ -234,17 +234,17 @@ class DefaultVoiceMessagePlayerTest { matchInitialState() player.seekTo(2000) awaitItem().let { - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(2000) assertThat(it.duration).isEqualTo(null) } assertThat(player.prepare().isSuccess).isTrue() awaitItem().let { assertThat(it.isReady).isEqualTo(true) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(2000) assertThat(it.duration).isEqualTo(FAKE_TOTAL_DURATION_MS) } @@ -261,8 +261,8 @@ class DefaultVoiceMessagePlayerTest { player.seekTo(2000) awaitItem().let { assertThat(it.isReady).isEqualTo(true) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(2000) assertThat(it.duration).isEqualTo(FAKE_TOTAL_DURATION_MS) } @@ -296,9 +296,9 @@ private const val MXC_URI = "mxc://matrix.org/1234567890abcdefg" private suspend fun TurbineTestContext.matchInitialState() { awaitItem().let { - assertThat(it.isReady).isEqualTo(false) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isReady).isFalse() + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(0) assertThat(it.duration).isEqualTo(null) } @@ -309,8 +309,8 @@ private suspend fun TurbineTestContext.matchReadyState ) { awaitItem().let { assertThat(it.isReady).isEqualTo(true) - assertThat(it.isPlaying).isEqualTo(false) - assertThat(it.isEnded).isEqualTo(false) + assertThat(it.isPlaying).isFalse() + assertThat(it.isEnded).isFalse() assertThat(it.currentPosition).isEqualTo(0) assertThat(it.duration).isEqualTo(fakeTotalDurationMs) } diff --git a/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/root/PreferencesRootPresenterTest.kt b/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/root/PreferencesRootPresenterTest.kt index 4adea8e59c..5a464bb4b1 100644 --- a/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/root/PreferencesRootPresenterTest.kt +++ b/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/root/PreferencesRootPresenterTest.kt @@ -74,7 +74,7 @@ class PreferencesRootPresenterTest { ) ) assertThat(loadedState.showDeveloperSettings).isEqualTo(true) - assertThat(loadedState.showAnalyticsSettings).isEqualTo(false) + assertThat(loadedState.showAnalyticsSettings).isFalse() assertThat(loadedState.accountManagementUrl).isNull() assertThat(loadedState.devicesManagementUrl).isNull() } diff --git a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/edit/RoomDetailsEditPresenterTest.kt b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/edit/RoomDetailsEditPresenterTest.kt index eb89c40a24..e1070e4975 100644 --- a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/edit/RoomDetailsEditPresenterTest.kt +++ b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/edit/RoomDetailsEditPresenterTest.kt @@ -107,7 +107,7 @@ class RoomDetailsEditPresenterTest { AvatarAction.TakePhoto, AvatarAction.Remove ) - assertThat(initialState.saveButtonEnabled).isEqualTo(false) + assertThat(initialState.saveButtonEnabled).isFalse() assertThat(initialState.saveAction).isInstanceOf(Async.Uninitialized::class.java) } } @@ -299,7 +299,7 @@ class RoomDetailsEditPresenterTest { presenter.present() }.test { val initialState = awaitItem() - assertThat(initialState.saveButtonEnabled).isEqualTo(false) + assertThat(initialState.saveButtonEnabled).isFalse() // Once a change is made, the save button is enabled initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name II")) @@ -310,7 +310,7 @@ class RoomDetailsEditPresenterTest { // If it's reverted then the save disables again initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name")) awaitItem().apply { - assertThat(saveButtonEnabled).isEqualTo(false) + assertThat(saveButtonEnabled).isFalse() } // Make a change... @@ -322,7 +322,7 @@ class RoomDetailsEditPresenterTest { // Revert it... initialState.eventSink(RoomDetailsEditEvents.UpdateRoomTopic("My topic")) awaitItem().apply { - assertThat(saveButtonEnabled).isEqualTo(false) + assertThat(saveButtonEnabled).isFalse() } // Make a change... @@ -334,7 +334,7 @@ class RoomDetailsEditPresenterTest { // Revert it... initialState.eventSink(RoomDetailsEditEvents.HandleAvatarAction(AvatarAction.ChoosePhoto)) awaitItem().apply { - assertThat(saveButtonEnabled).isEqualTo(false) + assertThat(saveButtonEnabled).isFalse() } } } @@ -351,7 +351,7 @@ class RoomDetailsEditPresenterTest { presenter.present() }.test { val initialState = awaitItem() - assertThat(initialState.saveButtonEnabled).isEqualTo(false) + assertThat(initialState.saveButtonEnabled).isFalse() // Once a change is made, the save button is enabled initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name II")) @@ -362,7 +362,7 @@ class RoomDetailsEditPresenterTest { // If it's reverted then the save disables again initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("fallback")) awaitItem().apply { - assertThat(saveButtonEnabled).isEqualTo(false) + assertThat(saveButtonEnabled).isFalse() } // Make a change... @@ -374,7 +374,7 @@ class RoomDetailsEditPresenterTest { // Revert it... initialState.eventSink(RoomDetailsEditEvents.UpdateRoomTopic("")) awaitItem().apply { - assertThat(saveButtonEnabled).isEqualTo(false) + assertThat(saveButtonEnabled).isFalse() } // Make a change... @@ -386,7 +386,7 @@ class RoomDetailsEditPresenterTest { // Revert it... initialState.eventSink(RoomDetailsEditEvents.HandleAvatarAction(AvatarAction.Remove)) awaitItem().apply { - assertThat(saveButtonEnabled).isEqualTo(false) + assertThat(saveButtonEnabled).isFalse() } } } diff --git a/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt b/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt index 117005fd6f..64d416f819 100644 --- a/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt +++ b/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt @@ -37,7 +37,7 @@ class DefaultFeatureFlagServiceTest { fun `given service without provider when set enabled feature is called then it returns false`() = runTest { val featureFlagService = DefaultFeatureFlagService(emptySet()) val result = featureFlagService.setFeatureEnabled(FeatureFlags.LocationSharing, true) - assertThat(result).isEqualTo(false) + assertThat(result).isFalse() } @Test @@ -56,7 +56,7 @@ class DefaultFeatureFlagServiceTest { featureFlagService.isFeatureEnabledFlow(FeatureFlags.LocationSharing).test { assertThat(awaitItem()).isEqualTo(true) featureFlagService.setFeatureEnabled(FeatureFlags.LocationSharing, false) - assertThat(awaitItem()).isEqualTo(false) + assertThat(awaitItem()).isFalse() } } diff --git a/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt b/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt index c9e292fcff..54f07d9799 100644 --- a/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt +++ b/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt @@ -62,4 +62,16 @@ class KonsistTestTest { functionDeclaration.text.contains("Truth.") } } + + @Test + fun `use isFalse() instead of isEqualTo(false)`() { + Konsist + .scopeFromTest() + .functions() + // Exclude self + .withoutName("use isFalse() instead of isEqualTo(false)") + .assertFalse { functionDeclaration -> + functionDeclaration.text.contains("isEqualTo(false)") + } + } }