diff --git a/app/src/main/kotlin/io/element/android/x/component/ShowkaseButton.kt b/app/src/main/kotlin/io/element/android/x/component/ShowkaseButton.kt index c486f9b7cc..42b9703c2b 100644 --- a/app/src/main/kotlin/io/element/android/x/component/ShowkaseButton.kt +++ b/app/src/main/kotlin/io/element/android/x/component/ShowkaseButton.kt @@ -22,7 +22,10 @@ import androidx.compose.material.icons.Icons import androidx.compose.material.icons.filled.Close import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier +import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.dp +import io.element.android.libraries.designsystem.preview.ElementPreviewDark +import io.element.android.libraries.designsystem.preview.ElementPreviewLight import io.element.android.libraries.designsystem.theme.components.Button import io.element.android.libraries.designsystem.theme.components.Icon import io.element.android.libraries.designsystem.theme.components.IconButton @@ -31,14 +34,14 @@ import io.element.android.libraries.designsystem.theme.components.Text @Composable internal fun ShowkaseButton( isVisible: Boolean, - onClick: () -> Unit, - onCloseClicked: () -> Unit, modifier: Modifier = Modifier, + onClick: () -> Unit = {}, + onCloseClicked: () -> Unit = {}, ) { if (isVisible) { Button( modifier = modifier - .padding(top = 32.dp, start = 16.dp), + .padding(top = 32.dp), onClick = onClick ) { Text(text = "Showkase Browser") @@ -53,3 +56,16 @@ internal fun ShowkaseButton( } } } + +@Preview +@Composable +internal fun ShowkaseButtonLightPreview() = ElementPreviewLight { ContentToPreview() } + +@Preview +@Composable +internal fun ShowkaseButtonDarkPreview() = ElementPreviewDark { ContentToPreview() } + +@Composable +private fun ContentToPreview() { + ShowkaseButton(isVisible = true) +} diff --git a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsDark.kt b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsDark.kt index 774158856e..2a17b74521 100644 --- a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsDark.kt +++ b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsDark.kt @@ -36,7 +36,7 @@ fun elementColorsDark() = ElementColors( // TODO Lots of colors are missing val materialColorSchemeDark = darkColorScheme( primary = Color.White, - // TODO onPrimary = ColorDarkTokens.OnPrimary, + onPrimary = Color.Black, // TODO primaryContainer = ColorDarkTokens.PrimaryContainer, // TODO onPrimaryContainer = ColorDarkTokens.OnPrimaryContainer, // TODO inversePrimary = ColorDarkTokens.InversePrimary, diff --git a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsLight.kt b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsLight.kt index dc13718360..2e69b5a7ff 100644 --- a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsLight.kt +++ b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorsLight.kt @@ -36,7 +36,7 @@ fun elementColorsLight() = ElementColors( // TODO Lots of colors are missing val materialColorSchemeLight = lightColorScheme( primary = Color.Black, - // TODO onPrimary = ColorLightTokens.OnPrimary, + onPrimary = Color.White, // TODO primaryContainer = ColorLightTokens.PrimaryContainer, // TODO onPrimaryContainer = ColorLightTokens.OnPrimaryContainer, // TODO inversePrimary = ColorLightTokens.InversePrimary, diff --git a/tests/uitests/src/main/kotlin/io/element/android/tests/uitests/ShowkaseButton.kt b/tests/uitests/src/main/kotlin/io/element/android/tests/uitests/ShowkaseButton.kt deleted file mode 100644 index 3510d99d9f..0000000000 --- a/tests/uitests/src/main/kotlin/io/element/android/tests/uitests/ShowkaseButton.kt +++ /dev/null @@ -1,75 +0,0 @@ -/* - * Copyright (c) 2023 New Vector Ltd - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package io.element.android.tests.uitests - -import androidx.compose.foundation.layout.padding -import androidx.compose.foundation.layout.size -import androidx.compose.material.icons.Icons -import androidx.compose.material.icons.filled.Close -import androidx.compose.runtime.Composable -import androidx.compose.runtime.getValue -import androidx.compose.runtime.mutableStateOf -import androidx.compose.runtime.remember -import androidx.compose.runtime.setValue -import androidx.compose.ui.Modifier -import androidx.compose.ui.tooling.preview.Preview -import androidx.compose.ui.unit.dp -import io.element.android.libraries.designsystem.preview.ElementPreviewDark -import io.element.android.libraries.designsystem.preview.ElementPreviewLight -import io.element.android.libraries.designsystem.theme.components.Button -import io.element.android.libraries.designsystem.theme.components.Icon -import io.element.android.libraries.designsystem.theme.components.IconButton -import io.element.android.libraries.designsystem.theme.components.Text - -@Composable -fun ShowkaseButton( - modifier: Modifier = Modifier, - onClick: () -> Unit = {}, -) { - var isShowkaseButtonVisible by remember { mutableStateOf(BuildConfig.DEBUG) } - - if (isShowkaseButtonVisible) { - Button( - modifier = modifier - .padding(top = 32.dp), - onClick = onClick - ) { - Text(text = "Showkase Browser") - IconButton( - modifier = Modifier - .padding(start = 8.dp) - .size(16.dp), - onClick = { isShowkaseButtonVisible = false }, - ) { - Icon(imageVector = Icons.Filled.Close, contentDescription = "") - } - } - } -} - -@Preview -@Composable -internal fun ShowkaseButtonLightPreview() = ElementPreviewLight { ContentToPreview() } - -@Preview -@Composable -internal fun ShowkaseButtonDarkPreview() = ElementPreviewDark { ContentToPreview() } - -@Composable -private fun ContentToPreview() { - ShowkaseButton() -}