Browse Source

Enforce lambda parameters to be passed in.

feature/fga/small_timeline_improvements
Benoit Marty 1 year ago
parent
commit
9562600be4
  1. 6
      features/login/impl/src/main/kotlin/io/element/android/features/login/impl/changeserver/ChangeServerView.kt
  2. 13
      features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/changeaccountprovider/ChangeAccountProviderView.kt
  3. 12
      features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderView.kt
  4. 9
      features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/searchaccountprovider/SearchAccountProviderView.kt

6
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/changeserver/ChangeServerView.kt

@ -31,9 +31,9 @@ import io.element.android.libraries.designsystem.preview.ElementPreviewLight @@ -31,9 +31,9 @@ import io.element.android.libraries.designsystem.preview.ElementPreviewLight
@Composable
fun ChangeServerView(
state: ChangeServerState,
onLearnMoreClicked: () -> Unit,
onDone: () -> Unit,
modifier: Modifier = Modifier,
onLearnMoreClicked: () -> Unit = {},
onDone: () -> Unit = {},
) {
val eventSink = state.eventSink
when (state.changeServerAction) {
@ -80,5 +80,7 @@ fun ChangeServerViewDarkPreview(@PreviewParameter(ChangeServerStateProvider::cla @@ -80,5 +80,7 @@ fun ChangeServerViewDarkPreview(@PreviewParameter(ChangeServerStateProvider::cla
private fun ContentToPreview(state: ChangeServerState) {
ChangeServerView(
state = state,
onLearnMoreClicked = {},
onDone = {},
)
}

13
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/changeaccountprovider/ChangeAccountProviderView.kt

@ -57,11 +57,11 @@ import io.element.android.libraries.designsystem.theme.components.TopAppBar @@ -57,11 +57,11 @@ import io.element.android.libraries.designsystem.theme.components.TopAppBar
@Composable
fun ChangeAccountProviderView(
state: ChangeAccountProviderState,
onBackPressed: () -> Unit,
onLearnMoreClicked: () -> Unit,
onDone: () -> Unit,
onOtherProviderClicked: () -> Unit,
modifier: Modifier = Modifier,
onBackPressed: () -> Unit = {},
onLearnMoreClicked: () -> Unit = {},
onDone: () -> Unit = {},
onOtherProviderClicked: () -> Unit = {},
) {
val scrollState = rememberScrollState()
@ -143,6 +143,9 @@ fun ChangeAccountProviderViewDarkPreview(@PreviewParameter(ChangeAccountProvider @@ -143,6 +143,9 @@ fun ChangeAccountProviderViewDarkPreview(@PreviewParameter(ChangeAccountProvider
private fun ContentToPreview(state: ChangeAccountProviderState) {
ChangeAccountProviderView(
state = state,
onBackPressed = { }
onBackPressed = { },
onLearnMoreClicked = { },
onDone = { },
onOtherProviderClicked = { },
)
}

12
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderView.kt

@ -49,11 +49,11 @@ import io.element.android.libraries.testtags.testTag @@ -49,11 +49,11 @@ import io.element.android.libraries.testtags.testTag
@Composable
fun ConfirmAccountProviderView(
state: ConfirmAccountProviderState,
onOidcDetails: (OidcDetails) -> Unit,
onLoginPasswordNeeded: () -> Unit,
onLearnMoreClicked: () -> Unit,
onChange: () -> Unit,
modifier: Modifier = Modifier,
onOidcDetails: (OidcDetails) -> Unit = {},
onLoginPasswordNeeded: () -> Unit = {},
onLearnMoreClicked: () -> Unit = {},
onChange: () -> Unit = {},
) {
val isLoading by remember(state.loginFlow) {
derivedStateOf {
@ -158,5 +158,9 @@ fun ConfirmAccountProviderViewDarkPreview(@PreviewParameter(ConfirmAccountProvid @@ -158,5 +158,9 @@ fun ConfirmAccountProviderViewDarkPreview(@PreviewParameter(ConfirmAccountProvid
private fun ContentToPreview(state: ConfirmAccountProviderState) {
ConfirmAccountProviderView(
state = state,
onOidcDetails = {},
onLoginPasswordNeeded = {},
onLearnMoreClicked = {},
onChange = {},
)
}

9
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/searchaccountprovider/SearchAccountProviderView.kt

@ -75,10 +75,10 @@ import io.element.android.libraries.testtags.testTag @@ -75,10 +75,10 @@ import io.element.android.libraries.testtags.testTag
@Composable
fun SearchAccountProviderView(
state: SearchAccountProviderState,
onBackPressed: () -> Unit,
onLearnMoreClicked: () -> Unit,
onDone: () -> Unit,
modifier: Modifier = Modifier,
onBackPressed: () -> Unit = {},
onLearnMoreClicked: () -> Unit = {},
onDone: () -> Unit = {},
) {
val eventSink = state.eventSink
val scrollState = rememberScrollState()
@ -215,5 +215,8 @@ fun SearchAccountProviderViewDarkPreview(@PreviewParameter(SearchAccountProvider @@ -215,5 +215,8 @@ fun SearchAccountProviderViewDarkPreview(@PreviewParameter(SearchAccountProvider
private fun ContentToPreview(state: SearchAccountProviderState) {
SearchAccountProviderView(
state = state,
onBackPressed = {},
onLearnMoreClicked = {},
onDone = {},
)
}

Loading…
Cancel
Save