From 93a77d94c126d3301608393727492244a5001d5b Mon Sep 17 00:00:00 2001 From: Jorge Martin Espinosa Date: Mon, 20 Mar 2023 15:09:50 +0100 Subject: [PATCH] Try to improve Danger rule for PNGs to ignore screenshots (#234) --- tools/danger/dangerfile.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/danger/dangerfile.js b/tools/danger/dangerfile.js index 2ed4067ee2..4e80fdb3c0 100644 --- a/tools/danger/dangerfile.js +++ b/tools/danger/dangerfile.js @@ -107,7 +107,9 @@ if (hasChangedViews) { } // Check for pngs on resources -const hasPngs = editedFiles.filter(file => file.toLowerCase().endsWith(".png")).length > 0 +const hasPngs = editedFiles.filter(file => { + file.toLowerCase().endsWith(".png") && !file.includes("snapshots/images/") // Exclude screenshots +}).length > 0 if (hasPngs) { warn("You seem to have made changes to some images. Please consider using an vector drawable.") }