Browse Source

Update check rule.

feature/julioromano/geocoding_api
Benoit Marty 1 year ago
parent
commit
931edb27ae
  1. 4
      tools/check/forbidden_strings_in_code.txt

4
tools/check/forbidden_strings_in_code.txt

@ -130,5 +130,5 @@ System\.currentTimeMillis\(\)===1 @@ -130,5 +130,5 @@ System\.currentTimeMillis\(\)===1
### Suspicious String template. Please check that the string template will behave as expected, i.e. the class field and not the whole object will be used. For instance `Timber.d("$event.type")` is not correct, you should write `Timber.d("${event.type}")`. In the former the whole event content will be logged, since it's a data class. If this is expected (i.e. to fix false positive), please add explicit curly braces (`{` and `}`) around the variable, for instance `"elementLogs.${i}.txt"`
\$[a-zA-Z_]\w*\??\.[a-zA-Z_]
### Use `import io.element.android.libraries.ui.strings.R as StringsR` then `StringR.string.<stringKey>` instead
io\.element\.android\.libraries\.ui\.strings\.R\.
### Use `import io.element.android.libraries.ui.strings.CommonStrings` then `CommonStrings.<stringKey>` instead
import io\.element\.android\.libraries\.ui\.strings\.R

Loading…
Cancel
Save