Code quality and remove reference to `DefaultMatrixToConverter.SUPPORTED_PATHS` in `MatrixToConverter`

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNode.kt

@@ -110,10 +110,10 @@ class MessagesNode @AssistedInject constructor(
     ) {
         when (val permalink = permalinkParser.parse(Uri.parse(url))) {
             is PermalinkData.UserLink -> {
-                onUserDataClicked(UserId(permalink.userId))
+                callback?.onUserDataClicked(UserId(permalink.userId))
             }
             is PermalinkData.RoomLink -> {
-                // TODO: Implement room link handling
+                // TODO Implement room link handling
             }
             is PermalinkData.FallbackLink,
             is PermalinkData.RoomEmailInviteLink -> {

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/permalink/MatrixToConverter.kt

@@ -24,7 +24,6 @@ import android.net.Uri
 interface MatrixToConverter {
     /**
      * Try to convert a URL from an element web instance or from a client permalink to a matrix.to url.
-     * To be successfully converted, URL path should contain one of the [DefaultMatrixToConverter.SUPPORTED_PATHS].
      * Examples:
      * - https://riot.im/develop/#/room/#element-android:matrix.org  ->  https://matrix.to/#/#element-android:matrix.org
      * - https://app.element.io/#/room/#element-android:matrix.org   ->  https://matrix.to/#/#element-android:matrix.org

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/permalink/DefaultMatrixToConverter.kt

@@ -53,9 +53,11 @@ class DefaultMatrixToConverter @Inject constructor() : MatrixToConverter {
         }
     }
 
-    private val SUPPORTED_PATHS = listOf(
+    companion object {
-        "/#/room/",
+        val SUPPORTED_PATHS = listOf(
-        "/#/user/",
+            "/#/room/",
-        "/#/group/"
+            "/#/user/",
-    )
+            "/#/group/"
+        )
+    }
 }

libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/permalink/FakePermalinkParser.kt

@@ -21,7 +21,7 @@ import io.element.android.libraries.matrix.api.permalink.PermalinkData
 import io.element.android.libraries.matrix.api.permalink.PermalinkParser
 
 class FakePermalinkParser(
-    private var result: () -> PermalinkData = { throw Exception("Not implemented") }
+    private var result: () -> PermalinkData = { TODO("Not implemented") }
 ) : PermalinkParser {
     fun givenResult(result: PermalinkData) {
         this.result = { result }