From 5a1896ae3d154f23893711dd6b9bf8a4edb70c5a Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 28 May 2024 17:36:24 +0200 Subject: [PATCH] Remove dead code `AnalyticsService.onSignOut`. DefaultAnalyticsService is observing the Session. --- .../android/services/analytics/api/AnalyticsService.kt | 5 ----- .../services/analytics/impl/DefaultAnalyticsService.kt | 5 ----- .../android/services/analytics/noop/NoopAnalyticsService.kt | 1 - 3 files changed, 11 deletions(-) diff --git a/services/analytics/api/src/main/kotlin/io/element/android/services/analytics/api/AnalyticsService.kt b/services/analytics/api/src/main/kotlin/io/element/android/services/analytics/api/AnalyticsService.kt index 8d904e2743..b09d8bd3be 100644 --- a/services/analytics/api/src/main/kotlin/io/element/android/services/analytics/api/AnalyticsService.kt +++ b/services/analytics/api/src/main/kotlin/io/element/android/services/analytics/api/AnalyticsService.kt @@ -57,11 +57,6 @@ interface AnalyticsService : AnalyticsTracker, ErrorTracker { */ suspend fun setAnalyticsId(analyticsId: String) - /** - * To be called when a session is destroyed. - */ - suspend fun onSignOut() - /** * Reset the analytics service (will ask for user consent again). */ diff --git a/services/analytics/impl/src/main/kotlin/io/element/android/services/analytics/impl/DefaultAnalyticsService.kt b/services/analytics/impl/src/main/kotlin/io/element/android/services/analytics/impl/DefaultAnalyticsService.kt index 42acd29b56..e828d4c7ee 100644 --- a/services/analytics/impl/src/main/kotlin/io/element/android/services/analytics/impl/DefaultAnalyticsService.kt +++ b/services/analytics/impl/src/main/kotlin/io/element/android/services/analytics/impl/DefaultAnalyticsService.kt @@ -91,11 +91,6 @@ class DefaultAnalyticsService @Inject constructor( analyticsStore.setAnalyticsId(analyticsId) } - override suspend fun onSignOut() { - // stop all providers - analyticsProviders.onEach { it.stop() } - } - override suspend fun onSessionCreated(userId: String) { // Nothing to do } diff --git a/services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt b/services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt index ed18d2bd9a..54246b0269 100644 --- a/services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt +++ b/services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt @@ -38,7 +38,6 @@ class NoopAnalyticsService @Inject constructor() : AnalyticsService { override suspend fun setDidAskUserConsent() = Unit override fun getAnalyticsId(): Flow = flowOf("") override suspend fun setAnalyticsId(analyticsId: String) = Unit - override suspend fun onSignOut() = Unit override suspend fun reset() = Unit override fun capture(event: VectorAnalyticsEvent) = Unit override fun screen(screen: VectorAnalyticsScreen) = Unit