Browse Source

Use IO dispatcher for cleanup in bug reporter (#3092)

pull/3096/head
Jorge Martin Espinosa 3 months ago committed by GitHub
parent
commit
40b7736fcf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 1
      changelog.d/3086.bugfix
  2. 10
      features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt

1
changelog.d/3086.bugfix

@ -0,0 +1 @@ @@ -0,0 +1 @@
Make sure we don't use the main dispatcher while closing the bug report request, as it can lead to crashes in strict mode.

10
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt

@ -282,11 +282,13 @@ class DefaultBugReporter @Inject constructor( @@ -282,11 +282,13 @@ class DefaultBugReporter @Inject constructor(
listener.onUploadFailed(serverError)
}
} finally {
// delete the generated files when the bug report process has finished
for (file in bugReportFiles) {
file.safeDelete()
withContext(coroutineDispatchers.io) {
// delete the generated files when the bug report process has finished
for (file in bugReportFiles) {
file.safeDelete()
}
response?.close()
}
response?.close()
}
}

Loading…
Cancel
Save