Update advanced settings screen. Replace Read Receipt private mode by Share presence.

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsEvents.kt

@@ -21,7 +21,7 @@ import io.element.android.compound.theme.Theme
 sealed interface AdvancedSettingsEvents {
     data class SetRichTextEditorEnabled(val enabled: Boolean) : AdvancedSettingsEvents
     data class SetDeveloperModeEnabled(val enabled: Boolean) : AdvancedSettingsEvents
-    data class SetSendPublicReadReceiptsEnabled(val enabled: Boolean) : AdvancedSettingsEvents
+    data class SetSharePresenceEnabled(val enabled: Boolean) : AdvancedSettingsEvents
     data object ChangeTheme : AdvancedSettingsEvents
     data object CancelChangeTheme : AdvancedSettingsEvents
     data class SetTheme(val theme: Theme) : AdvancedSettingsEvents

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsPresenter.kt

@@ -44,8 +44,8 @@ class AdvancedSettingsPresenter @Inject constructor(
         val isDeveloperModeEnabled by appPreferencesStore
             .isDeveloperModeEnabledFlow()
             .collectAsState(initial = false)
-        val isSendPublicReadReceiptsEnabled by sessionPreferencesStore
-            .isSendPublicReadReceiptsEnabled()
+        val isSharePresenceEnabled by sessionPreferencesStore
+            .isSharePresenceEnabled()
             .collectAsState(initial = true)
         val theme by remember {
             appPreferencesStore.getThemeFlow().mapToTheme()
@@ -60,8 +60,8 @@ class AdvancedSettingsPresenter @Inject constructor(
                 is AdvancedSettingsEvents.SetDeveloperModeEnabled -> localCoroutineScope.launch {
                     appPreferencesStore.setDeveloperModeEnabled(event.enabled)
                 }
-                is AdvancedSettingsEvents.SetSendPublicReadReceiptsEnabled -> localCoroutineScope.launch {
-                    sessionPreferencesStore.setSendPublicReadReceipts(event.enabled)
+                is AdvancedSettingsEvents.SetSharePresenceEnabled -> localCoroutineScope.launch {
+                    sessionPreferencesStore.setSharePresence(event.enabled)
                 }
                 AdvancedSettingsEvents.CancelChangeTheme -> showChangeThemeDialog = false
                 AdvancedSettingsEvents.ChangeTheme -> showChangeThemeDialog = true
@@ -75,7 +75,7 @@ class AdvancedSettingsPresenter @Inject constructor(
         return AdvancedSettingsState(
             isRichTextEditorEnabled = isRichTextEditorEnabled,
             isDeveloperModeEnabled = isDeveloperModeEnabled,
-            isSendPublicReadReceiptsEnabled = isSendPublicReadReceiptsEnabled,
+            isSharePresenceEnabled = isSharePresenceEnabled,
             theme = theme,
             showChangeThemeDialog = showChangeThemeDialog,
             eventSink = { handleEvents(it) }

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsState.kt

@@ -21,7 +21,7 @@ import io.element.android.compound.theme.Theme
 data class AdvancedSettingsState(
     val isRichTextEditorEnabled: Boolean,
     val isDeveloperModeEnabled: Boolean,
-    val isSendPublicReadReceiptsEnabled: Boolean,
+    val isSharePresenceEnabled: Boolean,
     val theme: Theme,
     val showChangeThemeDialog: Boolean,
     val eventSink: (AdvancedSettingsEvents) -> Unit

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsStateProvider.kt

@@ -38,7 +38,7 @@ fun aAdvancedSettingsState(
 ) = AdvancedSettingsState(
     isRichTextEditorEnabled = isRichTextEditorEnabled,
     isDeveloperModeEnabled = isDeveloperModeEnabled,
-    isSendPublicReadReceiptsEnabled = isSendPublicReadReceiptsEnabled,
+    isSharePresenceEnabled = isSendPublicReadReceiptsEnabled,
     theme = Theme.System,
     showChangeThemeDialog = showChangeThemeDialog,
     eventSink = {}

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt

@@ -83,15 +83,15 @@ fun AdvancedSettingsView(
         )
         ListItem(
             headlineContent = {
-                Text(text = stringResource(id = R.string.screen_advanced_settings_send_read_receipts))
+                Text(text = stringResource(id = R.string.screen_advanced_settings_share_presence))
             },
             supportingContent = {
-                Text(text = stringResource(id = R.string.screen_advanced_settings_send_read_receipts_description))
+                Text(text = stringResource(id = R.string.screen_advanced_settings_share_presence_description))
             },
             trailingContent = ListItemContent.Switch(
-                checked = state.isSendPublicReadReceiptsEnabled,
+                checked = state.isSharePresenceEnabled,
             ),
-            onClick = { state.eventSink(AdvancedSettingsEvents.SetSendPublicReadReceiptsEnabled(!state.isSendPublicReadReceiptsEnabled)) }
+            onClick = { state.eventSink(AdvancedSettingsEvents.SetSharePresenceEnabled(!state.isSharePresenceEnabled)) }
         )
     }
 

features/preferences/impl/src/main/res/values/localazy.xml

@@ -8,6 +8,8 @@
   <string name="screen_advanced_settings_rich_text_editor_description">"Disable the rich text editor to type Markdown manually."</string>
   <string name="screen_advanced_settings_send_read_receipts">"Read receipts"</string>
   <string name="screen_advanced_settings_send_read_receipts_description">"If turned off, your read receipts won\'t be sent to anyone. You will still receive read receipts from other users."</string>
+  <string name="screen_advanced_settings_share_presence">"Share presence"</string>
+  <string name="screen_advanced_settings_share_presence_description">"If turned off, you won’t be able to send or receive read receipts or typing notifications"</string>
   <string name="screen_advanced_settings_view_source_description">"Enable option to view message source in the timeline."</string>
   <string name="screen_edit_profile_display_name">"Display name"</string>
   <string name="screen_edit_profile_display_name_placeholder">"Your display name"</string>

features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsPresenterTest.kt

@@ -43,7 +43,7 @@ class AdvancedSettingsPresenterTest {
             assertThat(initialState.isDeveloperModeEnabled).isFalse()
             assertThat(initialState.isRichTextEditorEnabled).isFalse()
             assertThat(initialState.showChangeThemeDialog).isFalse()
-            assertThat(initialState.isSendPublicReadReceiptsEnabled).isTrue()
+            assertThat(initialState.isSharePresenceEnabled).isTrue()
             assertThat(initialState.theme).isEqualTo(Theme.System)
         }
     }
@@ -79,17 +79,17 @@ class AdvancedSettingsPresenterTest {
     }
 
     @Test
-    fun `present - send public read receipts off on`() = runTest {
+    fun `present - share presence off on`() = runTest {
         val presenter = createAdvancedSettingsPresenter()
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
         }.test {
             val initialState = awaitLastSequentialItem()
-            assertThat(initialState.isSendPublicReadReceiptsEnabled).isTrue()
-            initialState.eventSink.invoke(AdvancedSettingsEvents.SetSendPublicReadReceiptsEnabled(false))
-            assertThat(awaitItem().isSendPublicReadReceiptsEnabled).isFalse()
-            initialState.eventSink.invoke(AdvancedSettingsEvents.SetSendPublicReadReceiptsEnabled(true))
-            assertThat(awaitItem().isSendPublicReadReceiptsEnabled).isTrue()
+            assertThat(initialState.isSharePresenceEnabled).isTrue()
+            initialState.eventSink.invoke(AdvancedSettingsEvents.SetSharePresenceEnabled(false))
+            assertThat(awaitItem().isSharePresenceEnabled).isFalse()
+            initialState.eventSink.invoke(AdvancedSettingsEvents.SetSharePresenceEnabled(true))
+            assertThat(awaitItem().isSharePresenceEnabled).isTrue()
         }
     }