Browse Source

Improve confusing text in the 'ready to start verification' screen (#1751)

* Improve confusing text in the 'ready to start verification' screen

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
pull/1756/head
Jorge Martin Espinosa 11 months ago committed by GitHub
parent
commit
1fe45cde18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      changelog.d/879.bugfix
  2. 3
      features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionView.kt
  3. 1
      features/verifysession/impl/src/main/res/values/localazy.xml
  4. 2
      libraries/ui-strings/src/main/res/values/localazy.xml
  5. BIN
      tests/uitests/src/test/snapshots/images/ui_S_t[f.verifysession.impl_VerifySelfSessionView_null_VerifySelfSessionView-Day-0_0_null_5,NEXUS_5,1.0,en].png
  6. BIN
      tests/uitests/src/test/snapshots/images/ui_S_t[f.verifysession.impl_VerifySelfSessionView_null_VerifySelfSessionView-Night-0_1_null_5,NEXUS_5,1.0,en].png

1
changelog.d/879.bugfix

@ -0,0 +1 @@ @@ -0,0 +1 @@
Improve confusing text in the 'ready to start verification' screen.

3
features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionView.kt

@ -106,7 +106,8 @@ private fun HeaderContent(verificationFlowStep: FlowStep, modifier: Modifier = M @@ -106,7 +106,8 @@ private fun HeaderContent(verificationFlowStep: FlowStep, modifier: Modifier = M
FlowStep.Initial -> R.string.screen_session_verification_open_existing_session_subtitle
FlowStep.Canceled -> R.string.screen_session_verification_cancelled_subtitle
FlowStep.AwaitingOtherDeviceResponse -> R.string.screen_session_verification_waiting_to_accept_subtitle
FlowStep.Ready, is FlowStep.Verifying, FlowStep.Completed -> R.string.screen_session_verification_compare_emojis_subtitle
is FlowStep.Verifying, FlowStep.Completed -> R.string.screen_session_verification_compare_emojis_subtitle
FlowStep.Ready -> R.string.screen_session_verification_ready_subtitle
}
IconTitleSubtitleMolecule(

1
features/verifysession/impl/src/main/res/values/localazy.xml

@ -9,6 +9,7 @@ @@ -9,6 +9,7 @@
<string name="screen_session_verification_positive_button_canceled">"Retry verification"</string>
<string name="screen_session_verification_positive_button_initial">"I am ready"</string>
<string name="screen_session_verification_positive_button_verifying_ongoing">"Waiting to match"</string>
<string name="screen_session_verification_ready_subtitle">"Compare a unique set of emojis."</string>
<string name="screen_session_verification_request_accepted_subtitle">"Compare the unique emoji, ensuring they appear in the same order."</string>
<string name="screen_session_verification_they_dont_match">"They don’t match"</string>
<string name="screen_session_verification_they_match">"They match"</string>

2
libraries/ui-strings/src/main/res/values/localazy.xml

@ -171,7 +171,7 @@ @@ -171,7 +171,7 @@
<string name="common_video">"Video"</string>
<string name="common_voice_message">"Voice message"</string>
<string name="common_waiting">"Waiting…"</string>
<string name="common_waiting_for_decryption_key">"Waiting for decryption key"</string>
<string name="common_waiting_for_decryption_key">"Waiting for this message"</string>
<string name="common_poll_end_confirmation">"Are you sure you want to end this poll?"</string>
<string name="common_poll_summary">"Poll: %1$s"</string>
<string name="dialog_title_confirmation">"Confirmation"</string>

BIN
tests/uitests/src/test/snapshots/images/ui_S_t[f.verifysession.impl_VerifySelfSessionView_null_VerifySelfSessionView-Day-0_0_null_5,NEXUS_5,1.0,en].png (Stored with Git LFS)

Binary file not shown.

BIN
tests/uitests/src/test/snapshots/images/ui_S_t[f.verifysession.impl_VerifySelfSessionView_null_VerifySelfSessionView-Night-0_1_null_5,NEXUS_5,1.0,en].png (Stored with Git LFS)

Binary file not shown.
Loading…
Cancel
Save