From 1627dbfd279988def218ef49fac59177fb9cca33 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Wed, 12 Jul 2023 12:39:41 +0200 Subject: [PATCH] Improve logs. --- .../io/element/android/appnav/di/MatrixClientsHolder.kt | 4 +++- .../libraries/matrix/api/room/RoomSummaryDataSource.kt | 3 ++- .../android/libraries/matrix/impl/room/RoomListExtensions.kt | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/appnav/src/main/kotlin/io/element/android/appnav/di/MatrixClientsHolder.kt b/appnav/src/main/kotlin/io/element/android/appnav/di/MatrixClientsHolder.kt index 24c082627f..bbb14d4d29 100644 --- a/appnav/src/main/kotlin/io/element/android/appnav/di/MatrixClientsHolder.kt +++ b/appnav/src/main/kotlin/io/element/android/appnav/di/MatrixClientsHolder.kt @@ -54,10 +54,12 @@ class MatrixClientsHolder @Inject constructor(private val authenticationService: @Suppress("UNCHECKED_CAST") fun restore(state: SavedStateMap?) { + Timber.d("Restore state") if (state == null || sessionIdsToMatrixClient.isNotEmpty()) return Unit.also { Timber.w("Restore with non-empty map") } val sessionIds = state[SAVE_INSTANCE_KEY] as? Array + Timber.d("Restore matrix session keys = ${sessionIds?.map { it.value }}") if (sessionIds.isNullOrEmpty()) return // Not ideal but should only happens in case of process recreation. This ensure we restore all the active sessions before restoring the node graphs. runBlocking { @@ -76,7 +78,7 @@ class MatrixClientsHolder @Inject constructor(private val authenticationService: fun save(state: MutableSavedStateMap) { val sessionKeys = sessionIdsToMatrixClient.keys.toTypedArray() - Timber.d("Save matrix session keys = $sessionKeys") + Timber.d("Save matrix session keys = ${sessionKeys.map { it.value }}") state[SAVE_INSTANCE_KEY] = sessionKeys } } diff --git a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/RoomSummaryDataSource.kt b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/RoomSummaryDataSource.kt index e6c7b34056..d677d56ed9 100644 --- a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/RoomSummaryDataSource.kt +++ b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/RoomSummaryDataSource.kt @@ -38,12 +38,13 @@ interface RoomSummaryDataSource { suspend fun RoomSummaryDataSource.awaitAllRoomsAreLoaded(timeout: Duration = Duration.INFINITE) { try { + Timber.d("awaitAllRoomsAreLoaded: wait") withTimeout(timeout) { allRoomsLoadingState().firstOrNull { it is RoomSummaryDataSource.LoadingState.Loaded } } } catch (timeoutException: TimeoutCancellationException) { - Timber.v("AwaitAllRooms: no response after $timeout") + Timber.d("awaitAllRoomsAreLoaded: no response after $timeout") } } diff --git a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RoomListExtensions.kt b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RoomListExtensions.kt index 824d477fd3..84c4eeaefb 100644 --- a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RoomListExtensions.kt +++ b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RoomListExtensions.kt @@ -62,7 +62,7 @@ fun RoomListService.roomOrNull(roomId: String): RoomListItem? { return try { room(roomId) } catch (exception: RoomListException) { - Timber.e(exception, "Failed finding room with id=$roomId") + Timber.d(exception, "Failed finding room with id=$roomId.") return null } }