From 0093e611cd507c8954037b21b9666cf63465cc24 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 8 Jul 2024 12:30:06 +0200 Subject: [PATCH] Add Ui test on CallScreenView --- features/call/impl/build.gradle.kts | 2 + .../call/impl/ui/CallScreenStateProvider.kt | 2 +- .../call/impl/ui/CallScreenViewTest.kt | 88 +++++++++++++++++++ .../android/tests/testutils/EventsRecorder.kt | 8 ++ 4 files changed, 99 insertions(+), 1 deletion(-) create mode 100644 features/call/impl/src/test/kotlin/io/element/android/features/call/impl/ui/CallScreenViewTest.kt diff --git a/features/call/impl/build.gradle.kts b/features/call/impl/build.gradle.kts index d6d46d06b0..b2d845a003 100644 --- a/features/call/impl/build.gradle.kts +++ b/features/call/impl/build.gradle.kts @@ -70,4 +70,6 @@ dependencies { testImplementation(projects.libraries.push.test) testImplementation(projects.services.analytics.test) testImplementation(projects.tests.testutils) + testImplementation(libs.androidx.compose.ui.test.junit) + testReleaseImplementation(libs.androidx.compose.ui.test.manifest) } diff --git a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/ui/CallScreenStateProvider.kt b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/ui/CallScreenStateProvider.kt index 75cd962c9a..ec30725fff 100644 --- a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/ui/CallScreenStateProvider.kt +++ b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/ui/CallScreenStateProvider.kt @@ -28,7 +28,7 @@ open class CallScreenStateProvider : PreviewParameterProvider { ) } -private fun aCallScreenState( +internal fun aCallScreenState( urlState: AsyncData = AsyncData.Success("https://call.element.io/some-actual-call?with=parameters"), userAgent: String = "", isInWidgetMode: Boolean = false, diff --git a/features/call/impl/src/test/kotlin/io/element/android/features/call/impl/ui/CallScreenViewTest.kt b/features/call/impl/src/test/kotlin/io/element/android/features/call/impl/ui/CallScreenViewTest.kt new file mode 100644 index 0000000000..6d15e5001c --- /dev/null +++ b/features/call/impl/src/test/kotlin/io/element/android/features/call/impl/ui/CallScreenViewTest.kt @@ -0,0 +1,88 @@ +/* + * Copyright (c) 2024 New Vector Ltd + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package io.element.android.features.call.impl.ui + +import androidx.activity.ComponentActivity +import androidx.compose.ui.test.junit4.AndroidComposeTestRule +import androidx.compose.ui.test.junit4.createAndroidComposeRule +import androidx.test.ext.junit.runners.AndroidJUnit4 +import io.element.android.features.call.impl.pip.PictureInPictureEvents +import io.element.android.features.call.impl.pip.PictureInPictureState +import io.element.android.features.call.impl.pip.aPictureInPictureState +import io.element.android.tests.testutils.EventsRecorder +import io.element.android.tests.testutils.pressBack +import org.junit.Rule +import org.junit.Test +import org.junit.rules.TestRule +import org.junit.runner.RunWith + +@RunWith(AndroidJUnit4::class) +class CallScreenViewTest { + @get:Rule val rule = createAndroidComposeRule() + + @Test + fun `clicking on back when pip is not supported hangs up`() { + val eventsRecorder = EventsRecorder() + val pipEventsRecorder = EventsRecorder(expectEvents = false) + rule.setCallScreenView( + aCallScreenState( + eventSink = eventsRecorder + ), + aPictureInPictureState( + supportPip = false, + eventSink = pipEventsRecorder, + ), + ) + rule.pressBack() + eventsRecorder.assertSize(2) + eventsRecorder.assertTrue(0) { it is CallScreenEvents.SetupMessageChannels } + eventsRecorder.assertTrue(1) { it == CallScreenEvents.Hangup } + } + + @Test + fun `clicking on back when pip is supported enables PiP`() { + val eventsRecorder = EventsRecorder() + val pipEventsRecorder = EventsRecorder() + rule.setCallScreenView( + aCallScreenState( + eventSink = eventsRecorder + ), + aPictureInPictureState( + supportPip = true, + eventSink = pipEventsRecorder, + ), + ) + rule.pressBack() + eventsRecorder.assertSize(1) + eventsRecorder.assertTrue(0) { it is CallScreenEvents.SetupMessageChannels } + pipEventsRecorder.assertSingle(PictureInPictureEvents.EnterPictureInPicture) + } +} + +private fun AndroidComposeTestRule.setCallScreenView( + state: CallScreenState, + pipState: PictureInPictureState, + requestPermissions: (Array, RequestPermissionCallback) -> Unit = { _, _ -> }, +) { + setContent { + CallScreenView( + state = state, + pipState = pipState, + requestPermissions = requestPermissions, + ) + } +} diff --git a/tests/testutils/src/main/kotlin/io/element/android/tests/testutils/EventsRecorder.kt b/tests/testutils/src/main/kotlin/io/element/android/tests/testutils/EventsRecorder.kt index 3a1c4babff..b973b5a8d5 100644 --- a/tests/testutils/src/main/kotlin/io/element/android/tests/testutils/EventsRecorder.kt +++ b/tests/testutils/src/main/kotlin/io/element/android/tests/testutils/EventsRecorder.kt @@ -42,4 +42,12 @@ class EventsRecorder( fun assertList(expectedEvents: List) { assertThat(events).isEqualTo(expectedEvents) } + + fun assertSize(size: Int) { + assertThat(events.size).isEqualTo(size) + } + + fun assertTrue(index: Int, predicate: (T) -> Boolean) { + assertThat((predicate(events[index]))).isTrue() + } }