Kevacoin source tree

Wladimir J. van der Laan bd924241e7 Merge #10758 : Fix some chainstate-init-order bugs. `c0025d0` Fix segfault when shutting down before fully loading (Matt Corallo) `1385697` Order chainstate init more logically. (Matt Corallo) `ff3a219` Call RewindBlockIndex even if we're about to run -reindex-chainstate (Matt Corallo) `b0f3249` More user-friendly error message if UTXO DB runs ahead of block DB (Matt Corallo) `eda888e` Fix some LoadChainTip-related init-order bugs. (Matt Corallo) Pull request description: This does a number of things to clean up chainstate init order, fixing some issues as it goes: * Order chainstate init more logically - first all of the blocktree-related loading, then coinsdb, then pcoinsTip/chainActive. Only create objects as needed. * More clearly document exactly what is and isn't called in -reindex and -reindex-chainstate both with comments noting calls as no-ops and by adding if guards. * Move the writing of fTxIndex to LoadBlockIndex - this fixes a bug introduced in `d6af06d68a` where InitBlockIndex was writing to fTxIndex which had not yet been checked (because LoadChainTip hadn't yet initialized the chainActive, which would otherwise have resulted in InitBlockIndex being a NOP), allowing you to modify -txindex without reindex, potentially corrupting your chainstate! * Rename InitBlockIndex to LoadGenesisBlock, which is now a more natural name for it. Also check mapBlockIndex instead of chainActive, fixing a bug where we'd write the genesis block out on every start. * Move LoadGenesisBlock further down in init. This is a more logical location for it, as it is after all of the blockindex-related loading and checking, but before any of the UTXO-related loading and checking. * Give LoadChainTip a return value - allowing it to indicate that the UTXO DB ran ahead of the block DB. This just provides a nicer error message instead of the previous mysterious assert(!setBlockIndexCandidates.empty()) error. * Calls ActivateBestChain in case we just loaded the genesis block in LoadChainTip, avoiding relying on the ActivateBestChain in ThreadImport before continuing init process. * Move all of the VerifyDB()-related stuff into a -reindex + -reindex-chainstate if guard. It couldn't do anything useful as chainActive.Tip() would be null at this point anyway. Tree-SHA512: 3c96ee7ed44f4130bee3479a40c5cd99a619fda5e309c26d60b54feab9f6ec60fabab8cf47a049c9cf15e88999b2edb7f16cbe6819e97273560b201a89d90762		7 years ago
.github	Mention reporting security issues responsibly	8 years ago
.tx	qt: Set transifex slug to 0.14	8 years ago
build-aux/m4	Explicitly search for bdb5.3.	8 years ago
contrib	p2p: Hardcoded seeds update pre-0.15 branch	7 years ago
depends	Merge #10508 : Run Qt wallet tests on travis	8 years ago
doc	developer-notes: add reference to snake_case and PascalCase	8 years ago
share	Slightly overhaul NSI pixmaps	8 years ago
src	Merge #10758 : Fix some chainstate-init-order bugs.	7 years ago
test	[wallet] Specify wallet name in wallet loading errors	8 years ago
.gitattributes	…
.gitignore	Use shared config file for functional and util tests	8 years ago
.travis.yml	Merge #10508 : Run Qt wallet tests on travis	8 years ago
CONTRIBUTING.md	[doc] Add blob about finding reviewers.	8 years ago
COPYING	[Trivial] Update license year range to 2017	8 years ago
INSTALL.md	Update INSTALL landing redirection notice for build instructions.	8 years ago
Makefile.am	Filter subtrees and and benchmarks from coverage report	8 years ago
README.md	Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py	8 years ago
autogen.sh	Add MIT license to autogen.sh and share/genbuild.sh	8 years ago
configure.ac	Protect SSE4 code behind a compile-time flag	8 years ago
libbitcoinconsensus.pc.in	Unify package name to as few places as possible without major changes	9 years ago

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoin.org/en/download, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md.

The developer mailing list should be used to discuss complicated or controversial changes before working on a patch set.

Developer IRC can be found on Freenode at #bitcoin-core-dev.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.