Wladimir J. van der Laan 95941396ff

Merge #12119: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH ...

596c446 [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (Sjors Provoost)

Pull request description:

  If `-changetype` is not explicitly set, then regardless of `-addresstype`, the wallet will use a ~`bech32` change address~ `P2WPKH` change output if any destination is `P2WPKH` or `P2WSH`.

  This seems more intuitive to me and more in line with the spirit of [BIP-69](https://github.com/bitcoin/bips/blob/master/bip-0069.mediawiki).

  When combined with #11991 a QT user could opt to use `bech32` exclusively without having to figure out how to launch with `-changetype=bech32`, although so would #11937.

Tree-SHA512: 9238d3ccd1f3be8dfdd43444ccf45d6bdc6584ced3172a3045f3ecfec4a7cc8999db0cdb76ae49236492a84e6dbf3a1fdf18544d3eaf6d518e1f8bd241db33e7

2018-01-24 15:22:42 +01:00

..

forms

[qt] receive tab: bech32 address opt-in checkbox

2018-01-16 20:11:40 +00:00

locale

qt: Periodic translations update

2017-08-09 12:04:41 +02:00

res

…

test

Make sure WalletRescanReserver has successfully reserved the rescan

2018-01-23 20:24:18 -10:00

addressbookpage.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

addressbookpage.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

addresstablemodel.cpp

[qt] receive tab: bech32 address opt-in checkbox

2018-01-16 20:11:40 +00:00

addresstablemodel.h

[qt] receive tab: bech32 address opt-in checkbox

2018-01-16 20:11:40 +00:00

askpassphrasedialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

askpassphrasedialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bantablemodel.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bantablemodel.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bitcoin_locale.qrc

…

bitcoin.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bitcoin.qrc

…

bitcoinaddressvalidator.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bitcoinaddressvalidator.h

…

bitcoinamountfield.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bitcoinamountfield.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bitcoingui.cpp

Merge #12035: [qt] change µBTC to bits

2018-01-03 22:16:13 -10:00

bitcoingui.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

bitcoinstrings.cpp

qt: Periodic translations update

2017-07-31 12:19:05 +02:00

bitcoinunits.cpp

Merge #12035: [qt] change µBTC to bits

2018-01-03 22:16:13 -10:00

bitcoinunits.h

Merge #12035: [qt] change µBTC to bits

2018-01-03 22:16:13 -10:00

callback.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

clientmodel.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

clientmodel.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

coincontroldialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

coincontroldialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

coincontroltreewidget.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

coincontroltreewidget.h

…

csvmodelwriter.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

csvmodelwriter.h

…

editaddressdialog.cpp

[qt] receive tab: bech32 address opt-in checkbox

2018-01-16 20:11:40 +00:00

editaddressdialog.h

…

guiconstants.h

…

guiutil.cpp

Use flexible font size for QRCode image address

2018-01-15 09:33:46 -10:00

guiutil.h

Use flexible font size for QRCode image address

2018-01-15 09:33:46 -10:00

intro.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

intro.h

…

macdockiconhandler.h

…

macdockiconhandler.mm

Document the preference of nullptr over NULL or (void*)0

2017-08-18 09:51:00 +02:00

macnotificationhandler.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

macnotificationhandler.mm

[macOS] remove Growl support, remove unused code

2017-09-07 10:11:44 -07:00

Makefile

…

modaloverlay.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

modaloverlay.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

networkstyle.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

networkstyle.h

…

notificator.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

notificator.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

openuridialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

openuridialog.h

…

optionsdialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

optionsdialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

optionsmodel.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

optionsmodel.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

overviewpage.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

overviewpage.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

paymentrequest.proto

…

paymentrequestplus.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

paymentrequestplus.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

paymentserver.cpp

[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH

2018-01-23 17:56:15 +01:00

paymentserver.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

peertablemodel.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

peertablemodel.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

platformstyle.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

platformstyle.h

…

qvalidatedlineedit.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

qvalidatedlineedit.h

…

qvaluecombobox.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

qvaluecombobox.h

…

receivecoinsdialog.cpp

Avoid potential null dereference in ReceiveCoinsDialog constructor

2018-01-17 13:23:26 -05:00

receivecoinsdialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

receiverequestdialog.cpp

Use flexible font size for QRCode image address

2018-01-15 09:33:46 -10:00

receiverequestdialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

recentrequeststablemodel.cpp

Merge #12035: [qt] change µBTC to bits

2018-01-03 22:16:13 -10:00

recentrequeststablemodel.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

rpcconsole.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

rpcconsole.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

sendcoinsdialog.cpp

Replaces numbered place marker %2 with %1.

2018-01-04 20:57:22 +01:00

sendcoinsdialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

sendcoinsentry.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

sendcoinsentry.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

signverifymessagedialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

signverifymessagedialog.h

…

splashscreen.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

splashscreen.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

trafficgraphwidget.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

trafficgraphwidget.h

…

transactiondesc.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactiondesc.h

…

transactiondescdialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactiondescdialog.h

…

transactionfilterproxy.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactionfilterproxy.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactionrecord.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactionrecord.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactiontablemodel.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactiontablemodel.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

transactionview.cpp

Merge #12074: [qt] Optimizes boolean expression model && model->haveWatchOnly()

2018-01-03 21:58:46 -10:00

transactionview.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

utilitydialog.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

utilitydialog.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

walletframe.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

walletframe.h

…

walletmodel.cpp

[qt] receive tab: bech32 address opt-in checkbox

2018-01-16 20:11:40 +00:00

walletmodel.h

[qt] receive tab: bech32 address opt-in checkbox

2018-01-16 20:11:40 +00:00

walletmodeltransaction.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

walletmodeltransaction.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

walletview.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

walletview.h

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

winshutdownmonitor.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

winshutdownmonitor.h

…