Pieter Wuille 21180ff734 Simplify return values of GetCoin/HaveCoin(InCache) ...

This removes the possibility for GetCoin/HaveCoin/HaveCoinInCache to return
true while the respective coin is spent. By doing it across all calls, some
extra checks can be eliminated.

coins_tests is modified to call HaveCoin sometimes before and sometimes
after AccessCoin. A further change is needed because the semantics for
GetCoin slightly changed, causing a pruned entry in the parent cache to not
be pulled into the child in FetchCoin.

2017-06-26 16:16:26 -07:00

..

bench

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

compat

[trivial] Add end of namespace comments

2017-05-31 22:21:25 +02:00

config

…

consensus

Merge #10608: Add a comment explaining the use of MAX_BLOCK_BASE_SIZE.

2017-06-24 15:45:14 +02:00

crypto

Limit variable scope

2017-06-05 00:52:36 +02:00

leveldb

Fixed multiple typos

2017-06-22 19:18:10 +03:00

obj

…

obj-test

…

policy

Fixed multiple typos

2017-06-22 19:18:10 +03:00

primitives

Perform member initialization in initialization lists where possible

2017-06-04 01:09:48 +02:00

qt

Merge #10633: doc: Fix various typos

2017-06-22 20:46:37 +02:00

rpc

Merge #10627: fixed listunspent rpc convert parameter

2017-06-24 15:39:43 +02:00

script

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

secp256k1

Fixed multiple typos

2017-06-22 19:18:10 +03:00

support

Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents.

2017-06-22 19:16:37 +02:00

test

Simplify return values of GetCoin/HaveCoin(InCache)

2017-06-26 16:16:26 -07:00

univalue

…

wallet

Merge #10412: Improve wallet rescan API

2017-06-24 16:37:42 +02:00

zmq

Missing includes

2017-04-13 02:31:44 +02:00

.clang-format

Make clang-format use C++11 features (e.g. A<A<int>> instead of A<A<int> >)

2017-06-15 17:31:58 +02:00

addrdb.cpp

Deduplicate addrdb.cpp and use CHashWriter/Verifier

2017-06-01 16:42:07 -07:00

addrdb.h

Deduplicate addrdb.cpp and use CHashWriter/Verifier

2017-06-01 16:42:07 -07:00

addrman.cpp

Merge #9792: FastRandomContext improvements and switch to ChaCha20

2017-04-24 14:28:49 +02:00

addrman.h

Merge #9792: FastRandomContext improvements and switch to ChaCha20

2017-04-24 14:28:49 +02:00

amount.h

Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module

2017-05-03 18:00:13 +02:00

arith_uint256.cpp

Fix instantiation and array accesses in class base_uint<BITS>

2017-06-07 17:21:29 +00:00

arith_uint256.h

Fix instantiation and array accesses in class base_uint<BITS>

2017-06-07 17:21:29 +00:00

base58.cpp

[trivial] Add end of namespace comments

2017-05-31 22:21:25 +02:00

base58.h

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Chainparams: Use a regular factory for creating chainparams

2017-05-03 18:15:47 +02:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Merge #10536: Remove unreachable or otherwise redundant code

2017-06-20 16:16:38 -07:00

bitcoind-res.rc

…

bitcoind.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

blockencodings.cpp

Simplify "bool x = y ? true : false" to "bool x = y"

2017-06-11 15:44:01 +02:00

blockencodings.h

…

bloom.cpp

scripted-diff: Fully remove BOOST_FOREACH

2017-06-05 20:10:50 +02:00

bloom.h

…

chain.cpp

Fixed multiple typos

2017-06-22 19:18:10 +03:00

chain.h

Merge #9908: Define 7200 second timestamp window constant

2017-03-06 10:02:05 +01:00

chainparams.cpp

chainparams: make supported service bits option explicit

2017-06-22 15:21:22 -04:00

chainparams.h

chainparams: make supported service bits option explicit

2017-06-22 15:21:22 -04:00

chainparamsbase.cpp

Chainparams: Use a regular factory for creating chainparams

2017-05-03 18:15:47 +02:00

chainparamsbase.h

Chainparams: Use a regular factory for creating chainparams

2017-05-03 18:15:47 +02:00

chainparamsseeds.h

…

checkpoints.cpp

…

checkpoints.h

…

checkqueue.h

Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE

2017-06-13 18:05:58 -07:00

clientversion.cpp

…

clientversion.h

Fix build warning from #error text

2017-04-07 14:37:25 -04:00

coins.cpp

Simplify return values of GetCoin/HaveCoin(InCache)

2017-06-26 16:16:26 -07:00

coins.h

Simplify return values of GetCoin/HaveCoin(InCache)

2017-06-26 16:16:26 -07:00

compat.h

compat: use unsigned int instead of u_int

2017-03-05 09:51:21 +00:00

compressor.cpp

…

compressor.h

…

core_io.h

…

core_memusage.h

Add RecursiveDynamicUsage overload for std::shared_ptr

2017-05-04 16:50:52 -04:00

core_read.cpp

Merge #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of

2017-06-08 20:26:40 +02:00

core_write.cpp

Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE

2017-06-13 18:05:58 -07:00

cuckoocache.h

Merge #10577: Add an explanation of quickly hashing onto a non-power of two range.

2017-06-24 11:28:04 +02:00

dbwrapper.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

dbwrapper.h

Report on-disk size in gettxoutsetinfo

2017-05-26 13:33:39 -07:00

fs.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

fs.h

[Trivial] Add BITCOIN_FS_H endif footer in fs.h

2017-05-19 02:01:28 -07:00

hash.cpp

Add specialization of SipHash for 256 + 32 bit data

2017-05-26 13:24:25 -07:00

hash.h

Add specialization of SipHash for 256 + 32 bit data

2017-05-26 13:24:25 -07:00

httprpc.cpp

Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE

2017-06-13 18:05:58 -07:00

httprpc.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

httpserver.cpp

Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents.

2017-06-22 19:16:37 +02:00

httpserver.h

Fixed multiple typos

2017-06-22 19:18:10 +03:00

indirectmap.h

…

init.cpp

Merge #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options

2017-06-26 15:04:54 +02:00

init.h

…

key.cpp

Remove unused C++ code not covered by unit tests

2017-04-26 21:20:02 +02:00

key.h

Remove unused C++ code not covered by unit tests

2017-04-26 21:20:02 +02:00

keystore.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

keystore.h

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

limitedmap.h

…

Makefile.am

Merge #10544: Update to LevelDB 1.20

2017-06-13 19:48:13 +02:00

Makefile.bench.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.leveldb.include

Add extra LevelDB source to Makefile

2017-06-09 19:25:36 -07:00

Makefile.qt.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.qttest.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.test.include

Merge #10544: Update to LevelDB 1.20

2017-06-13 19:48:13 +02:00

memusage.h

Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set}

2017-06-07 15:04:54 +02:00

merkleblock.cpp

Trivial: remove extra character from comment

2017-05-01 14:18:30 -07:00

merkleblock.h

Fixed typo in documentation for merkleblock.h

2017-04-22 07:22:17 -04:00

miner.cpp

scripted-diff: Fully remove BOOST_FOREACH

2017-06-05 20:10:50 +02:00

miner.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

net_processing.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

net_processing.h

Add timeout for headers sync

2017-06-05 16:33:35 -04:00

net.cpp

Merge #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options

2017-06-26 15:04:54 +02:00

net.h

add Binds, WhiteBinds to CConnman::Options

2017-06-15 23:07:14 +02:00

netaddress.cpp

net: add an internal subnet for representing unresolved hostnames

2017-06-14 18:05:00 -04:00

netaddress.h

net: add an internal subnet for representing unresolved hostnames

2017-06-14 18:05:00 -04:00

netbase.cpp

net: do not allow resolving to an internal address

2017-06-14 18:05:01 -04:00

netbase.h

[net] Added SetSocketNoDelay() utility function

2017-04-05 11:31:43 -07:00

netmessagemaker.h

…

noui.cpp

…

noui.h

…

pow.cpp

…

pow.h

…

prevector.h

Clarify prevector::erase and avoid swap-to-clear

2017-06-09 13:23:20 -07:00

protocol.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

protocol.h

…

pubkey.cpp

[trivial] Add end of namespace comments

2017-05-31 22:21:25 +02:00

pubkey.h

…

random.cpp

random: fix crash on some 64bit platforms

2017-06-16 15:19:15 -04:00

random.h

Merge #10377: Use rdrand as entropy source on supported platforms

2017-06-14 15:22:15 +02:00

rest.cpp

Fixed multiple typos

2017-06-22 19:18:10 +03:00

reverselock.h

…

scheduler.cpp

Add perf counter data to GetStrongRandBytes state in scheduler

2017-05-22 16:01:52 -04:00

scheduler.h

Replace boost::function with std::function (C++11)

2017-05-13 17:59:09 +02:00

serialize.h

…

streams.h

Fix some empty vector references

2017-04-21 05:58:31 -07:00

sync.cpp

scripted-diff: Remove PAIRTYPE

2017-06-05 20:14:53 +02:00

sync.h

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

scripted-diff: Fully remove BOOST_FOREACH

2017-06-05 20:10:50 +02:00

timedata.h

Merge #8808: Do not shadow variables (gcc set)

2017-03-03 15:48:53 +01:00

tinyformat.h

util: Throw tinyformat::format_error on formatting error

2017-03-13 06:51:15 +01:00

torcontrol.cpp

Fixed multiple typos

2017-06-22 19:18:10 +03:00

torcontrol.h

…

txdb.cpp

Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()

2017-06-25 10:26:01 +02:00

txdb.h

Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()

2017-06-25 10:26:01 +02:00

txmempool.cpp

Simplify return values of GetCoin/HaveCoin(InCache)

2017-06-26 16:16:26 -07:00

txmempool.h

Simplify return values of GetCoin/HaveCoin(InCache)

2017-06-26 16:16:26 -07:00

ui_interface.cpp

…

ui_interface.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

uint256.cpp

uint256: replace sprintf with HexStr and reverse-iterator

2017-02-27 10:02:45 +01:00

uint256.h

…

undo.h

Replace CTxInUndo with Coin

2017-06-01 11:56:06 -07:00

util.cpp

Merge #9895: Turn TryCreateDirectory() into TryCreateDirectories()

2017-06-14 16:12:14 +02:00

util.h

Merge #10565: [coverage] Remove subtrees and benchmarks from coverage report

2017-06-22 20:57:11 +02:00

utilmoneystr.cpp

Refactor: Remove using namespace <xxx> from util*

2017-03-08 08:47:02 -08:00

utilmoneystr.h

…

utilstrencodings.cpp

Fixed multiple typos

2017-06-22 19:18:10 +03:00

utilstrencodings.h

scripted-diff: Remove PAIRTYPE

2017-06-05 20:14:53 +02:00

utiltime.cpp

[logging] log system time and mock time

2017-05-10 15:49:00 -04:00

utiltime.h

[logging] log system time and mock time

2017-05-10 15:49:00 -04:00

validation.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

validation.h

Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn

2017-06-20 18:00:21 -07:00

validationinterface.cpp

Remove CValidationInterface::UpdatedTransaction

2017-04-13 10:36:21 -04:00

validationinterface.h

Remove CValidationInterface::UpdatedTransaction

2017-04-13 10:36:21 -04:00

version.h

Remove unused constant MEMPOOL_GD_VERSION

2017-06-09 01:45:36 +02:00

versionbits.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

versionbits.h

scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/

2017-05-30 19:21:52 +02:00

warnings.cpp

…

warnings.h

…