MarcoFalke d6d2c8503c

Merge #11340: Trivial: Fix validation comments ...

a0b4c2461 Trivial: Fix validation comments (Dan Raviv)

Pull request description:

  - Move comment about transaction/block weight calculation so it applies not only to the GetBlockWeight function but also to GetTransactionWeight
  - Fix comment in validation.cpp referencing future deployment of BIP113. It has already been deployed.
  - The doc comment for BLOCK_DOWNLOAD_WINDOW wasn't updated since pruning was introduced, so it still refers to pruning as something that might happen in the future. A larger BLOCK_DOWNLOAD_WINDOW window would now, indeed, make pruning harder.

Tree-SHA512: ff86ff02c993e8317b9a0decfe5f5b6aae77b7d50e2b253ed73eb553348142bfc30cfeda15fae91907bab8f920e0ea7c52714f4cc7f33a9d6a777f708e2c99ba

2017-09-18 11:32:58 +02:00

..

bench

Changing &vec[0] to vec.data(), what 9804 missed

2017-09-08 10:36:26 +12:00

compat

Merge #11144: Move local include to before system includes

2017-08-28 17:57:44 +02:00

config

…

consensus

Trivial: Fix validation comments

2017-09-15 14:07:41 +03:00

crypto

Merge #11143: Fix include path for bitcoin-config.h

2017-09-05 23:15:55 +02:00

leveldb

…

obj

…

obj-test

…

policy

Use a sensible default for blockmaxweight

2017-09-11 15:51:26 -04:00

primitives

Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction

2017-09-06 20:14:52 +02:00

qt

Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected

2017-09-14 13:34:22 -07:00

rpc

Merge #11267: rpc: update cli for estimate*fee argument rename

2017-09-12 19:31:30 +02:00

script

Merge #10793: Changing &var[0] to var.data()

2017-09-08 01:16:54 +02:00

secp256k1

…

support

Switch memory_cleanse implementation to BoringSSL's to ensure memory clearing even with link-time optimization.

2017-09-06 13:46:11 -07:00

test

Merge #10793: Changing &var[0] to var.data()

2017-09-08 01:16:54 +02:00

univalue

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

wallet

Merge #11250: Bump wallet version to 159900 and remove the usehd option

2017-09-08 02:28:12 +02:00

zmq

Merge #10809: optim: mark a few classes final

2017-08-21 18:25:48 +02:00

.clang-format

…

addrdb.cpp

…

addrdb.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

addrman.cpp

…

addrman.h

when clearing addrman clear mapInfo and mapAddr

2017-09-05 17:32:06 -07:00

amount.h

…

arith_uint256.cpp

…

arith_uint256.h

Prefer compile-time checking over run-time checking

2017-08-17 00:42:32 +02:00

base58.cpp

Remove unused GetKeyID and IsScript methods from CBitcoinAddress

2017-09-06 23:48:35 +01:00

base58.h

Move CBitcoinAddress to base58.cpp

2017-09-06 13:07:45 -07:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Fix style in -stdin and -stdinrpcpass handling

2017-09-07 00:35:28 +01:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Introduce wrappers around CBitcoinAddress

2017-09-06 13:07:45 -07:00

bitcoind-res.rc

…

bitcoind.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

blockencodings.cpp

…

blockencodings.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

bloom.cpp

…

bloom.h

…

chain.cpp

…

chain.h

Ensure that data types are consistent

2017-09-07 11:17:35 +08:00

chainparams.cpp

…

chainparams.h

…

chainparamsbase.cpp

Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332

2017-09-06 01:18:35 +02:00

chainparamsbase.h

…

chainparamsseeds.h

…

checkpoints.cpp

…

checkpoints.h

…

checkqueue.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

clientversion.cpp

…

clientversion.h

…

coins.cpp

Use nullptr instead of zero (0) as the null pointer constant

2017-08-16 10:24:18 +02:00

coins.h

…

compat.h

…

compressor.cpp

…

compressor.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

core_io.h

Pass serialization flags and whether to include hex to TxToUniv

2017-08-17 10:42:51 -07:00

core_memusage.h

…

core_read.cpp

…

core_write.cpp

Introduce wrappers around CBitcoinAddress

2017-09-06 13:07:45 -07:00

cuckoocache.h

Fix header guards using reserved identifiers

2017-08-26 02:56:53 +03:00

dbwrapper.cpp

Merge #10701: Remove the virtual specifier for functions with the override specifier

2017-09-04 18:06:44 -07:00

dbwrapper.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

fs.cpp

…

fs.h

…

hash.cpp

…

hash.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

httprpc.cpp

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

httprpc.h

…

httpserver.cpp

Merge #10809: optim: mark a few classes final

2017-08-21 18:25:48 +02:00

httpserver.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

indirectmap.h

…

init.cpp

Fix uninitialized g_connman crash in Shutdown()

2017-09-14 16:47:10 +12:00

init.h

…

key.cpp

…

key.h

Add length check for CExtKey deserialization

2017-08-17 21:54:23 +02:00

keystore.cpp

…

keystore.h

Merge #10916: add missing lock to crypter GetKeys()

2017-09-07 22:04:18 +02:00

limitedmap.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

Makefile.am

Merge #11143: Fix include path for bitcoin-config.h

2017-09-05 23:15:55 +02:00

Makefile.bench.include

…

Makefile.leveldb.include

…

Makefile.qt.include

…

Makefile.qttest.include

Remove redundant testutil files

2017-09-05 15:02:17 +12:00

Makefile.test.include

Remove redundant testutil files

2017-09-05 15:02:17 +12:00

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

miner.cpp

Deprecate confusing blockmaxsize, fix getmininginfo output

2017-09-11 15:51:25 -04:00

miner.h

Deprecate confusing blockmaxsize, fix getmininginfo output

2017-09-11 15:51:25 -04:00

net_processing.cpp

net: drop unused connman param

2017-09-06 19:32:04 -04:00

net_processing.h

net: drop unused connman param

2017-09-06 19:32:04 -04:00

net.cpp

net: drop unused connman param

2017-09-06 19:32:04 -04:00

net.h

net: drop unused connman param

2017-09-06 19:32:04 -04:00

netaddress.cpp

…

netaddress.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

netbase.cpp

…

netbase.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

netmessagemaker.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

noui.cpp

…

noui.h

…

pow.cpp

…

pow.h

…

prevector.h

Fix header guards using reserved identifiers

2017-08-26 02:56:53 +03:00

protocol.cpp

…

protocol.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

pubkey.cpp

…

pubkey.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

random.cpp

Merge #10843: Add attribute [[noreturn]] (C++11) to functions that will not return

2017-08-22 09:38:49 +02:00

random.h

…

rest.cpp

Merge #10845: Remove unreachable code

2017-09-06 21:44:18 +02:00

reverse_iterator.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

reverselock.h

…

scheduler.cpp

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

scheduler.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

serialize.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

streams.h

Trivial: Documentation fixes for CVectorWriter ctors

2017-08-26 13:20:36 +03:00

sync.cpp

Use nullptr instead of zero (0) as the null pointer constant

2017-08-16 10:24:18 +02:00

sync.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

timedata.h

…

tinyformat.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

torcontrol.cpp

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

torcontrol.h

…

txdb.cpp

Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable"

2017-09-07 09:21:04 -07:00

txdb.h

Merge #10809: optim: mark a few classes final

2017-08-21 18:25:48 +02:00

txmempool.cpp

Remove redundant explicitly defined copy ctors

2017-08-28 01:29:48 +03:00

txmempool.h

Merge #11164: Fix boost headers included as user instead of system headers

2017-09-05 22:27:17 +02:00

ui_interface.cpp

…

ui_interface.h

Drop upgrade-cancel callback registration for a generic "resumeable"

2017-08-20 20:04:15 -04:00

uint256.cpp

Changing &vec[0] to vec.data(), what 9804 missed

2017-09-08 10:36:26 +12:00

uint256.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

undo.h

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

util.cpp

Merge #10901: Fix constness of ArgsManager methods

2017-08-16 16:09:27 +02:00

util.h

Merge #10901: Fix constness of ArgsManager methods

2017-08-16 16:09:27 +02:00

utilmoneystr.cpp

…

utilmoneystr.h

…

utilstrencodings.cpp

Allow setting nMinimumChainWork on command line

2017-09-05 15:05:28 -04:00

utilstrencodings.h

Allow setting nMinimumChainWork on command line

2017-09-05 15:05:28 -04:00

utiltime.cpp

…

utiltime.h

…

validation.cpp

Trivial: Fix validation comments

2017-09-15 14:07:41 +03:00

validation.h

Trivial: Fix validation comments

2017-09-15 14:07:41 +03:00

validationinterface.cpp

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

validationinterface.h

…

version.h

…

versionbits.cpp

Declare single-argument (non-converting) constructors "explicit"

2017-08-16 16:33:25 +02:00

versionbits.h

…

warnings.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

warnings.h

…