Kevacoin source tree
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
MarcoFalke 45173fa6fc
Merge #12079: Improve prioritisetransaction test coverage
7 years ago
..
test_framework Increment MIT Licence copyright header year on files modified in 2017 7 years ago
.gitignore
README.md Fix incorrect Markdown link 7 years ago
abandonconflict.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
assumevalid.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bip9-softforks.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bip65-cltv-p2p.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bip68-112-113-p2p.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bip68-sequence.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bipdersig-p2p.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bitcoin_cli.py cli: Reject arguments to -getinfo 7 years ago
blockchain.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
bumpfee.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
combine_logs.py [qa] combine_logs: Use ordered list for logfiles 8 years ago
combined_log_template.html Introduce combine_logs.py to combine log files from multiple bitcoinds. 8 years ago
conf_args.py Add configuration/argument testing 7 years ago
create_cache.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
dbcrash.py [tests] fixup dbcrash interaction with add_nodes() 7 years ago
decodescript.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
deprecated_rpc.py scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error 7 years ago
disablewallet.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
disconnect_ban.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
example_test.py [tests] Fix network threading in functional tests 7 years ago
feature_logging.py test: Add tests for `-debuglogfile` with subdirs 7 years ago
fundrawtransaction.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
getblocktemplate_longpoll.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
getchaintips.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
httpbasics.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
import-rescan.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
importmulti.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
importprunedfunds.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
invalidateblock.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
invalidblockrequest.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
invalidtxrequest.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
keypool-topup.py Create walletdir if datadir doesn't exist and fix tests 7 years ago
keypool.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
listsinceblock.py Make listsinceblock refuse unknown block hash 7 years ago
listtransactions.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
maxuploadtarget.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
mempool_limit.py Merge #12001: [RPC] Adding ::minRelayTxFee amount to getmempoolinfo and updating help 7 years ago
mempool_packages.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
mempool_persist.py add test for unconfirmed balance between restarts 7 years ago
mempool_reorg.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
mempool_resurrect_test.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
mempool_spendcoinbase.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
merkle_blocks.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
minchainwork.py Remove unused imports 7 years ago
mining.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
multi_rpc.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
multiwallet.py Merge #11726: Cleanups + nit fixes for walletdir PR 7 years ago
net.py scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error 7 years ago
node_network_limited.py [tests] refactor node_network_limited 7 years ago
notifications.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
nulldummy.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-acceptblock.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-compactblocks.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-feefilter.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-fingerprint.py [tests] Use network_thread_start() in tests. 7 years ago
p2p-fullblocktest.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-leaktests.py [tests] Fix network threading in functional tests 7 years ago
p2p-mempool.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-segwit.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-timeouts.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
p2p-versionbits-warning.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
preciousblock.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
prioritise_transaction.py Merge #12079: Improve prioritisetransaction test coverage 7 years ago
proxy_test.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
pruning.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
rawtransactions.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
receivedby.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
reindex.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
replace-by-fee.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
resendwallettransactions.py scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error 7 years ago
rest.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
rpcbind_test.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
rpcnamedargs.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
segwit.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
sendheaders.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
signmessages.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
signrawtransactions.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
smartfees.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
test_runner.py Merge #12062: Increment MIT Licence copyright header year on files modified in 2017 7 years ago
txn_clone.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
txn_doublespend.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
uacomment.py [tests] Add uacomment tests 7 years ago
uptime.py [tests] don't override __init__() in individual tests 7 years ago
wallet-accounts.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
wallet-dump.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
wallet-encryption.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
wallet-hd.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
wallet.py Merge #12001: [RPC] Adding ::minRelayTxFee amount to getmempoolinfo and updating help 7 years ago
walletbackup.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
zapwallettxes.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago
zmq_test.py Increment MIT Licence copyright header year on files modified in 2017 7 years ago

README.md

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • Avoid wildcard imports where possible
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Call network_thread_start() after all P2PInterface objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p-accept-block.py, p2p-compactblocks.py.

Comptool

  • Comptool is a Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances. It should not be used to write static tests with known outcomes, since that type of test is easier to write and maintain using the standard BitcoinTestFramework.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • A list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, P2P tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.