Wladimir J. van der Laan 07c92b98e2 Merge #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp ... f01103c MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp (Russell Yanofsky) e7fe320 MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp (Russell Yanofsky) d97fe20 Move some static functions out of wallet.h/cpp (Russell Yanofsky) Pull request description: This just moves some static wallet fee and init functions out of `wallet/wallet.cpp` and into new `wallet/fees.cpp` and `wallet/init.cpp` source files. There is one commit updating declarations and callers, followed by two MOVEONLY commits actually moving the function bodies. This change is desirable because wallet.h/cpp are monolithic and hard to navigate, so pulling things out and grouping together pieces of related functionality should improve the organization. Another motivation is the wallet process separation work in https://github.com/bitcoin/bitcoin/pull/10973, where (at least initially) parameter parsing and fee estimation are still done in the main process rather than the wallet process, and having functions that run in different processes scrambled up throughout wallet.cpp is unnecessarily confusing. Tree-SHA512: 6e6982ff82b2ab4e681c043907e2b1801ceb9513394730070f16c46ad338278a863f5b3759aa13db76a259b268b1c919c81f4e339f0796a3cfb990161e8c316d		2017-08-25 21:30:42 +02:00
..
forms	Fix typo in sendcoinsdialog.	2017-08-02 12:19:50 +09:00
locale	qt: Periodic translations update	2017-08-09 12:04:41 +02:00
res
test	Merge #10956: Fix typos	2017-08-16 00:37:18 +02:00
addressbookpage.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
addressbookpage.h	Remove unnecessary forward class declarations in header files	2017-06-12 20:37:43 +02:00
addresstablemodel.cpp	scripted-diff: Remove #include <boost/foreach.hpp>	2017-06-22 03:48:52 +02:00
addresstablemodel.h
askpassphrasedialog.cpp
askpassphrasedialog.h
bantablemodel.cpp
bantablemodel.h
bitcoin_locale.qrc
bitcoin.cpp	Merge #9964: Add const to methods that do not modify the object for which it is called	2017-08-16 02:09:49 +02:00
bitcoin.qrc
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp
bitcoinamountfield.h
bitcoingui.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
bitcoingui.h	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
bitcoinstrings.cpp	qt: Periodic translations update	2017-07-31 12:19:05 +02:00
bitcoinunits.cpp
bitcoinunits.h
callback.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
clientmodel.cpp	Avoid redundant redeclaration of GetWarnings(const string&)	2017-07-18 15:54:38 +02:00
clientmodel.h	Remove unnecessary forward class declarations in header files	2017-06-12 20:37:43 +02:00
coincontroldialog.cpp	Move some static functions out of wallet.h/cpp	2017-08-14 11:19:38 -04:00
coincontroldialog.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
coincontroltreewidget.cpp	Limit variable scope	2017-06-05 00:52:36 +02:00
coincontroltreewidget.h
csvmodelwriter.cpp
csvmodelwriter.h
editaddressdialog.cpp
editaddressdialog.h
guiconstants.h
guiutil.cpp	scripted-diff: stop using the gArgs wrappers	2017-08-14 17:02:10 +02:00
guiutil.h
intro.cpp	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
intro.h
macdockiconhandler.h
macdockiconhandler.mm	Document the preference of nullptr over NULL or (void*)0	2017-08-18 09:51:00 +02:00
macnotificationhandler.h
macnotificationhandler.mm	Document the preference of nullptr over NULL or (void*)0	2017-08-18 09:51:00 +02:00
Makefile
modaloverlay.cpp	Fixed multiple typos	2017-06-22 19:18:10 +03:00
modaloverlay.h	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
networkstyle.cpp	doc: spelling fixes	2017-08-16 00:24:39 +02:00
networkstyle.h
notificator.cpp	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
notificator.h
openuridialog.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
openuridialog.h
optionsdialog.cpp	Move some static functions out of wallet.h/cpp	2017-08-14 11:19:38 -04:00
optionsdialog.h
optionsmodel.cpp	Merge #9964: Add const to methods that do not modify the object for which it is called	2017-08-16 02:09:49 +02:00
optionsmodel.h	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
overviewpage.cpp	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
overviewpage.h
paymentrequest.proto
paymentrequestplus.cpp	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
paymentrequestplus.h
paymentserver.cpp	Merge #10964: Pass SendCoinsRecipient (208 bytes) by reference	2017-08-15 20:43:45 +02:00
paymentserver.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
peertablemodel.cpp	scripted-diff: Remove Q_FOREACH	2017-06-05 20:11:01 +02:00
peertablemodel.h
platformstyle.cpp	scripted-diff: Remove Q_FOREACH	2017-06-05 20:11:01 +02:00
platformstyle.h
qvalidatedlineedit.cpp
qvalidatedlineedit.h
qvaluecombobox.cpp
qvaluecombobox.h
receivecoinsdialog.cpp	scripted-diff: Remove Q_FOREACH	2017-06-05 20:11:01 +02:00
receivecoinsdialog.h	Remove unnecessary forward class declarations in header files	2017-06-12 20:37:43 +02:00
receiverequestdialog.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
receiverequestdialog.h
recentrequeststablemodel.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
recentrequeststablemodel.h
rpcconsole.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
rpcconsole.h	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
sendcoinsdialog.cpp	Move some static functions out of wallet.h/cpp	2017-08-14 11:19:38 -04:00
sendcoinsdialog.h	Use CoinControl to pass custom fee setting from QT.	2017-07-14 23:40:33 -04:00
sendcoinsentry.cpp
sendcoinsentry.h
signverifymessagedialog.cpp
signverifymessagedialog.h
splashscreen.cpp	[Qt] allow to execute a callback during splashscreen progress	2017-06-29 17:48:08 +02:00
splashscreen.h	[Qt] allow to execute a callback during splashscreen progress	2017-06-29 17:48:08 +02:00
trafficgraphwidget.cpp	Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE	2017-06-13 18:05:58 -07:00
trafficgraphwidget.h
transactiondesc.cpp	scripted-diff: Remove PAIRTYPE	2017-06-05 20:14:53 +02:00
transactiondesc.h
transactiondescdialog.cpp
transactiondescdialog.h
transactionfilterproxy.cpp
transactionfilterproxy.h
transactionrecord.cpp	Merge #9964: Add const to methods that do not modify the object for which it is called	2017-08-16 02:09:49 +02:00
transactionrecord.h	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
transactiontablemodel.cpp	Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE	2017-06-13 18:05:58 -07:00
transactiontablemodel.h	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
transactionview.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
transactionview.h
utilitydialog.cpp	scripted-diff: stop using the gArgs wrappers	2017-08-14 17:02:10 +02:00
utilitydialog.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
walletframe.cpp
walletframe.h
walletmodel.cpp	Merge #11039: Avoid second mapWallet lookup	2017-08-18 16:25:59 +02:00
walletmodel.h	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
walletmodeltransaction.cpp	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
walletmodeltransaction.h	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
walletview.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
walletview.h
winshutdownmonitor.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
winshutdownmonitor.h