Suhas Daftuar
2c06bae39e
Rename "block cost" to "block weight"
9 years ago
Jonas Schnelli
7945088d41
[Wallet] comsetic non-code changes for the HD feature
9 years ago
Jonas Schnelli
68d7682b9f
[Wallet] ensure CKeyMetadata.hdMasterKeyID will be cleared during SetNull()
9 years ago
Jonas Schnelli
b993671921
[Wallet] keep HD seed during salvagewallet
9 years ago
Jonas Schnelli
986c223214
[Wallet] print hd masterkeyid in getwalletinfo
9 years ago
Jonas Schnelli
5b95dd2c25
[Wallet] extend CKeyMetadata with HD keypath
9 years ago
MarcoFalke
477777f250
[rpcwallet] Don't use floating point
9 years ago
Wladimir J. van der Laan
20f3cd75f6
wallet: Revert input selection post-pruning
...
This reverts PR #4906 , "Coinselection prunes extraneous inputs from
ApproximateBestSubset".
Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.
See also #7664 , #7657 , as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
9 years ago
Wladimir J. van der Laan
a1c92c29fd
trivial: capitalize BIP32 in option help
...
For consistency, BIP32 should be in uppercase in translation message.
Reported by @pryds on Transifex.
9 years ago
Alex Morcos
4f7ff00497
[qa] Add rpc test for segwit
...
Amended by Pieter Wuille to use multisig 1-of-1 for P2WSH tests, and BIP9
based switchover logic.
Fixes and py3 conversion by Marco Falke.
9 years ago
Pieter Wuille
f4691ab3a9
[RPC] Add wallet support for witness transactions (using P2SH)
...
Includes support for pushkeyhash wit v0 by Alex Morcos.
9 years ago
Pieter Wuille
605e8473a7
BIP143: Signing logic
9 years ago
Pieter Wuille
2b1f6f9ccf
BIP141: Other consensus critical limits, and BIP145
...
Includes changes by Suhas Daftuar, Luke-jr, and mruddy.
9 years ago
Pieter Wuille
7030d9eb47
BIP144: Serialization, hashes, relay (sender side)
...
Contains refactorings by Eric Lombrozo.
Contains fixup by Nicolas Dorier.
Contains cleanup of CInv::GetCommand by Alex Morcos
9 years ago
MarcoFalke
faa91b12f7
[wallet] tests: Don't use floating point
9 years ago
Jonas Schnelli
afcd77e179
Detect -usehd mismatches when wallet.dat already exists
9 years ago
Wladimir J. van der Laan
d096d22446
build: Get rid of `CLIENT_DATE`
...
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.
Continues #7732 which did this for the GUI.
9 years ago
Pieter Wuille
77f63a4fcd
Fix two warnings for comparison between signed and unsigned
9 years ago
MarcoFalke
fa7f4f577c
[rpc] fundrawtransaction feeRate: Use BTC/kB
...
Also introduce UniValueType
UniValueType is a wrapper for UniValue::VType which allows setting
a typeAny flag. This flag indicates the type does not matter.
(Used by RPCTypeCheckObj)
9 years ago
MarcoFalke
faf82e8fc8
[rpc] fundrawtransaction: Fix help text and interface
9 years ago
Patrick Strateman
152ab236ea
Improve CWallet API with new GetAccountPubkey function.
...
Remove one more caller that is passing CWalletDB.
9 years ago
Pieter Wuille
595b22e5c0
Stop treating importaddress'ed scripts as change
...
Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.
Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.
9 years ago
Patrick Strateman
9dfaa1cb70
Improve CWallet API with new AccountMove function.
9 years ago
Jonas Schnelli
c022e5b15d
[Wallet] use constant for bip32 hardened key limit
9 years ago
Jonas Schnelli
f19025106d
[Wallet] Add simplest BIP32/deterministic key generation implementation
9 years ago
Pieter Wuille
fa2637a3be
Always require OS randomness when generating secret keys
9 years ago
Patrick Strateman
380498aba4
Move BackupWallet to CWallet::BackupWallet
9 years ago
Patrick Strateman
ecb9741ec3
Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance
9 years ago
Gregory Maxwell
d87b198b73
Remove unneeded feerate param from RelayTransaction/AcceptToMemoryPool.
9 years ago
Cory Fields
34ed64a404
crypter: add tests for crypter
...
Verify that results correct (match known values), consistent (encrypt->decrypt
matches the original), and compatible with the previous openssl implementation.
Also check that failed encrypts/decrypts fail the exact same way as openssl.
9 years ago
Cory Fields
976f9ec264
crypter: add a BytesToKey clone to replace the use of openssl
...
BytesToKeySHA512AES should be functionally identical to EVP_BytesToKey, but
drops the dependency on openssl.
9 years ago
Cory Fields
9049cde4d9
crypter: hook up the new aes cbc classes
9 years ago
Cory Fields
fb96831c1f
crypter: constify encrypt/decrypt
...
This makes CCrypter easier to pass aroundf for tests
9 years ago
Cory Fields
1c391a5866
crypter: fix the stored initialization vector size
...
AES IV's are 16bytes, not 32. This was harmless but confusing.
Add WALLET_CRYPTO_IV_SIZE to make its usage explicit.
9 years ago
MarcoFalke
fa72f7d99d
[doc] Remove outdated line from listunspent RPC help, fix typo
9 years ago
Wladimir J. van der Laan
3e2c946cfd
init: Move berkeleydb version reporting to wallet
...
Move the version reporting to Wallet::Verify, before starting
verification of the wallet.
This removes the dependency of init on a specific wallet database
library.
A further, trivial step towards resolving #7965 .
9 years ago
Patrick Strateman
0fd599767d
Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteToDisk
9 years ago
Pedro Branco
0bf6f30262
Prevent multiple calls to ExtractDestination
9 years ago
Jonas Schnelli
04eaa90958
Add more clear interface for CoinControl.h regarding individual feerate
9 years ago
Jonas Schnelli
3b35e4896b
[RPC] add feerate option to fundrawtransaction
9 years ago
Wladimir J. van der Laan
b30fb42e49
test: Rename wallet.dat to wallet_test.dat
...
Indicate that the file name is not hardcoded, and a little bit of safety
so that it never nukes the main wallet.
Suggestion by Marco Falke.
9 years ago
Wladimir J. van der Laan
a25a4f5b04
wallet_ismine.h → script/ismine.h
...
Removes conditional dependency of `src/test` on wallet.
Makes multisig and P2SH tests complete without wallet built-in.
9 years ago
Wladimir J. van der Laan
f4eae2d910
test: Create test fixture for wallet
...
Removes all the `#ifdef ENABLE_WALLET` from `test_bitcoin` by
making the wallet tests use their own fixture.
9 years ago
Wladimir J. van der Laan
de39c95c24
test: move accounting_tests and rpc_wallet_tests to wallet/test
...
Move the two other wallet tests to where they belong.
9 years ago
Chris Moore
3107c475a7
fix spelling mistake
9 years ago
Chris Moore
dc0693f637
add missing newline
...
Without the newline I see "bein" where the two lines are concatenated:
Note that all inputs selected must be of standard form and P2SH scripts must *bein* the wallet using importaddress or addmultisigaddress (to calculate fees).
9 years ago
João Barbosa
f2d0944eb3
Add lockUnspents option to fundrawtransaction
9 years ago
João Barbosa
af4fe7fd12
Add change options to fundrawtransaction
9 years ago
Jonas Schnelli
9f7336b457
[Wallet] slightly refactor GetOldestKeyPoolTime()
9 years ago
Jonas Schnelli
4f7c959af1
Refactor IsRBFOptIn, avoid exception
9 years ago