9cbe8c80ba
wallet: Forbid -salvagewallet, -zapwallettxes, and -upgradewallet with multiple wallets
7 years ago
a2a5f3f0f0
wallet: Base backup filenames on original wallet filename
7 years ago
b823a4c9f6
wallet: Include actual backup filename in recovery warning message
7 years ago
84dcb45017
Bugfix: wallet: Fix warningStr, errorStr argument order
7 years ago
008c360083
Wallet: Move multiwallet sanity checks to CWallet::Verify, and do other checks on all wallets
7 years ago
0f08575be2
Wallet: Support loading multiple wallets if -wallet used more than once
7 years ago
b124cf04ea
Wallet: Replace pwalletMain with a vector of wallet pointers
7 years ago
8ad5bdef78
Merge bctest.py into bitcoin-util-test.py
...
bctest.py is only used as an import by bitcoin-util-test.py. There's no
value in keeping it as a separate module, so let's merge them into a
single module to keep building and packaging simpler.
bitcoin-test-util is importable as a module, so if any future modules
really want to import the code from bctest.py, they can import
bitcoin-test-util and call the bctest functions by name.
7 years ago
3fb81a8480
Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
7 years ago
40796e1a9d
Remove references to priority that snuck back in in 870824e9.
...
The "priority" field should be appropriately marked as a "dummy"
value and noted that it is deprecated and will likely be removed.
7 years ago
1b708f2cf3
Merge #10201 : pass Consensus::Params& to functions in validation.cpp and make them static
...
24980a3
7 years ago
24980a3e40
Make functions in validation.cpp static and pass chainparams
...
Fix bugs as per PR comment
Change bool static to static bool
7 years ago
300f8e7a82
Merge #9909 : tests: Add FindEarliestAtLeast test for edge cases
...
cf66f04
7 years ago
980deaf0b1
Merge #10252 : RPC/Mining: Restore API compatibility for prioritisetransaction
...
870824e
7 years ago
b083db617a
[trivial] Fix typo: "occurrences" (misspelled as "occurrances")
...
Typo introduced in 000391132608343c66488d62625c714814959bc9:
$ git blame src/coins.cpp | grep occurrances
00039113
7 years ago
30853e16d3
Merge #10535 : [qa] fundrawtx: Fix shutdown race
...
fa62dad
7 years ago
67700b3924
Merge #10345 : [P2P] Timeout for headers sync
...
76f7481e265200
7 years ago
16f6c98fa8
Merge #10426 : Replace bytes_serialized with bogosize
...
8b22af3
7 years ago
323a46e034
Merge #10463 : Names: BIP9 vs versionbits
...
b463bc929c0719
7 years ago
8d4dafd774
contrib/verifybinaries: allow filtering by platform
...
Downloading all the binaries of all platforms can take quite long,
especially for slow connections, which may deter people from using
this script and, therefore, to disregard security altogether.
This change introduces the new possibility of specifying the
platform along with the version number, so that only the binaries
that contain the platform name are downloaded.
7 years ago
ec1271f2be
Remove useless mapNextTx lookup in CTxMemPool::TrimToSize.
...
Prior to per-utxo CCoins, we checked that no other in-mempool tx
spent any of the given transaction's outputs, as we don't want to
uncache that entire tx in such a case. However, we now are checking
only that there exists no other mempool spends of the same output,
which should clearly be impossible after we removed the transaction
which was spending said output (barring massive mempool
inconsistency).
Thanks to @sdaftuar for the suggestion.
7 years ago
fa62dadabe
[qa] fundrawtx: Fix shutdown race
7 years ago
9a5a1d7d45
RPC/rawtransaction: createrawtransaction: Check opt_into_rbf when provided with either value
7 years ago
23b0fe34f5
bitcoin-tx: rbfoptin: Avoid touching nSequence if the value is already opting in
7 years ago
b005bf21a7
Introduce MAX_BIP125_RBF_SEQUENCE constant
7 years ago
575cde4605
[bitcoin-tx] add rbfoptin command
7 years ago
5d26244148
[Tests] extend the replace-by-fee test to cover RPC rawtx features
7 years ago
36bcab2356
RPC/Wallet: Add RBF support for fundrawtransaction
7 years ago
891c5eeec2
Wallet: Refactor FundTransaction to accept parameters via CCoinControl
7 years ago
578ec80d4f
RPC: rawtransaction: Add RBF support for createrawtransaction
7 years ago
19b3648bb5
CWalletDB: Store the update counter per wallet
7 years ago
74e8738961
Bugfix: ForceSetArg should replace entr(ies) in mapMultiArgs, not append
7 years ago
23fb9adaea
wallet: Move nAccountingEntryNumber from static/global to CWallet
7 years ago
9d15d5548d
Bugfix: wallet: Increment "update counter" when modifying account stuff
7 years ago
f28eb8020e
Bugfix: wallet: Increment "update counter" only after actually making the applicable db changes to avoid potential races
...
Also does all "update counter" access via IncrementUpdateCounter
7 years ago
76f74811c4
Add timeout for headers sync
...
At startup, we choose one peer to serve us the headers chain, until
our best header is close to caught up. Disconnect this peer if more
than 15 minutes + 1ms/expected_header passes and our best header
is still more than 1 day away from current time.
7 years ago
efee1db21a
scripted-diff: use insecure_rand256/randrange more
...
-BEGIN VERIFY SCRIPT-
sed -i "s/\<GetRandHash(/insecure_rand256(/" src/test/*_tests.cpp
sed -i "s/\<GetRand(/insecure_randrange(/" src/test/*_tests.cpp src/test/test_bitcoin.cpp
sed -i 's/\<insecure_rand() % \([0-9]\+\)/insecure_randrange(\1)/g' src/test/*_tests.cpp
-END VERIFY SCRIPT-
7 years ago
1119927df0
Add various insecure_rand wrappers for tests
7 years ago
124d13a58c
Merge test_random.h into test_bitcoin.h
7 years ago
90620d66c9
scripted-diff: Rename cuckoo tests' local rand context
...
-BEGIN VERIFY SCRIPT-
sed -i 's/insecure_rand/local_rand_ctx/g' src/test/cuckoocache_tests.cpp
-END VERIFY SCRIPT-
7 years ago
37e864eb9f
Add FastRandomContext::rand256() and ::randbytes()
...
FastRandomContext now provides all functionality that the real Rand* functions
provide.
7 years ago
8b22af3ee5
Replace bytes_serialized with bogosize
7 years ago
1238f13cf6
scripted-diff: Remove PAIRTYPE
...
-BEGIN VERIFY SCRIPT-
sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ;
-END VERIFY SCRIPT-
7 years ago
18dc3c3962
scripted-diff: Remove Q_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
7 years ago
7c00c26726
scripted-diff: Fully remove BOOST_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
7 years ago
a5410ac5ec
Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal
7 years ago
9fec4da0be
Merge #9740 : Add friendly output to dumpwallet
...
164019d9f82134#9564 (aideca)
Tree-SHA512: 913fcf18d42eebe34173f1f2519973494b1ad2d86d125ff4bf566d6c64aa501c02f8831e6f44812cd87a46916f61c6f510146af406865b31856d8336c173569f
7 years ago
bea5b00cfe
Merge #10509 : Remove xvfb configuration from travis
...
e4bc19f
7 years ago
9bb66ab660
Add RescanFromTime method and use from rpcdump
...
No change in behavior.
7 years ago
e654d61d94
Merge #10489 : build: silence gcc7's implicit fallthrough warning
...
cf390df
7 years ago
Luke Dashjr