Cory Fields
89f71c68c0
c++11: don't throw from the reverselock destructor
...
noexcept is default for destructors as of c++11. By throwing in reverselock's
destructor if it's lock has been tampered with, the likely result is
std::terminate being called. Indeed that happened before this change.
Once reverselock has taken another lock (its ctor didn't throw), it makes no
sense to try to grab or lock the parent lock. That is be broken/undefined
behavior depending on the parent lock's implementation, but it shouldn't cause
the reverselock to fail to re-lock when destroyed.
To avoid those problems, simply swap the parent lock's contents with a dummy
for the duration of the lock. That will ensure that any undefined behavior is
caught at the call-site rather than the reverse lock's destruction.
Barring a failed mutex unlock which would be indicative of a larger problem,
the destructor should now never throw.
9 years ago
Cory Fields
76ac35f36d
c++11: detect and correct for boost builds with an incompatible abi
...
This is ugly, but temporary. boost::filesystem will likely be dropped soon
after c++11 is enabled. Otherwise, we could simply roll our own copy_file. I've
fixed this at the buildsystem level for now in order to avoid mixing in
functional changes.
Explanation:
If boost (prior to 1.57) was built without c++11, it emulated scoped enums
using c++98 constructs. Unfortunately, this implementation detail leaked into
the abi. This was fixed in 1.57.
When building against that installed version using c++11, the headers pick up
on the native c++11 scoped enum support and enable it, however it will fail to
link. This can be worked around by disabling c++11 scoped enums if linking will
fail.
Add an autoconf test to determine incompatibility. At build-time, if native
enums are being used (a c++11 build), and force-disabling them causes a
successful link, we can be sure that there's an incompatibility and enable the
work-around.
9 years ago
Murch
96efcadfc0
Improved readability of sorting for coin selection.
...
Future proofing added lines
9 years ago
MarcoFalke
faf538bfdb
[trivial] Merge test cases and replace CENT with COIN
9 years ago
MarcoFalke
faf3299b73
[qt] Intro: Display required space
...
Required space depends on the user's choice:
-prune=0
-prune=<n>
9 years ago
Alex Morcos
e420a1b15e
Add sane fallback for fee estimation
...
Add new commandline option "-fallbackfee" to use when fee estimation does not have sufficient data.
9 years ago
Alex Morcos
995b9f385b
Always respect GetRequiredFee for wallet txs
9 years ago
Wladimir J. van der Laan
605c17844e
Merge pull request #7205
...
fa71669
[devtools] Use git pretty-format for year parsing (MarcoFalke)
fa24439
Bump copyright headers to 2015 (MarcoFalke)
fa6ad85
[devtools] Rewrite fix-copyright-headers.py (MarcoFalke)
9 years ago
Jonas Schnelli
aa413687de
Merge pull request #7282
...
621bd69
[Qt] fix coincontrol update issue when deleting a send coin entry (Jonas Schnelli)
9 years ago
Wladimir J. van der Laan
2078495d9c
Merge pull request #7193
...
fafd093
[wallet] Adjust pruning test (MarcoFalke)
9 years ago
Wladimir J. van der Laan
a10a7920c3
Merge pull request #7217
...
5246180
Mark blocks with too many sigops as failed (Suhas Daftuar)
9 years ago
MarcoFalke
fa3c7e644f
[wallet] Add regression test for vValue sort order
9 years ago
MarcoFalke
fada0c90b6
[travis] Fail when documentation is outdated
9 years ago
Wladimir J. van der Laan
45d13abf4e
Merge pull request #7253
...
0d59589
Bugfix: update-translations: Allow numerus translations to omit %n specifier (usually when it only has one possible value) (Luke Dashjr)
9 years ago
Wladimir J. van der Laan
49a735cba4
Merge pull request #7250
...
fa0a974
[qa] Move gen_return_txouts() to util.py (MarcoFalke)
9 years ago
Wladimir J. van der Laan
ac982a16e0
Merge pull request #7263
...
a5a0831
Double semicolon cleanup. (21E14)
9 years ago
Wladimir J. van der Laan
c173013821
Merge pull request #7274
...
fa6ce44
[debian] Update bitcoind manpage description (MarcoFalke)
fae7a36
[debian] Bump manpages and only mention -? (MarcoFalke)
9 years ago
Wladimir J. van der Laan
136abda597
qt: periodic translations pull from transifex
9 years ago
Jonas Schnelli
621bd6919f
[Qt] fix coincontrol update issue when deleting a send coin entry
9 years ago
Wladimir J. van der Laan
eb2b74526a
Merge pull request #7251
...
fa09562
[gitian] Set reference date to something more recent (MarcoFalke)
9 years ago
Jonas Schnelli
e289807e5a
Merge pull request #7255
...
6fd0a07
Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d
Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)
9 years ago
Wladimir J. van der Laan
08ab9069af
Merge pull request #7256
...
33877ed
Add note to CoinControl Dialog workaround (fanquake)
9 years ago
Wladimir J. van der Laan
d032b5b64b
Merge pull request #7276
...
7ef8f3c
Report non-mandatory script failures correctly (Pieter Wuille)
9 years ago
Peter Todd
fd836153d5
Improve CheckInputs() comment about sig verification
9 years ago
Pieter Wuille
7ef8f3c072
Report non-mandatory script failures correctly
9 years ago
MarcoFalke
fa6ce44bf9
[debian] Update bitcoind manpage description
...
Update the description to match that description in
the main bitcoin README.md
9 years ago
MarcoFalke
fae7a369cb
[debian] Bump manpages and only mention -?
...
The manpages are outdated and are very rarely updated when changes
to the code happen.
9 years ago
fanquake
6fd0a079d8
Remove hardcoded fee from CoinControl ToolTip
9 years ago
MarcoFalke
fa095622c2
[gitian] Set reference date to something more recent
9 years ago
fanquake
33877ed3b8
Add note to CoinControl Dialog workaround
9 years ago
Marcel Krüger
6cd198f380
Removed comment about IsStandard for P2SH scripts
...
Since #4365 (6259937388
) P2SH scripts do not have to be IsStandard scripts.
9 years ago
21E14
a5a0831458
Double semicolon cleanup.
9 years ago
Chris Moore
2409865e14
Reduce inefficiency of GetAccountAddress()
...
Don't scan the wallet to see if the current key has been used if we're going to make a new key anyway.
Stop scanning the wallet as soon as we see that the current key has been used.
Don't call isValid() twice on the current key.
9 years ago
MarcoFalke
fa71669452
[devtools] Use git pretty-format for year parsing
9 years ago
Luke Dashjr
5e109225ae
Combine common error strings for different options so translations can be shared and reused
9 years ago
fanquake
5fdf32de7e
Replace some instances of formatWithUnit with formatHtmlWithUnit
...
Strings in a HTML context should be using formatHtmlWithUnit.
9 years ago
Luke Dashjr
0d595894f0
Bugfix: update-translations: Allow numerus translations to omit %n specifier (usually when it only has one possible value)
9 years ago
MarcoFalke
fa0a9749eb
[qa] Move gen_return_txouts() to util.py
9 years ago
Jonas Schnelli
be9a9a3d22
Merge pull request #7214
...
fa2f4bc
qt5: Use the fixed font the system recommends (MarcoFalke)
9 years ago
Wladimir J. van der Laan
97d83739db
Merge pull request #7153
...
7632cf6
[Tests] Refactor some shared functions (Jonas Schnelli)
110ff11
[Tests] Add mempool_limit.py test (Jonas Schnelli)
9 years ago
Jonas Schnelli
a1c185be54
Merge pull request #7218
...
fa5769e
[qt] Fix misleading translation (MarcoFalke)
fa8c8d7
torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)
9 years ago
Wladimir J. van der Laan
595f93977c
Merge pull request #7213
...
37d271d
Rename OP_NOP2 to OP_CHECKLOCKTIMEVERIFY. (mb300sd)
9 years ago
Wladimir J. van der Laan
ed095f0407
Merge pull request #7226
...
9b41a5f
Add more tests to p2p-fullblocktest (Suhas Daftuar)
9 years ago
Wladimir J. van der Laan
c24337964f
Merge pull request #7062
...
901b01d
Remove GetMinRelayFee (Suhas Daftuar)
27fae34
Use fee deltas for determining mempool acceptance (Suhas Daftuar)
9ef2a25
Update replace-by-fee logic to use fee deltas (Suhas Daftuar)
eb30666
Fix mempool limiting for PrioritiseTransaction (Suhas Daftuar)
9 years ago
Tom Harding
e279038e84
Use createrawtx locktime parm in txn_clone
...
Streamlines the test and serves as a test of the createrawtransaction
locktime parameter.
9 years ago
MarcoFalke
fa33d9740c
[walletdb] Add missing LOCK() in Recover() for dummyWallet
9 years ago
MarcoFalke
fa14d99484
[qa] check if wallet or blochchain maintenance changes the balance
9 years ago
MarcoFalke
fa0765d433
[qa] Cleanup wallet.py test
...
* Remove outdated comment
* Remove unneeded 0s
* Remove semicolons
9 years ago
Suhas Daftuar
9b41a5fba2
Add more tests to p2p-fullblocktest
9 years ago
Wladimir J. van der Laan
8ea5ef1d39
Merge pull request #6980
...
e0769e1
[depends] Latest config.guess & config.sub (fanquake)
23a3c47
[depends] zeromq 4.0.7 (fanquake)
10d3c77
[depends] Fix miniupnpc compilation on osx (fanquake)
26f8ea5
[depends] native ccache 3.2.4 (fanquake)
17ad964
[depends] miniupnpc 1.9.20151026 (fanquake)
9e940fa
[depends] Boost 1.59.0 (fanquake)
9 years ago