Giel van Schijndel
82dc6426b4
Move func 'REF' from util.h to serialize.h
...
util.h doesn't use REF, serialize.h does, creating a dependency of
serialize.h on util.h, but util.h already depends on serialize.h. To
resolve this circular dependency the function 'REF' has now been moved
closer to one of its two points of use.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
Giel van Schijndel
e49b83bb12
Cleanup makefiles such that diffs to them are smaller
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
Giel van Schijndel
99860de3c9
Make some global variables less-global (static)
...
Explicitly make these global variables less-global to reduce the maximum
scope of this global state.
In my experience global variables tend to be a major source of bugs. As
such the less accessible they are the less likely they are to be the
source of a bug.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
Gavin Andresen
865ed8a1e5
Compile with DEBUG_LOCKORDER to detect inconsistent lock orderings that can cause deadlocks
13 years ago
Wladimir J. van der Laan
317c733572
add russian translation by msva
13 years ago
Gavin Andresen
c7286112ef
Remove unused ScanMessageStart function
13 years ago
Jeff Garzik
b2fd0ca1cb
src/makefile.unix: remove -DFOURWAYSSE2
...
Spotted by Venkatesh Srinivas <me@endeavour.zapto.org>
13 years ago
Wladimir J. van der Laan
8c4738d5a7
fix issue #13
13 years ago
Fabian H jr.
d0d9486f44
Updated checkpoints, maybe Tx fee should be reduced to 0.0001 from 0.0005 and maximum minimum tx should be 0.0010.
13 years ago
Gavin Andresen
eb72eae304
Don't std::advance past beginning of transactions array. Fixes #465
13 years ago
Matt Corallo
8acb491eef
Fix incorrect RPC error messages
13 years ago
Venkatesh Srinivas
25133bd74b
Use 'unsigned char' rather than 'char' for pchMessageStart.
...
Regarding https://bitcointalk.org/index.php?topic=28022.0
main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
Per discussion on the thread linked, leaving the signedness of
pchMessageStart is unsafe for values > 0x80. This patch specifies
'unsigned char' in main.cpp and net.h.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
13 years ago
Venkatesh Srinivas
7c3002bf27
Qualify make_tuple with boost:: namespace.
...
db.cpp has a number of uses of make_tuple and has 'using namespace
std' and 'using namespace boost'. Without qualifying make_tuple,
std::make_tuple is preferred, which is incorrect. This patch qualifies
make_tuple.
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
13 years ago
Venkatesh Srinivas
ec93a0e219
Test for SO_NOSIGPIPE rather than assuming all BSDs support it.
...
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
13 years ago
Gavin Andresen
9f0ac16942
Do-nothing MapPort() ifndef USE_UPNP. fixes #450
13 years ago
Matt Corallo
b2120e223a
Unify copyright notices.
...
To a variation on:
// Copyright (c) 2009-2010 Satoshi Nakamoto
// Copyright (c) 2011 The Bitcoin developers
13 years ago
Matt Corallo
2c3691d53d
Cleanup test suite output to be more useful.
13 years ago
Matt Corallo
3c8cecda1f
Add file for transaction tests.
13 years ago
Vegard Nossum
a8330e0049
Add a file for script tests
13 years ago
Vegard Nossum
5f6a654d3e
Add prototype for EvalScript() to script.h
...
This is needed for the script unit tests.
13 years ago
Vegard Nossum
e707d29dd6
Fix testing setup
...
There were some problems with the existing testing setup:
- Makefile rules for test-file compilation used CFLAGS instead of
CXXFLAGS in makefile.unix
13 years ago
Matt Corallo
02962ba848
Add missing include to serialize.h
13 years ago
Vegard Nossum
8a62fec3ee
Add missing includes to net.h
13 years ago
Vegard Nossum
437173f430
Add missing include to script.h
13 years ago
Vegard Nossum
fcedd45c3c
Add missing includes to key.h
13 years ago
Wladimir J. van der Laan
b0849613bf
QtUI code cleanup / comment improvements
13 years ago
Wladimir J. van der Laan
fb390d3505
add TODOs in parseBitcoinURL
13 years ago
Wladimir J. van der Laan
c359ac9128
allow empty/missing amounts in URL
13 years ago
Wladimir J. van der Laan
856aacf388
don't include <QDebug>
13 years ago
Wladimir J. van der Laan
db7f023417
Accept "bitcoin:" URL drops from browsers
13 years ago
Wladimir J. van der Laan
e74e8a184a
reorganize transaction model data function, and transaction tooltip
13 years ago
Wladimir J. van der Laan
d4e3cb4c03
improve sync spinner
13 years ago
Wladimir J. van der Laan
00f4f8d54c
speling fix
13 years ago
Wladimir J. van der Laan
126185aaa7
improve tooltip over transactions
13 years ago
Wladimir J. van der Laan
ffccb56914
select new address immediately after creation
13 years ago
Wladimir J. van der Laan
2351a3fc9f
minimize amount of text in status bar; show only icons, if the user wants explanation they can view the tooltip
13 years ago
Wladimir J. van der Laan
1b39201966
when clicking a transaction on the overview page, send the user to the transactions page
13 years ago
Wladimir J. van der Laan
186f3e2f0c
Clarity: change definition of "confirmed" to "counts towards balance"
13 years ago
Matt Corallo
01a509fa26
Don't listen if on TOR ( resolves #441 ).
13 years ago
Wladimir J. van der Laan
2ccd47596b
fix drawing on gtk
13 years ago
Wladimir J. van der Laan
82303fc3ca
unconfirmed amount = grey
13 years ago
Matt Corallo
918150048a
Make it clear that setting proxy requires restart to fully apply.
13 years ago
Wladimir J. van der Laan
a99ac8d3f4
show last few transactions on overview page
13 years ago
Wladimir J. van der Laan
2566b30c38
make amount field the same width as decimals field
13 years ago
Pieter Wuille
4d2ef6e5b6
avoid strAddress + validity checks
...
Avoid references to addresses using strings, and use CBitcoinAddress
as much as possible. Also added some validity checks on addresses
entered using RPC.
13 years ago
Wladimir J. van der Laan
5762295ec3
update readme and splash screen text
13 years ago
Wladimir J. van der Laan
10d680cff4
add splash screen
13 years ago
Johannes Henninger
1565698169
Identify as "Bitcoin + version number" when mapping UPnP port
...
Makes Bitcoin identify itself as "Bitcoin + version number" instead of
the nondescript "libminiupnpc" when forwarding a port via UPnP.
13 years ago
Wladimir J. van der Laan
d8f5c59a59
show n/a for mined transactions (and send to self) instead of empty field
13 years ago
Wladimir J. van der Laan
05bcf7089e
address icons
13 years ago