2016576998
Fix crash when mining with empty keypool.
...
Since the introduction of the ScriptForMining callback, the mining
functions (setgenerate and generate) crash with an assertion failure
(due to a NULL pointer script returned) if the keypool is empty. Fix
this by giving a proper error.
9 years ago
9dd793f499
TRIVIAL: Missing includes
9 years ago
1327897aee
Reformat help text of estimatefee and estimatepriority to match other help texts.
9 years ago
5496253966
add CReserveScript to allow modular script keeping/returning
...
- use one CReserveScript per mining thread
9 years ago
d0fc10a844
detach wallet from miner
9 years ago
ef5fca8b80
fix rpcmining/getblocktemplate univalue transition logic error
9 years ago
a9ac95c1bc
use const references where appropriate
9 years ago
9a8897f4ac
Remove JSON Spirit wrapper, remove JSON Spirit leftovers
...
- implement find_value() function for UniValue
- replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper
- remove JSON Spirit sources
9 years ago
3df0411ad9
remove JSON Spirit UniValue wrapper
9 years ago
6c7bee0624
expicit set UniValue type to avoid empty values
9 years ago
53b4671a9d
extend conversion to UniValue
9 years ago
15982a8b69
Convert tree to using univalue. Eliminate all json_spirit uses.
9 years ago
9be0e6837b
Be stricter in processing unrequested blocks
...
AcceptBlock will no longer process an unrequested block, unless it has not
been previously processed and has more work than chainActive.Tip()
9 years ago
da29ecbcc6
Consensus: MOVEONLY: Move CValidationState from main consensus/validation
9 years ago
59b149ff82
remove unneeded incude of wallet/db.h from rpcmining.cpp
9 years ago
27ce808fb5
tests: Error when setgenerate is used on regtest
...
Ever since #5957 there has been the problem that older RPC test cases
(as can be found plenty in open pulls) use setgenerate() on regtest,
assuming a different interpretation of the arguments. Directly
generating a number of blocks has been split off into a new method
`generate` - however using `setgenerate` with the previous arguments will
result in spawning an unreasonable number of threads, and well, simply
not work as expected without clear indication of the error.
Add an error to point the user at the right method.
10 years ago
691161d419
Consensus: Create consensus/consensus.h with some constants
10 years ago
bebe7282ff
Chainparams: Refactor: Remove redundant AllowMinDifficultyBlocks() getter
10 years ago
eb63bf86cf
Fix missing lock in submitblock
10 years ago
e8e8904dda
Chainparams: Cleanup: Delete CChainParams getters to attributes from Consensus::Params
10 years ago
48265f3cf4
Revert mining changes in #5957
...
This reverts commit e2edf95cd36b04508e370df67f1f7a
10 years ago
e2edf95cd3
Bugfix: make CreateNewBlock return pindexPrev
10 years ago
6b04508e37
Introduce separate 'generate' RPC call
10 years ago
d698ef690f
Consensus: Refactor: Decouple pow.o from chainparams.o
10 years ago
cbb2cf5522
Fix --disable-wallet build after merge of #5681
10 years ago
50c72f23ad
[Move Only] Move wallet related things to src/wallet/
...
could once be renamed from /src/wallet to /src/legacywallet.
10 years ago
e5ece053da
Rename Interval() to DifficultyAdjustmentInterval()
10 years ago
17115d0a34
fix getblocktemplate lock issue
...
getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.
10 years ago
f4b2078f72
Replace difficulty readjustment blocks with Interval()
10 years ago
4401b2d7c5
Removed main.h dependency from rpcserver.cpp
...
Rebased by @laanwj :
- update for RPC methods added since 84d13ee: setmocktime,
invalidateblock, reconsiderblock. Only the first, setmocktime, required a change,
the other two are thread safe.
10 years ago
734f85c4f0
Use arith_uint256 where necessary
...
Also add conversion from/to uint256 where needed.
10 years ago
0cc0d8d60b
Get rid of the internal miner's hashmeter
10 years ago
a15dba5dff
en: Avoid ambiguous language regarding when transactions confirm
10 years ago
f914f1a746
Added "Core" to copyright headers
...
Github-Pull: #5494
Rebased-From: 15de949bb9277e442302bdd8dee299a8d6deee60
10 years ago
7f71813919
Bugfix: prioritisetransaction: Do some basic sanity checking on txid
...
Besides giving a nicer error, this also prevents logging arbitrary data (which could have been used to exploit log readers) into debug.log
10 years ago
8a20cd3c51
prioritisetransaction RPC: Restore compatibility with existing implementations by using satoshis for fee offset rather than BTC
10 years ago
72fb3d295a
Update comments in src/rpc* to be doxygen compatible
10 years ago
60755dbf76
submitblock: Check for duplicate submissions explicitly
10 years ago
9765a50cbd
Implement BIP 23 Block Proposal
10 years ago
3dcbb9b6b4
Abstract DecodeHexBlk and BIP22ValidationResult functions out of submitblock
10 years ago
18379875bf
Optimize -regtest setgenerate block generation
...
Speed up generating blocks in regression test mode, by moving
block-creating and nonce-finding directly into the setgenerate
RPC call (instead of starting up a mining thread and waiting for
it to find a block).
This makes the forknotify RPC test three times quicker, for
example (10 seconds runtime instead of 30 seconds, assuming
the initial blockchain cache is already built).
10 years ago
e69a5873e7
RPC: submitblock: Support for returning specific rejection reasons
10 years ago
1bea2bbddc
Rename ProcessBlock to ProcessNewBlock to indicate change of behaviour, and document it
10 years ago
eda3733091
MOVEONLY: Move CFeeRate and Amount constants to amount.o
10 years ago
d29a2917ff
Rename RPC_TRANSACTION_* errors to RPC_VERIFY_* and use RPC_VERIFY_ERROR for submitblock
10 years ago
f877aaaf16
Bugfix: submitblock: Use a temporary CValidationState to determine accurately the outcome of ProcessBlock, now that it no longer does the full block validity check
10 years ago
cc97210799
Add fTestnetToBeDeprecatedFieldRPC to CChainParams
10 years ago
a372168e77
Use a typedef for monetary values
10 years ago
ec91092df8
Fixing compiler warning C4101
...
Github-Pull: #4856
10 years ago
611116d4e3
header include cleanup
...
- ensures alphabetical ordering for includes etc. in source file headers
10 years ago
Daniel Kraft