kevacoin

11091 Commits

29 Branches

232 Tags

129 MiB

Tree: d846e02372

Commit Graph

Author	SHA1	Message	Date
Cory Fields	89f71c68c0	c++11: don't throw from the reverselock destructor noexcept is default for destructors as of c++11. By throwing in reverselock's destructor if it's lock has been tampered with, the likely result is std::terminate being called. Indeed that happened before this change. Once reverselock has taken another lock (its ctor didn't throw), it makes no sense to try to grab or lock the parent lock. That is be broken/undefined behavior depending on the parent lock's implementation, but it shouldn't cause the reverselock to fail to re-lock when destroyed. To avoid those problems, simply swap the parent lock's contents with a dummy for the duration of the lock. That will ensure that any undefined behavior is caught at the call-site rather than the reverse lock's destruction. Barring a failed mutex unlock which would be indicative of a larger problem, the destructor should now never throw.	9 years ago
Casey Rodarmor	86270c8164	Replace boost::reverse_lock with our own.	9 years ago

Author

SHA1

Message

Date

Cory Fields

89f71c68c0

c++11: don't throw from the reverselock destructor

noexcept is default for destructors as of c++11. By throwing in reverselock's
destructor if it's lock has been tampered with, the likely result is
std::terminate being called. Indeed that happened before this change.

Once reverselock has taken another lock (its ctor didn't throw), it makes no
sense to try to grab or lock the parent lock. That is be broken/undefined
behavior depending on the parent lock's implementation, but it shouldn't cause
the reverselock to fail to re-lock when destroyed.

To avoid those problems, simply swap the parent lock's contents with a dummy
for the duration of the lock. That will ensure that any undefined behavior is
caught at the call-site rather than the reverse lock's destruction.

Barring a failed mutex unlock which would be indicative of a larger problem,
the destructor should now never throw.

9 years ago

Casey Rodarmor

86270c8164

Replace boost::reverse_lock with our own.

9 years ago

2 Commits (d846e0237256a4105199673d2eb90ed1dbb55b35)