Luke Dashjr
bf8a04a165
Reformat touched lines with C++11
8 years ago
Luke Dashjr
2e518e313b
Move nWalletUnlockTime to CWallet::nRelockTime, and name timed task unique per CWallet
8 years ago
Luke Dashjr
d77ad6d416
RPC: Do all wallet access through new GetWalletForJSONRPCRequest
8 years ago
Luke Dashjr
eca550f250
RPC/Wallet: Pass CWallet as pointer to helper functions
8 years ago
Cory Fields
d4ee7baef7
prevector: assert successful allocation
8 years ago
Suhas Daftuar
fe71661ae1
[doc] Update doc/bips.md for BIP90 implementation
8 years ago
Alex Morcos
ad727f4eaf
[rpc] sendrawtransaction no longer bypasses minRelayTxFee
...
The prioritisetransaction API can always be used if a transaction needs to be submitted that bypasses minRelayTxFee.
8 years ago
Alex Morcos
fe282acd76
[cleanup] Remove estimatePriority and estimateSmartPriority
...
Unused everywhere now except one test.
8 years ago
Alex Morcos
400b15147c
[debug] Change -printpriority option
...
-printpriority output is now changed to only show the fee rate and hash of transactions included in a block by the mining code.
8 years ago
Alex Morcos
272b25a6a9
[mining] Remove -blockprioritysize.
...
Remove ability of mining code to fill part of a block with transactions sorted by coin age.
8 years ago
Alex Morcos
12839cdd56
[rpc] Remove estimatepriority and estimatesmartpriority.
...
The RPC calls were already deprecated.
8 years ago
MarcoFalke
ddf58c7573
wallet: Remove sendfree
...
This removes the option from the wallet to not pay a fee on "small"
transactions which spend "old" inputs.
This code is no longer worth keeping around, as almost all miners
prefer not to include transactions which pay no fee at all.
8 years ago
Russell Yanofsky
306bd72157
Fix importmulti returning rescan errors for wrong keys
...
Bug was a missing ++i line in a new range for loop added in commit e2e2f4c
"Return errors from importmulti if complete rescans are not successful"
8 years ago
Wladimir J. van der Laan
94e5ba9ba2
Merge #9875 : tests: Fix dangling pwalletMain pointer in wallet tests
...
75a1093
tests: Fix dangling pwalletMain pointer in wallet tests (Wladimir J. van der Laan)
Tree-SHA512: 7fb6e8385fe7d542f9ecb113a08d675ca9e84907a1939b3a6ad41318fda55bc999b9bc8ffc3f56cd8610ca49d0db982d3c793df7bbcb7eb9638f4483030db6a8
8 years ago
Wladimir J. van der Laan
75a109338f
tests: Fix dangling pwalletMain pointer in wallet tests
8 years ago
Wladimir J. van der Laan
19cafc6239
test: Replace remaining sprintf with snprintf
...
Use of `sprintf` is seen as a red flag as many of its uses are insecure.
OpenBSD warns about it while compiling, and some modern platforms, e.g.
[cloudlibc from cloudabi](https://github.com/NuxiNL/cloudlibc ) don't
even provide it anymore.
Although our uses of these functions are secure, it can't hurt to
replace them anyway. There are only 3 occurences left, all in the
tests.
8 years ago
Wladimir J. van der Laan
0a177148e7
uint256: replace sprintf with HexStr and reverse-iterator
...
Instead of calling sprintf for every byte, format the hex bytes
ourselves by help of HexStr and a reverse_iterator.
8 years ago
Wladimir J. van der Laan
c7e57ce981
Merge #9839 : [qa] Make import-rescan.py watchonly check reliable
...
864890a
[qa] Make import-rescan.py watchonly check reliable (Russell Yanofsky)
Tree-SHA512: ea0e2b1d4fc8f35174c3d575fb751b428daf6ad3aa944fad4e3ddcc9195e4f17051473acabc54203b1d27cca64cf911b737ab92e986c40ef384410652e2dbea1
8 years ago
Pieter Wuille
fa89670d34
Add SHA512 tree hash to merge commits
8 years ago
Pieter Wuille
277b472fb2
Run miner_tests with fixed options
8 years ago
Pieter Wuille
48faf0bf63
Abstract out BlockAssembler options
8 years ago
Marijn Stollenga
83ac719d34
Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did).
8 years ago
Wladimir J. van der Laan
6206252e50
Merge #9847 : Extra test vector for BIP32
...
30aedcb
BIP32 extra test vector (Pieter Wuille)
8 years ago
Cory Fields
c5f008a416
don't throw std::bad_alloc when out of memory. Instead, terminate immediately
8 years ago
Wladimir J. van der Laan
f19afdbfb4
Merge #9612 : [trivial] Rephrase the definition of difficulty.
...
dc222f8
Trivial: Rephrase the definition of difficulty in the code. (Karl-Johan Alm)
8 years ago
Wladimir J. van der Laan
dd6e0d6301
Merge #9833 : Trivial: fix comments referencing AppInit2
...
ef9f495
Trivial: fix comments referencing AppInit2 (Marko Bencun)
8 years ago
Wladimir J. van der Laan
00285cece8
Merge #9840 : Update sendfrom RPC help to correct coin selection misconception
...
f81f0d0
Update sendfrom RPC help to correct coin selection misconception (Russell Yanofsky)
8 years ago
Karl-Johan Alm
dc222f8f63
Trivial: Rephrase the definition of difficulty in the code.
8 years ago
Pieter Wuille
30aedcbdb4
BIP32 extra test vector
8 years ago
Marko Bencun
ef9f495e93
Trivial: fix comments referencing AppInit2
...
It was refactored into multiple functions in
0cc8b6bc44
.
8 years ago
John Newbery
b23dcd2bf9
Fix segwit getblocktemplate test.
8 years ago
Russell Yanofsky
864890adf5
[qa] Make import-rescan.py watchonly check reliable
...
Send payments during the test from a different node than the node generating
keys to be imported, so the spending node doesn't create transactions that
inadvertently involve (spend funds from) the imported keys.
Fixes #9826
8 years ago
Russell Yanofsky
f81f0d0030
Update sendfrom RPC help to correct coin selection misconception
8 years ago
Wladimir J. van der Laan
692c9eddba
Merge #9831 : build: force a c++ standard to be specified
...
9829c54
build: force a c++ standard to be specified (Cory Fields)
8 years ago
MarcoFalke
a13a417cdc
Merge #9823 : qa: Set correct path for binaries in rpc tests
...
3333ad0
qa: Set correct path for binaries in rpc tests (MarcoFalke)
8 years ago
MarcoFalke
d6064a89ac
Merge #9577 : Fix docstrings in qa tests
...
3f95a80
Fix docstrings in qa tests (John Newbery)
8 years ago
MarcoFalke
7146d96de3
Merge #9766 : Add --exclude option to rpc-tests.py
...
c578408
Add exclude option to rpc-tests.py (John Newbery)
8 years ago
John Newbery
3f95a806b1
Fix docstrings in qa tests
...
This commit fixes the module-level docstrings for the tests and helper
modules in qa. Many of these tests were uncommented previously - this
commit ensures that every test case has at least a minimum level of
commenting.
8 years ago
Wladimir J. van der Laan
e68c266f3d
Merge #9789 : build: add --enable-werror and warn on vla's
...
205830a
build: add --enable-werror option (Cory Fields)
b602fe0
build: warn about variable length arrays (Cory Fields)
8 years ago
Wladimir J. van der Laan
1d2a57e9fd
Merge #9824 : qa: Check return code when stopping nodes
...
fa4cd2e
qa: Check return code when stopping nodes (MarcoFalke)
8 years ago
Wladimir J. van der Laan
d14555de3d
Merge #9820 : Fix pruning test broken by 2 hour manual prune window
...
874c736
Fix pruning test broken by 2 hour manual prune window (Russell Yanofsky)
8 years ago
Marko Bencun
5b528d746c
qt: clean up initialize/shutdown signals
...
- Change initializeResult(int) to initializeResult(bool) to avoid
implicit type conversion.
- Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
- Remove the argument from shutdownResult(int); it was called with a
constant argument.
8 years ago
Cory Fields
205830a37b
build: add --enable-werror option
...
This turns some compiler warnings into errors. Useful for c-i.
8 years ago
MarcoFalke
fa4cd2e998
qa: Check return code when stopping nodes
...
This includes work by jnewbery
8 years ago
John Newbery
f5aba8a3c5
Move tx version 2 standardness check to after bip68 activation
8 years ago
Russell Yanofsky
09fe346a4f
Avoid -Wshadow warnings in wallet_tests
...
Warnings introduced by commit e2e2f4c
"Return errors from importmulti if
complete rescans are not successful" and reported by Pavel Janík
<Pavel@Janik.cz> in https://github.com/bitcoin/bitcoin/pull/9773 and
https://github.com/bitcoin/bitcoin/pull/9827
wallet/test/wallet_tests.cpp: In member function ‘void wallet_tests::rescan::test_method()’:
wallet/test/wallet_tests.cpp:377:17: warning: declaration of ‘wallet’ shadows a global declaration [-Wshadow]
CWallet wallet;
8 years ago
Cory Fields
9829c54de2
build: force a c++ standard to be specified
...
Newer compilers may switch to newer standards by default. For example, gcc6
uses std=gnu++14 by default.
8 years ago
Wladimir J. van der Laan
bed5b30a56
Merge #9711 : [Trivial] Remove incorrect help message from gettxoutproof()
...
9949ebf
[Trivial] Remove incorrect help message from gettxoutproof() (John Newbery)
8 years ago
Wladimir J. van der Laan
1efc99c4dc
Merge #9819 : Remove harmless read of unusued priority estimates
...
bc8fd12
Remove harmless read of unusued priority estimates (Alex Morcos)
8 years ago
Wladimir J. van der Laan
ba7220b5e8
Merge #9773 : Return errors from importmulti if complete rescans are not successful
...
e2e2f4c
Return errors from importmulti if complete rescans are not successful (Russell Yanofsky)
8 years ago