Ivan Pustogarov
dca799e1db
Ignore getaddr messages on Outbound connections.
...
The only time when a client sends a "getaddr" message is when he
esatblishes an Outbound connection (see ProcessMessage() in
src/main.cpp). Another bitcoin client is expected to receive a
"getaddr" message only on Inbound connection. Ignoring "gettaddr"
requests on Outbound connections can resolve potential privacy issues
(and as was said such request normally do not happen anyway).
10 years ago
Wladimir J. van der Laan
fb6140b54b
Merge pull request #5721
...
cf008ac
Acquire CCheckQueue's lock to avoid race condition (Suhas Daftuar)
10 years ago
Jonas Schnelli
65f10e0ffc
fix jonasschnelli's gitian key
...
There where two keys in the keyfile and it also had a missing "-key" in the filename.
See: http://bitcoinstats.com/irc/bitcoin-dev/logs/2015/02/05#l1423162105
10 years ago
Wladimir J. van der Laan
5d901d8ece
Merge pull request #5756
...
1cb2a00
Fix getblocktemplate_proposals test by mining one block (Suhas Daftuar)
10 years ago
Wladimir J. van der Laan
f5791c6ae3
Add more information to errors in ReadBlockFromDisk
...
A lot of times, disk corruption problems appear here.
To facilitate debugging and troubleshooting, add position information
to the error messages.
10 years ago
Jonas Schnelli
d67a642392
[Qt] add bitcoin logo to about screen
10 years ago
Suhas Daftuar
1cb2a00cb8
Fix getblocktemplate_proposals test by mining one block
...
This triggers the tested node to no longer be in initial
download, allowing the call to getblocktemplate() to succeed.
10 years ago
Wladimir J. van der Laan
1c4e3f99f0
Merge pull request #5754
...
17115d0
fix getblocktemplate lock issue (Jonas Schnelli)
10 years ago
Jonas Schnelli
17115d0a34
fix getblocktemplate lock issue
...
getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.
10 years ago
Philip Kaufmann
25cf6f3d41
minor rework of SendMoney in rpcwallet
...
- rework the function to not log errors but use throw JSONRPCError
- remove a check for IsLocked() that is done in sendtoaddress and
sendfrom RPC calls already
- cache GetBalance() return value, because it's possibly used twice
10 years ago
Wladimir J. van der Laan
93b7544501
Merge pull request #5319
...
35f7227
Clean up wallet encryption code. (Daniel Kraft)
10 years ago
Philip Kaufmann
a6516686dc
[Qt] prevent amount overflow problem with payment requests
...
Bitcoin amounts are stored as uint64 in the protobuf messages (see
paymentrequest.proto), but CAmount is defined as int64_t. Because
of that we need to verify that single and accumulated amounts are
in a valid range and no variable overflow has happened.
- fixes #5624 (#5622 )
Thanks @SergioDemianLerner for reporting that issue and also supplying us
with a possible solution.
- add static verifyAmount() function to PaymentServer and move the logging
on error into the function
- also add a unit test to paymentservertests.cpp
10 years ago
Wladimir J. van der Laan
31dedb463b
Merge pull request #5509
...
7f991e3
c++11: These look like user-defined literals. (Cory Fields)
5a6155c
c++11: don't forward-declare types used in maps (Cory Fields)
3447cf8
c++11: MOVEONLY: break circular dependency in wallet (Cory Fields)
bbacd88
c++11: MOVEONLY: move function definitions out of the header (Cory Fields)
a2b04dd
build: fix newer boost build with c++11 (Cory Fields)
10 years ago
Wladimir J. van der Laan
87ecfb0f96
Merge pull request #5711
...
5ebe095
Trim RPC command table (Wladimir J. van der Laan)
4401b2d
Removed main.h dependency from rpcserver.cpp (Eric Lombrozo)
10 years ago
Cory Fields
7f991e364e
c++11: These look like user-defined literals.
...
Add a space to keep the compiler happy
10 years ago
Cory Fields
5a6155ccfa
c++11: don't forward-declare types used in maps
10 years ago
Cory Fields
3447cf87e2
c++11: MOVEONLY: break circular dependency in wallet
...
c++11 (libc++'s stdlib implementation anyway) doesn't allow for map types to be
forward-declared. for example:
class foo;
std::map<int, foo> bar; // error, foo has not been defined.
class foo{};
Since CWallet and CWalletTx are inter-dependent, but only std::map<*,CWalletTx>
is used, forward-declare CWallet instead and define CWalletTx first.
Despite the mangled git diff, this change only amounts to moving ~320 lines in
a single chunk.
10 years ago
Cory Fields
bbacd88204
c++11: MOVEONLY: move function definitions out of the header
...
These need to be moved out of the header in order to resolve a circular
dependency between CWallet and CTxWallet. See next commit.
10 years ago
Cory Fields
a2b04ddfe6
build: fix newer boost build with c++11
10 years ago
Daniel Kraft
eb1c2cd37f
Split logic to undo txin's off DisconnectBlock.
...
Instead, create a separate function that applies the undo operation of a
CTxInUndo object onto a CCoinsViewCache. This method is used from
DisconnectBlock.
10 years ago
Suhas Daftuar
cf008ac8c3
Acquire CCheckQueue's lock to avoid race condition
...
This fixes a potential race condition in the CCheckQueueControl constructor,
which was looking directly at data in CCheckQueue without acquiring its lock.
Remove the now-unnecessary friendship for CCheckQueueControl
10 years ago
Wladimir J. van der Laan
fcf646c9b0
Merge pull request #5286
...
44e9a6b
Update the 'test_IsStandard' unit test (Flavien Charlon)
a930658
Change the default maximum OP_RETURN size to 80 bytes (Flavien Charlon)
10 years ago
Wladimir J. van der Laan
e5f1f5a263
Merge pull request #5732
...
1371e6f
Change "insane" to "absurd" (referring to high fees) in text strings and identifiers. (Daira Hopwood)
10 years ago
Wladimir J. van der Laan
6ee87f9bc5
Merge pull request #5647
...
3ff735c
Increase block download timeout base from 10 to 20 minutes. (Gregory Maxwell)
10 years ago
Wladimir J. van der Laan
4e2b1fff98
Merge pull request #5675
...
2d9b0b7
Fix priority calculation in CreateTransaction (Alex Morcos)
10 years ago
Wladimir J. van der Laan
41e6e4caba
Merge pull request #5713
...
bf6cdeb
Increase coverage of DERSIG edge cases (Pieter Wuille)
819bcf9
Add RPC test for DERSIG BIP switchover logic (Pieter Wuille)
5a47811
BIP66 changeover logic (Pieter Wuille)
092e9fe
Example unit tests from BIP66 (Pieter Wuille)
80ad135
Change IsDERSignature to BIP66 implementation (Pieter Wuille)
10 years ago
Wladimir J. van der Laan
9c4a5a5067
Merge pull request #5729
...
fdf80ea
[Qt] allow unit changes for read-only BitcoinAmountField (Philip Kaufmann)
10 years ago
Wladimir J. van der Laan
f425050546
Merge pull request #5719
...
9fddced
Avoid storing a reference passed to SignatureChecker constructors (Pieter Wuille)
858809a
Use separate SignatureChecker for CMutableTransaction (Pieter Wuille)
10 years ago
Pieter Wuille
9fddceda44
Avoid storing a reference passed to SignatureChecker constructors
10 years ago
Pieter Wuille
858809a33e
Use separate SignatureChecker for CMutableTransaction
10 years ago
Shaul Kfir
f4b2078f72
Replace difficulty readjustment blocks with Interval()
10 years ago
Wladimir J. van der Laan
a62649731f
Merge pull request #5731
...
ee93202
Changed pronouns for correctness and inclusivity (bikinibabe)
1fa89a5
fix _code_ snippet in gitian-building.md (UdjinM6)
34c6181
Fix README link from util.sh -> util.py. (Matt Bogosian)
faf0af4
Suggest --disable-wallet when libdb_cxx headers are missing (Luke Dashjr)
5a809ef
depends: fix typos (Michael Ford)
bd2b73b
TRIVIAL: fix misleading comment (Vitalii Demianets)
5262fde
Remove whitespaces before double colon in errors and logs (Pavel Janík)
3800135
Fix typo (Pavel Janík)
91a9fe0
Fix typo - sentence starts with capital letter (Pavel Janík)
bfc29dc
Improve gitian build guide (Michael Ford)
d6bed15
remove sig_canonical.json and sig_noncanonical.json (Manuel Araoz)
8673160
Remove bootstrap.md (Michael Ford)
10 years ago
Pieter Wuille
bf6cdebdc5
Increase coverage of DERSIG edge cases
10 years ago
Pieter Wuille
819bcf9b99
Add RPC test for DERSIG BIP switchover logic
10 years ago
Pieter Wuille
5a47811da5
BIP66 changeover logic
10 years ago
Pieter Wuille
092e9fe5fb
Example unit tests from BIP66
10 years ago
Pieter Wuille
80ad135a5e
Change IsDERSignature to BIP66 implementation
10 years ago
Daira Hopwood
1371e6f5db
Change "insane" to "absurd" (referring to high fees) in text strings and identifiers.
...
Note that this will also require translation changes in Transifex for the key
"A fee higher than %1 is considered an insanely high fee." which is now
"A fee higher than %1 is considered an absurdly high fee."
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
10 years ago
bikinibabe
ee932025c1
Changed pronouns for correctness and inclusivity
10 years ago
UdjinM6
1fa89a54e8
fix _code_ snippet in gitian-building.md
...
Trivial typo-like fix
10 years ago
Matt Bogosian
34c61813a4
Fix README link from util.sh -> util.py.
10 years ago
Luke Dashjr
faf0af49f5
Suggest --disable-wallet when libdb_cxx headers are missing
10 years ago
Michael Ford
5a809ef0f0
depends: fix typos
10 years ago
Vitalii Demianets
bd2b73bb9b
TRIVIAL: fix misleading comment
10 years ago
Pavel Janík
5262fde0ec
Remove whitespaces before double colon in errors and logs
10 years ago
Pavel Janík
3800135ad3
Fix typo
10 years ago
Pavel Janík
91a9fe094b
Fix typo - sentence starts with capital letter
10 years ago
Michael Ford
bfc29dcdc5
Improve gitian build guide
...
Point to the Debian 7.7 installer
Fix wording now that we only use a single image
Remove bitcoin checkout steps, they are covered in release-process
10 years ago
Manuel Araoz
d6bed1514c
remove sig_canonical.json and sig_noncanonical.json
10 years ago
Michael Ford
86731603d4
Remove bootstrap.md
...
See #5455
10 years ago