e707d29dd6
Fix testing setup
...
There were some problems with the existing testing setup:
- Makefile rules for test-file compilation used CFLAGS instead of
CXXFLAGS in makefile.unix
13 years ago
02962ba848
Add missing include to serialize.h
13 years ago
8a62fec3ee
Add missing includes to net.h
13 years ago
437173f430
Add missing include to script.h
13 years ago
fcedd45c3c
Add missing includes to key.h
13 years ago
01a509fa26
Don't listen if on TOR ( resolves #441 ).
13 years ago
918150048a
Make it clear that setting proxy requires restart to fully apply.
13 years ago
4d2ef6e5b6
avoid strAddress + validity checks
...
Avoid references to addresses using strings, and use CBitcoinAddress
as much as possible. Also added some validity checks on addresses
entered using RPC.
13 years ago
1565698169
Identify as "Bitcoin + version number" when mapping UPnP port
...
Makes Bitcoin identify itself as "Bitcoin + version number" instead of
the nondescript "libminiupnpc" when forwarding a port via UPnP.
13 years ago
33208fb557
Check for duplicate txins in CheckTransaction.
13 years ago
8c2143d4d8
Comment "deprecated"
13 years ago
687c82558c
Fix EncryptKeys crash introduced by a9ba4710, identified by TD.
13 years ago
a139ed74f2
CAddrDB::LoadAddresses: properly initialize CAddress
...
Fixes issue #424
13 years ago
b63241d451
Bugfix: don't overuse limited ExtractAddress
...
ExtractAddress was called with the keystore as argument in RPC and
UI, limiting results to own keys. This caused empty "address"
fields.
13 years ago
690c723e5f
make SetHash160 return a value (as specified in the function signature)
13 years ago
67ed7d9d49
Fix UNIX-specific thread handle leak.
13 years ago
a7dd11c6da
Fix for small change outputs
...
With the separation of CENT and MIN_TX_FEE, it is now reasonable
to create change outputs between 0.01 and 0.0005, as these are
spendable according to the policy, even though they require a fee
to be paid.
Also, when enough fee was already present, everything can go into
a change output, without further increasing the fee.
13 years ago
643160f6e7
Actually use mapAlreadyAskedFor.
...
Previously, mapAlreadyAskedFor was read from, but never added to.
The original intent was to use mapAlreadyAskedFor to keep track
of the time an item was requested and "Each retry is 2 minutes
after the last".
This implements that intent.
13 years ago
03f8b54565
Fix bug with accessing vchData[0] when vchData is empty.
...
Fix typo in CBase58Data::CompareTo
13 years ago
cb61b8dc4c
split off CBase58Data from CBitcoinAddress
...
Split off features unrelated to addresses from CBitcoinAddress to
CBase58Data, so they can be reused.
13 years ago
2ffba736e9
Use CBitcoinAddress instead of string/uint160
...
Instead of conversion functions between pubkey/uint160/address in
base58.h, have a fully fledged class CBitcoinAddress (CAddress was
already taken) to represent addresses.
13 years ago
03fbd79049
get rid of mapPubKeys
...
Make CKeyStore's interface work on uint160's instead of pubkeys, so
no separate global mapPubKeys is necessary anymore.
13 years ago
88cab1e4a3
Added crypter to makefile.vc.
13 years ago
3a10d1c493
Fix bad return values in LoadWallet.
13 years ago
d655a26c9d
Single DB transaction for addresses from DNS seeds
13 years ago
a2606bad09
Fix Build in GetReservedKey() in wallet.cpp
13 years ago
8c41469140
Single DB transaction for all addresses in a message
...
Cuts disk activity at startup immensely
13 years ago
cee69980b0
Generate Warning when using default key.
13 years ago
0d7b28e52e
Fix crashes when a wallet is locked and GetReservedKey() is called
13 years ago
84c3c2ebe7
fix warning: control reaches end of non-void function [-Wreturn-type]
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
93752b8a39
fix warning: variable ‘nMinDepth’ set but not used [-Wunused-but-set-variable]
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
d5e9d0000d
Fix makefile.linux-mingw
13 years ago
d5115a71a1
Bugfix: add autogenerated addresses to address book
13 years ago
24a0def8cd
Bump version to 0.3.25
...
Yes, we might release as v0.4, but let's just do a simple increment
for now.
13 years ago
116df55e21
Update CWallet::LoadWallet for proper return type.
13 years ago
d0538a81bb
fix warning: unused function 'SigIllHandlerSSE2' [-Wunused-function]
...
Only declare & define SigIllHandlerSSE2 when its used.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
858cebed7d
fix warning: unused variable 'X' [-Wunused-variable]
...
Remove several unused variables.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
225f222c9f
fix warning: X enumeration values not handled in switch [-Wswitch-enum]
...
Add default cases to opcode switches to assert that they should never
occur.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
d7f1d200ab
fix warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
...
Don't check for a negative parameter count, because not only will it
never happen, it doesn't make any sense either.
Invalid sockets (as returned by socket(2)) are always exactly -1 (not
just negative as negative file descriptors are technically not
prohibited by POSIX) on POSIX systems. Since we store them in SOCKET
(unsigned int), however, that really is ~0U (or MAX_UINT) which happens
to be what INVALID_SOCKET is already defined to, so an additional check
for being negative is not only unnecessary (unsigned integers aren't
*ever* negative) its redundant as well (the INVALID_SOCKET comparison is
enough).
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
f85c097449
fix warnings: using the result of an assignment as a condition without parentheses [-Wparentheses]
...
Don't unnecessarily assign to variables within the *boolean* expression
of a conditional.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
ecf1c79aad
fix warnings: expression result unused [-Wunused-value]
...
In the assert()s take advantage of the fact that string constants
("string") are effectively of type 'const char []', which when used in
an expression yield a non-NULL pointer.
An assertion that should always fail can thus be formulated as:
assert(!"fail);
An assertion where a text message should be added to the expression can
be written as such:
assert("message" && expression);
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
df40181417
fix warning on 64bit systems: cast to pointer from integer of different size [-Wint-to-pointer-cast]
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
0ca8324f59
Update makefile.linux-mingw to work with crypter and UPnP fix.
13 years ago
7414733bea
Make an invalid addrIncoming so that old clients crash.
...
This prevents old clients from opening, and thus corrupting
or otherwise causing harm to encrypted wallets.
13 years ago
96f34cd5c4
Use DB Transactions when encrypting wallet.
...
This speeds up the encryption process significantly.
13 years ago
0efda1a79e
Do not use obsolete CPrivKey for passing keys around
13 years ago
fbeb5fb483
Add the walletlock RPC method to lock the wallet manually.
13 years ago
81598083e7
Dynamically remove/insert the Options for encryption in the menus.
13 years ago
98545d2cdf
Push unlocked_until in getinfo.
13 years ago
ddebdd9a8f
Set the number of SHA512 rounds based on the speed of the computer.
13 years ago
Vegard Nossum