Russell Yanofsky
a1fe9446e9
Remove reference to nonexistent "version" wallet transaction mapvalue field
...
This change removes a mapValue.erase("version") statement which deletes a
mapValue entry that never existed. The statement was mistakenly added in commit
865c3a2383
in 2010 and is harmless but confusing.
8 years ago
Russell Yanofsky
654e0443fb
[trivial] Add comment documenting CWalletTx::mapValue
8 years ago
Pieter Wuille
c3f5673a63
Make CWalletTx store a CTransactionRef instead of inheriting
8 years ago
Jonas Schnelli
f7345050e9
Make strWalletFile const
8 years ago
Pieter Wuille
528472111b
Get rid of nType and nVersion
...
Remove the nType and nVersion as parameters to all serialization methods
and functions. There is only one place where it's read and has an impact
(in CAddress), and even there it does not impact any of the recursively
invoked serializers.
Instead, the few places that need nType or nVersion are changed to read
it directly from the stream object, through GetType() and GetVersion()
methods which are added to all stream classes.
8 years ago
Pieter Wuille
2ca882ad41
Declare wallet.h functions inline
8 years ago
Wladimir J. van der Laan
0fdf810d26
wallet: Change default confirm target from 2 to 6
...
Recent discussion (in IRC meetings, and e.g. #8989 ) has shown a
preference for the default confirm target for smartfees to be 6 instead
of 2, to avoid overpaying fees for questionable gain.
6 is also a compromise between the GUI's pre-#8989 value of 25 and the
bitcoind `-txconfirmtarget` default of 2. These were unified in #8989 ,
but this has made the (overly expensive) default of 2 as GUI default.
8 years ago
instagibbs
169bdabe14
Return useful error message on ATMP failure
8 years ago
Jonas Schnelli
cab1da745b
[Wallet] Refactor wallet/init interaction (Reaccept wtx, flush thread)
8 years ago
Patrick Strateman
e198c521d3
Move key derivation logic from GenerateNewKey to DeriveNewChildKey
8 years ago
MarcoFalke
fa58edbffe
[wallet] Introduce DEFAULT_DISABLE_WALLET
8 years ago
Patrick Strateman
02e2a81536
Remove pwalletdb parameter from CWallet::AddAccountingEntry
8 years ago
Patrick Strateman
d2e678d7d2
Add CWallet::ReorderTransactions and use in accounting_tests.cpp
8 years ago
Patrick Strateman
59adc86680
Add CWallet::ListAccountCreditDebit
...
Simple pass through for CWalletDB::ListAccountCreditDebit
8 years ago
Wladimir J. van der Laan
86726d8680
Rename `-optintofullrbf` option to `-walletrbf`
...
This makes it clear that this is a wallet option.
8 years ago
Pavel Janík
64d9507ea5
[WIP] Remove unused statement in serialization
8 years ago
Cory Fields
5b446dd5b1
net: Pass CConnection to wallet rather than using the global
8 years ago
Peter Todd
152f45ba58
Add option to opt into full-RBF when sending funds
8 years ago
MarcoFalke
fa28bfa341
[wallet] Set fLimitFree = true
8 years ago
Jonas Schnelli
914154f0cc
[Qt] add HD enabled/disabled icon to the status bar
8 years ago
Patrick Strateman
e86eb71604
Move CWallet::setKeyPool to private section of CWallet
8 years ago
Jonas Schnelli
b3b3c2a562
Reduce cs_main locks during ConnectTip/SyncWithWallets
8 years ago
Patrick Strateman
29c2d99bc9
Make CWallet::fFileBacked private.
8 years ago
Patrick Strateman
867f842f1e
Remove CWalletDB* parameter from CWallet::AddToWallet
8 years ago
Patrick Strateman
00f09c920c
Split CWallet::AddToWallet into AddToWallet and LoadToWallet.
...
This removes the fFromLoadWallet flag in AddToWallet. These were already
effectively two methods.
8 years ago
Jonas Schnelli
2266b43e33
Port from 0.13: Create a new HD seed after encrypting the wallet
...
Forward-ports two commits from 0.13:
- [0.13] Create a new HD seed after encrypting the wallet
- [Wallet] Add CKeyMetadata record for HDMasterKey(s), factor out HD key generation
Github-Pull: #8389
Rebased-From: f142c11ac6
de45c065f0
8 years ago
Jonas Schnelli
77c912d21c
[Wallet] add HD xpriv to dumpwallet
8 years ago
Jonas Schnelli
a4f137f367
[Wallet] Ensure <0.13 clients can't open HD wallets
8 years ago
Jonas Schnelli
7945088d41
[Wallet] comsetic non-code changes for the HD feature
9 years ago
Jonas Schnelli
986c223214
[Wallet] print hd masterkeyid in getwalletinfo
9 years ago
Patrick Strateman
152ab236ea
Improve CWallet API with new GetAccountPubkey function.
...
Remove one more caller that is passing CWalletDB.
9 years ago
Patrick Strateman
9dfaa1cb70
Improve CWallet API with new AccountMove function.
9 years ago
Jonas Schnelli
f19025106d
[Wallet] Add simplest BIP32/deterministic key generation implementation
9 years ago
Patrick Strateman
380498aba4
Move BackupWallet to CWallet::BackupWallet
9 years ago
Patrick Strateman
ecb9741ec3
Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance
9 years ago
Patrick Strateman
0fd599767d
Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteToDisk
9 years ago
Jonas Schnelli
04eaa90958
Add more clear interface for CoinControl.h regarding individual feerate
9 years ago
Jonas Schnelli
3b35e4896b
[RPC] add feerate option to fundrawtransaction
9 years ago
Wladimir J. van der Laan
a25a4f5b04
wallet_ismine.h → script/ismine.h
...
Removes conditional dependency of `src/test` on wallet.
Makes multisig and P2SH tests complete without wallet built-in.
9 years ago
João Barbosa
f2d0944eb3
Add lockUnspents option to fundrawtransaction
9 years ago
João Barbosa
af4fe7fd12
Add change options to fundrawtransaction
9 years ago
MarcoFalke
fada0c422c
[doc] Fix doxygen comments for members
9 years ago
instagibbs
f1bb13c93d
Added companion removeprunedfunds call.
9 years ago
João Barbosa
bb16c8894b
Prevent multiple calls to CWallet::AvailableCoins
9 years ago
Jonas Schnelli
25340b7cd5
[Wallet] refactor wallet/init interaction
9 years ago
Pieter Wuille
c3932b3270
List solvability in listunspent output and improve help
9 years ago
Jonas Schnelli
fc7c60d699
[Wallet] move "load wallet phase" to CWallet
9 years ago
Jonas Schnelli
72c2651581
[Wallet] move wallet help string creation to CWallet
9 years ago
MarcoFalke
fad6244879
ATMP: make nAbsurdFee const
9 years ago
MarcoFalke
fa762d0f00
[wallet.h] Remove main.h include
9 years ago