kevacoin

12952 Commits

29 Branches

232 Tags

129 MiB

Tree: 8be0866883

Commit Graph

Author	SHA1	Message	Date
Russell Yanofsky	8be0866883	[qa] Simplify import-rescan.py Get rid of partial functions so the test can be more easily extended to add more variants of imports with options that affect rescanning (e.g. different key timestamps). Also change the second half of the test to send /to/ the imported addresses, instead of /from/ the imported addresses. The goal of this part of the test was to confirm that the wallet would pick up new transactions after an import regardless of whether or not a rescan happened during the import. But because the wallet can only do this reliably for incoming transactions and not outgoing transactions (which require the wallet to look up transaction inputs) the test previously was less meaningful than it should have been.	8 years ago
Russell Yanofsky	442887f27f	Require timestamps for importmulti keys Additionally, accept a "now" timestamp, to allow avoiding rescans for keys which are known never to have been used. Note that the behavior when "now" is specified is slightly different than the previous behavior when no timestamp was specified at all. Previously, when no timestamp was specified, it would avoid rescanning during the importmulti call, but set the key's nCreateTime value to 1, which would not prevent future block reads in later ScanForWalletTransactions calls. With this change, passing a "now" timestamp will set the key's nCreateTime to the current block time instead of 1. Fixes #9491	8 years ago
Russell Yanofsky	d8c0b9f525	[qa] Add test for rescan feature of wallet key import RPCs Covers importaddress, importpubkey, importprivkey, and importmulti RPCs.	8 years ago

Author

SHA1

Message

Date

Russell Yanofsky

8be0866883

[qa] Simplify import-rescan.py

Get rid of partial functions so the test can be more easily extended to add
more variants of imports with options that affect rescanning (e.g. different
key timestamps).

Also change the second half of the test to send /to/ the imported addresses,
instead of /from/ the imported addresses. The goal of this part of the test was
to confirm that the wallet would pick up new transactions after an import
regardless of whether or not a rescan happened during the import. But because
the wallet can only do this reliably for incoming transactions and not outgoing
transactions (which require the wallet to look up transaction inputs) the test
previously was less meaningful than it should have been.

8 years ago

Russell Yanofsky

442887f27f

Require timestamps for importmulti keys

Additionally, accept a "now" timestamp, to allow avoiding rescans for keys
which are known never to have been used.

Note that the behavior when "now" is specified is slightly different than the
previous behavior when no timestamp was specified at all. Previously, when no
timestamp was specified, it would avoid rescanning during the importmulti call,
but set the key's nCreateTime value to 1, which would not prevent future block
reads in later ScanForWalletTransactions calls. With this change, passing a
"now" timestamp will set the key's nCreateTime to the current block time
instead of 1.

Fixes #9491

8 years ago

Russell Yanofsky

d8c0b9f525

[qa] Add test for rescan feature of wallet key import RPCs

Covers importaddress, importpubkey, importprivkey, and importmulti RPCs.

8 years ago

3 Commits (8be0866883ff4efec9182194e900a05742e1b322)