80175472d1
Make CBlockIndex*es in net_processing const
8 years ago
b50cd7a67e
Fix dangerous condition in ModifyNewCoins.
...
We were marking coins FRESH before being sure they were not overwriting dirty undo data. This condition was never reached in existing code because undo data was always flushed before UpdateCoins was called with new transactions, but could have been exposed in an otherwise safe refactor.
Clarify in the comments the assumptions made in ModifyNewCoins.
Add ability to undo transactions to UpdateCoins unit test.
Thanks to Russ Yanofsky for suggestion on how to make logic clearer and fixing up the ccoins_modify_new test cases.
8 years ago
388ea19bf2
qt: Set (count) placeholder in sendcoinsdialog to notranslate
8 years ago
facf3e7608
[qt] `make translate`
8 years ago
fae26e8dfc
[qt] Add more sources to translate
8 years ago
67ee4ec901
net: misc header cleanups
8 years ago
8b3159ef0a
net: make proxy receives interruptible
8 years ago
5cb0fcee81
net: remove thread_interrupted catch
...
This is now a std::thread, so there's no hope of catching a boost interruption
point.
8 years ago
d3d7056d2a
net: make net processing interruptible
8 years ago
0985052319
net: make net interruptible
...
Also now that net threads are interruptible, switch them to use std
threads/binds/mutexes/condvars.
8 years ago
799df9115f
net: add CThreadInterrupt and InterruptibleSleep
8 years ago
7325b15566
net: a few small cleanups before replacing boost threads
...
- Drop the interruption point directly after the pnode allocation. This would
be leaky if hit.
- Rearrange thread creation so that the socket handler comes first
8 years ago
fab6c5f46b
[qt] Do not translate `~`
8 years ago
d45b21e2b3
qt: Fill in English numerusforms
...
minute/minutes block/blocks and so forth.
8 years ago
a9d6151802
qt,wallet: Fix a few typos in messages
...
As reported by [yahoe.001](https://www.transifex.com/user/profile/yahoe.001/ ).
8 years ago
1d2d67692c
qt: Set transifex slug to 0.14
...
Also perform update of source translations.
8 years ago
27765b6403
Increment MIT Licence copyright header year on files modified in 2016
...
Edited via:
$ contrib/devtools/copyright_header.py update .
8 years ago
9e351c9586
SetMerkleBranch: remove unused code, remove cs_main lock requirement
8 years ago
8562792095
GUI/RPCConsole: Include importmulti in history sensitive-command filter
8 years ago
ff77faf480
Qt/RPCConsole: Use RPCParseCommandLine to perform command filtering
8 years ago
a79598ddf4
Qt/Test: Make sure filtering sensitive data works correctly in nested commands
8 years ago
629cd42364
Qt/RPCConsole: Teach RPCParseCommandLine how to filter out arguments to sensitive commands
8 years ago
e2d9213c32
Qt/RPCConsole: Make it possible to parse a command without executing it
8 years ago
1755c04576
Qt/RPCConsole: Truncate filtered commands to just the command name, rather than skip it entirely in history
8 years ago
d80a00660f
Qt/RPCConsole: Add signmessagewithprivkey to list of commands filtered from history
8 years ago
afde12f265
Qt/RPCConsole: Refactor command_may_contain_sensitive_data function out of RPCConsole::on_lineEdit_returnPressed
8 years ago
de8980df9d
Bugfix: Do not add sensitive information to history for real
...
Original code was missing braces, and short-circuited before checking everything after importprivkey
8 years ago
9044908636
Qt/RPCConsole: Don't store commands with potentially sensitive information in the history
...
Filters importprivkey, signrawtransaction, walletpassphrase, walletpassphrasechange, and encryptwallet
8 years ago
fc95daa97f
Qt/RPCConsole: Save current command entry when browsing history
...
Shell-like, but doesn't store changed history commands until executing it.
8 years ago
fa558be2c1
test: Include tx data in EXTRA_DIST
8 years ago
c2f61bebb1
Add a ForceSetArg method for testing
8 years ago
35356b40ef
Remove unused variable in test, fixing warning.
...
Pointed out by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9308 .
8 years ago
bd02bddb93
Release cs_main before processing cmpctblock as header
8 years ago
680b0c0138
Release cs_main before calling ProcessNewBlock (cmpctblock handling)
8 years ago
4e048142a5
Lock mapArgs/mapMultiArgs access in util
8 years ago
4cd373aea8
Un-expose mapArgs from utils.h
8 years ago
71fde5563b
Get rid of mapArgs direct access in ZMQ construction
8 years ago
0cf86a6678
Introduce (and use) an IsArgSet accessor method
8 years ago
2b5f085ad1
Fix non-const mapMultiArgs[] access after init.
...
Swap mapMultiArgs for a const-reference to a _mapMultiArgs which is
only accessed in util.cpp
8 years ago
c8042a48f0
Remove arguments to ParseConfigFile
8 years ago
3f67972654
updated listsinceblock rpc docs
...
fixes #8758
8 years ago
afe5b3f553
Added missing colons in when running help command
8 years ago
2ddfcfd2d6
Make CScript (and prevector) c++11 movable.
...
Such moves are used when reallocating vectors that contain them,
for example.
8 years ago
91335ba389
Remove unused MakeTransactionRef overloads
8 years ago
6713f0f142
Make FillBlock consume txn_available to avoid shared_ptr copies
8 years ago
62607d796c
Convert COrphanTx to keep a CTransactionRef
8 years ago
c44e4c467c
Make AcceptToMemoryPool take CTransactionRef
8 years ago
b3717326c1
Re-enable a blank v1 Tx JSON test
8 years ago
0513c707aa
Make rpcauth help message clearer, add example in example .conf
8 years ago
fa89581860
build: Include cuckoocache header in Makefile
8 years ago
Matt Corallo