734f85c4f0
Use arith_uint256 where necessary
...
Also add conversion from/to uint256 where needed.
10 years ago
34cdc41128
String conversions uint256 -> uint256S
...
If uint256() constructor takes a string, uint256(0) will become
dangerous when uint256 does not take integers anymore (it will go
through std::string(const char*) making a NULL string, and the explicit
keyword is no help).
10 years ago
2eae3157f6
Replace uint256(1) with static constant
...
SignatureHash and its test function SignatureHashOld
return uint256(1) as a special error signaling value.
Return a local static constant with the same value instead.
10 years ago
807658549c
Replace GetLow64 with GetCheapHash
10 years ago
4f1524966a
Replace direct use of 0 with SetNull and IsNull
...
Replace x=0 with .SetNull(),
x==0 with IsNull(), x!=0 with !IsNull().
Replace uses of uint256(0) with uint256().
10 years ago
5d3064bc44
Temporarily add SetNull/IsNull/GetCheapHash to base_uint
...
Also add a stub for arith_uint256 and its conversion functions,
for now completely based on uint256.
Eases step-by-step migration to blob.
10 years ago
0cc0d8d60b
Get rid of the internal miner's hashmeter
10 years ago
0ea28baeb8
Reject non-final txs even in testnet/regtest
...
Previous behavior with IsFinalTx() being an IsStandard() rule was rather
confusing and interferred with testing of protocols that depended on
nLockTime.
10 years ago
e41345790f
Catch LevelDB errors during flush
10 years ago
02bced1661
Bugfix: only track UTXO modification after lookup
...
Otherwise, if CCoinsViewCache::ModifyCoins throws an exception in between
setting hasModifier and constructing the CCoinsModifier, the cache ends up
in an inconsistent state, resulting in an assert failure in the next
modification.
Bug discovered by Wladimir J. van der Laan.
10 years ago
7eeeac0ff5
Remove dead BitcoinUnits::id code and update assets-attribution for non-image unit selector
10 years ago
70477a0bdf
On close of splashscreen interrupt verifyDB
...
With the splashscreen being able to be closed it is possible to
shutdown during the lengthy verifyDB method. (Takes about a minute
on my machine). This change allows us to shutdown much sooner.
Github-Pull: #5557
10 years ago
856e862f4a
namespace: drop most boost namespaces and a few header cleanups
...
A few boost::asio were left around because they're very wordy otherwise.
10 years ago
9b1ab860ff
namespace: drop boost::assign altogether here
...
Standard functions are even simpler
10 years ago
a3241998e1
namespace: remove boost namespace pollution
10 years ago
269d8ba0d2
Remove declaration of no longer existent CheckWork
...
Also make ProcessBlockFound static as it is not used outside
miner.cpp.
Alternative implementation of #5549 .
10 years ago
edbc9045cb
Bump project-wide COPYRIGHT_YEAR to 2015
...
There is still a redundancy here between configure.ac and
clientversion.h.
10 years ago
e6df2bb48f
Remove redundant copyright notices from README files
...
The normative place for these for the entire project is COPYING,
and the main README already has a MIT license section.
10 years ago
23f3435962
Rename MAX_TX_SIGOPS to MAX_STANDARD_TX_SIGOPS to match similar policy constant MAX_STANDARD_TX_SIZE
10 years ago
643415aade
[Qt] update a translation string and argument counts
10 years ago
1b178a7f96
Bugfix: ConnectBlock: In case the genesis block gets in with fJustCheck, behave correctly
10 years ago
228d238525
Make CCoinsViewCache's copy constructor private
...
It is easily confused with CCoinsViewCache(CCoinsView*), which creates a sub-cache, but instead of creating a sub-cache, the copy constructor would copy the original and use that original's base, defeating the intended isolation.
10 years ago
4f1ee565b5
Clean AcceptToMemoryPool error messages
10 years ago
8f6860a083
Bugfix: RPCWallet: Docs: Booleans aren't quoted
10 years ago
7b782f5b01
RPCWallet: Notate all account stuff as deprecated
10 years ago
06206bb3b7
Correct tooltip on address book page
10 years ago
de236f57c6
clarify obscure uses of EvalScript()
...
The 3rd argument of EvalScript() is the unsigned int flags, not a bool.
10 years ago
1c52aad540
Require sufficent priority for relay of free transactions
10 years ago
8db1760751
rpcserver: attempt to fix uncaught exception.
10 years ago
dd3f69736a
Use real text rather than image-rendered text for unit selector
...
The width of each unit is measured to set a fixed width for the widget, and the color is set to match the other status widgets.
10 years ago
99913f0f70
Fix reference.
...
The text talked about "Quit" while Bitcoin uses "Exit" in its menu.
10 years ago
9b7d3fb165
Adopt style colour for button icons
10 years ago
87fb31086d
Move UndoWriteToDisk() and UndoReadFromDisk() to anon namespace
10 years ago
937ba572d0
MOVEONLY: CBlockUndo from main.h to undo.h
10 years ago
e035c6a737
Decouple CBlockUndo from CDiskBlockPos
10 years ago
d7621ccf9d
Decouple miner.o and txmempool.o from CTxUndo
10 years ago
c444c620c6
Decouple CCoins from CTxInUndo
10 years ago
de779b307b
[Qt] new icon for the debug window
10 years ago
a094b3d973
Remove bitnodes.io from dnsseeds.
...
I'm not comfortable with retaining this entry.
10 years ago
8024d67dae
Add immature balances to getwalletinfo.
10 years ago
d44c545673
Add unconfirmedbalance field to getwalletinfo
10 years ago
d78f0dafd5
Fix CScriptID(const CScript& in) in empty script case
...
Previously an empty script wouldn't be hashed, and CScriptID would be
assigned the incorrect value of 0 instead. This bug can be seen in the
RPC decodescript command:
$ btc decodescript ""
{
"asm" : "",
"type" : "nonstandard",
"p2sh" : "31h1vYVSYuKP6AhS86fbRdMw9XHieotbST"
}
Correct output:
$ btc decodescript ""
{
"asm" : "",
"type" : "nonstandard",
"p2sh" : "3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy"
}
10 years ago
2c14d1532f
bitcoin-tx: Add test case for signing a tx
10 years ago
a15dba5dff
en: Avoid ambiguous language regarding when transactions confirm
10 years ago
7c5dd60306
Adding RPC tests for the following wallet related calls: getbalance,
...
listsinceblock, listtransactions, listlockunspent, listaccounts
listaddressgroupings
10 years ago
c90770430d
DOS: Respect max per-peer blocks in flight limit
...
Don't allow immediate inv driven block downloads if
a peer already has MAX_BLOCKS_IN_TRANSIT_PER_PEER
active downloads. Prevents bogus inv spam from
blowing up block transfer tracking data structures.
10 years ago
a089c50981
bitcoin-tx: Refer to the JSON fields rather than the whole object
10 years ago
2a3d988b80
bitcoin-tx: Fix JSON validation of prevtxs
10 years ago
3497022347
Reject headers that build on an invalid parent
10 years ago
4bc95c4387
remove max orphan blocks config parameter since it is no longer functional
10 years ago
Wladimir J. van der Laan