MarcoFalke
cb2ed300a8
Merge #9155 : [trivial] update comments for tx weight
...
07ede5d
update comments for tx weight (Brian Deery)
8 years ago
MarcoFalke
0a6d48d9ed
Merge #9168 : [qa] add assert_raises_message to check specific error message
...
307acdd
[qa] add assert_raises_message to check specific error message (mrbandrews)
8 years ago
Wladimir J. van der Laan
434e683f7b
Merge #9133 : Unset fImporting for loading mempool
...
79f755d
Unset fImporting for loading mempool (Alex Morcos)
8 years ago
Wladimir J. van der Laan
62af164638
Merge #9131 : fNetworkActive is not protected by a lock, use an atomic
...
079142b
fNetworkActive is not protected by a lock, use an atomic (Jonas Schnelli)
8 years ago
Wladimir J. van der Laan
4333b1c4ea
Merge #9151 : [qa] proxy_test: Calculate hardcoded port numbers
...
fa80ef8
[qa] proxy_test: Calculate hardcoded port numbers instead (MarcoFalke)
8 years ago
Wladimir J. van der Laan
918ea16dc0
Merge #9169 : build: fix qt5.7 build under macOS
...
70266e9
build: fix qt5.7 build under macOS (Cory Fields)
8 years ago
Cory Fields
70266e9829
build: fix qt5.7 build under macOS
...
OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding
to c++11, just force OBJCXX to be the same as CXX unless the user specified
otherwise.
8 years ago
mrbandrews
307acdd3df
[qa] add assert_raises_message to check specific error message
8 years ago
Pieter Wuille
6eeac6e30d
Merge #9164 : [trivial] credit values are CAmount
...
20c3215
credit values are CAmount (Gregory Sanders)
8 years ago
instagibbs
ea83d0098a
SendMoney: use already-calculated balance
8 years ago
Gregory Sanders
20c3215a90
credit values are CAmount
8 years ago
Wladimir J. van der Laan
018a4eb120
Merge #9140 : Bugfix: Correctly replace generated headers and fail cleanly
...
b74ff5c
Bugfix: Correctly replace generated headers and fail cleanly (Luke Dashjr)
8 years ago
Wladimir J. van der Laan
f54e4605fc
Merge #9132 : Make strWalletFile const
...
f734505
Make strWalletFile const (Jonas Schnelli)
8 years ago
Wladimir J. van der Laan
770364b8ea
Merge #9160 : [trivial] Fix hungarian variable name
...
ec34648
[trivial] Fix hungarian variable name (Russell Yanofsky)
8 years ago
MarcoFalke
b422913346
Merge #9136 : sync_blocks cleanup
...
7943b13
[qa] Avoid 2 list comprehensions in sync_blocks (Russell Yanofsky)
05e57cc
[qa] Fix sync_blocks timeout argument (Russell Yanofsky)
fd6bb70
[qa] Improve sync_blocks error messages. (Russell Yanofsky)
8 years ago
Russell Yanofsky
ec34648766
[trivial] Fix hungarian variable name
...
Follow up to comment https://github.com/bitcoin/bitcoin/pull/9058#discussion_r87676593
8 years ago
Russell Yanofsky
dfa44d1b07
[qa] Wait for specific block announcement in p2p-compactblocks
...
Change check_announcement_of_new_block() to wait specifically for the
announcement of the newly created block, instead of waiting for any
announcement at all. A difficult to reproduce failure in
check_announcement_of_new_block() that happened in a travis build
(https://travis-ci.org/bitcoin/bitcoin/jobs/175198367 ) might have happened
because an older announcement was mistaken for the expected one. The error
looked like:
Assertion failed: Failed
File ".../bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 145, in main
self.run_test()
File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 787, in run_test
self.test_sendcmpct(self.nodes[1], self.segwit_node, 2, old_node=self.old_node)
File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 201, in test_sendcmpct
check_announcement_of_new_block(node, test_node, lambda p: p.last_cmpctblock is None and p.last_inv is not None)
File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 194, in check_announcement_of_new_block
assert(predicate(peer))
This commit also changes the assertion failed message above to include more
detailed information for debug.
8 years ago
Russell Yanofsky
7943b13ab3
[qa] Avoid 2 list comprehensions in sync_blocks
8 years ago
Russell Yanofsky
05e57ccd74
[qa] Fix sync_blocks timeout argument
...
Motivation for this change is mainly to make sync_blocks behavior easier to
understand. Behavior is unchanged in the normal case when there are only 2
nodes in the rpc_connections set. When there are more than 2 nodes, the
previous "timeout -= wait" statement wouldn't take into account time spent
waiting for all nodes and as a result could lead to blocking for longer than
the requested timeout.
8 years ago
Russell Yanofsky
fd6bb700b7
[qa] Improve sync_blocks error messages.
8 years ago
Jonas Schnelli
924745dd6f
Merge #9145 : [qt] Make network disabled icon 50% opaque
...
fa42e4a
[qt] Make network disabled icon 50% opaque (MarcoFalke)
8 years ago
Brian Deery
07ede5d711
update comments for tx weight
8 years ago
MarcoFalke
fa80ef8173
[qa] proxy_test: Calculate hardcoded port numbers instead
8 years ago
MarcoFalke
fa42e4a082
[qt] Make network disabled icon 50% opaque
8 years ago
Jonas Schnelli
4512550fa0
Remove unnecessary calls to CheckFinalTx
8 years ago
Pavel Janík
1260c1103b
Mention the new network toggle functionality in the tooltip.
8 years ago
Jonas Schnelli
2e44893081
Move -salvagewallet, -zap(wtx) to where they belong
8 years ago
Luke Dashjr
b74ff5cf0c
Bugfix: Correctly replace generated headers and fail cleanly
...
Also removes generation of headers for *.raw files in test_bitcoin (none exist anymore)
8 years ago
Russell Yanofsky
1126c853d9
[qa] Change sync_blocks to pick smarter maxheight
...
Instead of syncing to max height returned by the waitforblockheight RPC, sync
to the max height returned by the getblockcount RPC.
This change was suggested by Suhas Daftuar <sdaftuar@chaincode.com>.
8 years ago
Alex Morcos
79f755db41
Unset fImporting for loading mempool
8 years ago
Jonas Schnelli
f7345050e9
Make strWalletFile const
8 years ago
Jonas Schnelli
079142b757
fNetworkActive is not protected by a lock, use an atomic
8 years ago
Wladimir J. van der Laan
87ab49e4fe
Merge #9124 : Use better name for local variable to prevent -Wshadow compiler warning
...
bf49f10
Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
8 years ago
Wladimir J. van der Laan
bfc7aad008
Merge #9115 : Mention reporting security issues responsibly
...
7d1de30
Mention reporting security issues responsibly (Pavel Janík)
8 years ago
Jonas Schnelli
ab914a6530
Merge #8996 : Network activity toggle
...
19f46f1
Qt: New network_disabled icon (Luke Dashjr)
54cf997
RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr)
b2b33d9
Overhaul network activity toggle (Jonas Schnelli)
32efa79
Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen)
e38993b
RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen)
7c9a98a
Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
8 years ago
Wladimir J. van der Laan
7977a1157a
Merge #9058 : Fixes for p2p-compactblocks.py test timeouts on travis ( #8842 )
...
dac53b5
Modify getblocktxn handler not to drop requests for old blocks (Russell Yanofsky)
55bfddc
[qa] Fix stale data bug in test_compactblocks_not_at_tip (Russell Yanofsky)
47e9659
[qa] Fix bug in compactblocks v2 merge (Russell Yanofsky)
8 years ago
Wladimir J. van der Laan
46027e8668
Merge #9112 : Avoid ugly exception in log on unknown inv type
...
e9f25dd
Avoid ugly exception in log on unknown inv type (Wladimir J. van der Laan)
8 years ago
Wladimir J. van der Laan
21e6c6b569
Merge #9114 : [depends] Set OSX_MIN_VERSION to 10.8
...
617c96d
[depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
8 years ago
Pavel Janík
bf49f107ef
Use better name for local variable to prevent -Wshadow compiler warning
8 years ago
Wladimir J. van der Laan
71bc39eb74
Merge #9049 : Remove duplicatable duplicate-input check from CheckTransaction
...
e2b3fb3
Optimize vInOutPoints insertion a bit (Matt Corallo)
eecffe5
Remove redundant duplicate-input check from CheckTransaction (Matt Corallo)
b2e178a
Add deserialize + CheckBlock benchmarks, and a full block hex (Matt Corallo)
8 years ago
Pavel Janík
7d1de3032d
Mention reporting security issues responsibly
8 years ago
MarcoFalke
e5364991da
Merge #9097 : [qa] Rework sync_* and preciousblock.py
...
fa97ccb
[qa] util: Rework sync_*() (MarcoFalke)
fac1141
[qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
8 years ago
MarcoFalke
4a2b170c07
Merge #9122 : fix getnettotals RPC description about timemillis.
...
a79f864
fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
8 years ago
Wladimir J. van der Laan
aab102cbae
Merge #9121 : Initialize variable to prevent compiler warning
...
bdcba6d
Initialize variable to prevent compiler warning (Pavel Janík)
8 years ago
Wladimir J. van der Laan
537e0cb252
Merge #9120 : bug: Missed one "return false" in recent refactoring in #9067
...
45d372f
Missed one "return false" in recent refactoring in #9067 (UdjinM6)
8 years ago
Masahiko Hyuga
a79f864945
fix getnettotals RPC description about timemillis.
8 years ago
Pavel Janík
bdcba6d933
Initialize variable to prevent compiler warning
8 years ago
UdjinM6
45d372f889
Missed one "return false" in recent refactoring in #9067
8 years ago
Wladimir J. van der Laan
faec09bc7f
Merge #8894 : [Testing] Include fRelay in mininode version messages
...
e5d682f
Fix mininode version message format (jnewbery)
8 years ago
Wladimir J. van der Laan
fb156100f9
Merge #9111 : Remove unused variable UNLIKELY_PCT from fees.h
...
d8edf03
Remove unused var UNLIKELY_PCT from fees.h (fanquake)
8 years ago