Jonas Schnelli
62886598db
[Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds
...
Github-Pull: #8765
Rebased-From: c6f5ca822f
8 years ago
Alexey Vesnin
ea51b0f5dd
Berkeley DB v6 compatibility fix
...
Fixes building error looking like this:
CXX wallet/libbitcoin_wallet_a-db.o
wallet/db.cpp: In member function ‘void CDBEnv::EnvShutdown()’:
wallet/db.cpp:46:16: error: call of overloaded ‘DbEnv(int)’ is ambiguous
DbEnv(0).remove(strPath.c_str(), 0);
^
wallet/db.cpp:46:16: note: candidates are:
In file included from wallet/db.h:21:0,
from wallet/db.cpp:6:
/usr/include/db_cxx.h:916:2: note: DbEnv::DbEnv(const DbEnv&)
DbEnv(const DbEnv &);
^
/usr/include/db_cxx.h:518:2: note: DbEnv::DbEnv(DB_ENV)
DbEnv(DB_ENV *dbenv);
^
/usr/include/db_cxx.h:516:2: note: DbEnv::DbEnv(u_int32_t)
DbEnv(u_int32_t flags);
^
Makefile:5780: recipe for target 'wallet/libbitcoin_wallet_a-db.o' failed
make[2]: ** [wallet/libbitcoin_wallet_a-db.o] Error 1
Github-Pull: #8626
Rebased-From: 323a5fe06a
8 years ago
crowning-
cb07f19e90
CDB: fix debug output
...
It doesn't really help to clear a variable before printing it to the debug log.
Github-Pull: #8539
Rebased-From: fab2e26d20
8 years ago
Wladimir J. van der Laan
75d548475d
Add copyright header to wallet_text_fixture.cpp
...
I created the file but forgot to add this header.
Github-Pull: #8558
Rebased-From: 653bb3d640
8 years ago
MarcoFalke
305d8ac90b
Use __func__ to get function name for output printing
...
Github-Pull: #8548
Rebased-From: fa785d1211
8 years ago
Jonas Schnelli
464dedd6ab
[Wallet] Trivial cleanup of HD wallet changes
...
Github-Pull: #8443
Rebased-From: 7e5d94df1f
8 years ago
leijurv
befe654f0f
various typos
...
Github-Pull: #8505
Rebased-From: 1aacfc2da5
8 years ago
Suhas Daftuar
091cdebfb8
Clear witness with vin/vout in CWallet::CreateTransaction()
...
Github-Pull: #8664
Rebased-From: c40b034327
8 years ago
instagibbs
c6a629100b
add witness address to address book
...
Github-Pull: #8693
Rebased-From: 62ffbbdec3
8 years ago
MarcoFalke
526d2b0472
[wallet] rpc: Drop misleading option
...
Github-Pull: #8581
Rebased-From: fab5ecb771
8 years ago
Jonas Schnelli
de45c065f0
[Wallet] Add CKeyMetadata record for HDMasterKey(s), factor out HD key generation
9 years ago
Jonas Schnelli
f142c11ac6
[0.13] Create a new HD seed after encrypting the wallet
9 years ago
Jonas Schnelli
18b8ee1cd1
[Wallet] add HD xpriv to dumpwallet
...
Github-Pull: #8206
Rebased-From: 77c912d21c
9 years ago
Jonas Schnelli
73adfe3bb9
[Wallet] Correct hdmasterkeyid/masterkeyid name confusion
...
Github-Pull: #8390
Rebased-From: b50e1ac298
9 years ago
Patrick Strateman
ebea65121e
Move SetMinVersion for FEATURE_HD to SetHDMasterKey
...
Github-Pull: #8378
Rebased-From: 6523fcaab2
9 years ago
Suhas Daftuar
fca1a415ce
Rename "block cost" to "block weight"
...
Github-Pull: #8363
Rebased-From: 2c06bae39e
9 years ago
Jonas Schnelli
3b38a6a96a
[Wallet] Ensure <0.13 clients can't open HD wallets
9 years ago
Jonas Schnelli
7945088d41
[Wallet] comsetic non-code changes for the HD feature
9 years ago
Jonas Schnelli
68d7682b9f
[Wallet] ensure CKeyMetadata.hdMasterKeyID will be cleared during SetNull()
9 years ago
Jonas Schnelli
b993671921
[Wallet] keep HD seed during salvagewallet
9 years ago
Jonas Schnelli
986c223214
[Wallet] print hd masterkeyid in getwalletinfo
9 years ago
Jonas Schnelli
5b95dd2c25
[Wallet] extend CKeyMetadata with HD keypath
9 years ago
MarcoFalke
477777f250
[rpcwallet] Don't use floating point
9 years ago
Wladimir J. van der Laan
20f3cd75f6
wallet: Revert input selection post-pruning
...
This reverts PR #4906 , "Coinselection prunes extraneous inputs from
ApproximateBestSubset".
Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.
See also #7664 , #7657 , as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
9 years ago
Wladimir J. van der Laan
a1c92c29fd
trivial: capitalize BIP32 in option help
...
For consistency, BIP32 should be in uppercase in translation message.
Reported by @pryds on Transifex.
9 years ago
Alex Morcos
4f7ff00497
[qa] Add rpc test for segwit
...
Amended by Pieter Wuille to use multisig 1-of-1 for P2WSH tests, and BIP9
based switchover logic.
Fixes and py3 conversion by Marco Falke.
9 years ago
Pieter Wuille
f4691ab3a9
[RPC] Add wallet support for witness transactions (using P2SH)
...
Includes support for pushkeyhash wit v0 by Alex Morcos.
9 years ago
Pieter Wuille
605e8473a7
BIP143: Signing logic
9 years ago
Pieter Wuille
2b1f6f9ccf
BIP141: Other consensus critical limits, and BIP145
...
Includes changes by Suhas Daftuar, Luke-jr, and mruddy.
9 years ago
Pieter Wuille
7030d9eb47
BIP144: Serialization, hashes, relay (sender side)
...
Contains refactorings by Eric Lombrozo.
Contains fixup by Nicolas Dorier.
Contains cleanup of CInv::GetCommand by Alex Morcos
9 years ago
MarcoFalke
faa91b12f7
[wallet] tests: Don't use floating point
9 years ago
Jonas Schnelli
afcd77e179
Detect -usehd mismatches when wallet.dat already exists
9 years ago
Wladimir J. van der Laan
d096d22446
build: Get rid of `CLIENT_DATE`
...
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.
Continues #7732 which did this for the GUI.
9 years ago
Pieter Wuille
77f63a4fcd
Fix two warnings for comparison between signed and unsigned
9 years ago
MarcoFalke
fa7f4f577c
[rpc] fundrawtransaction feeRate: Use BTC/kB
...
Also introduce UniValueType
UniValueType is a wrapper for UniValue::VType which allows setting
a typeAny flag. This flag indicates the type does not matter.
(Used by RPCTypeCheckObj)
9 years ago
MarcoFalke
faf82e8fc8
[rpc] fundrawtransaction: Fix help text and interface
9 years ago
Patrick Strateman
152ab236ea
Improve CWallet API with new GetAccountPubkey function.
...
Remove one more caller that is passing CWalletDB.
9 years ago
Pieter Wuille
595b22e5c0
Stop treating importaddress'ed scripts as change
...
Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.
Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.
9 years ago
Patrick Strateman
9dfaa1cb70
Improve CWallet API with new AccountMove function.
9 years ago
Jonas Schnelli
c022e5b15d
[Wallet] use constant for bip32 hardened key limit
9 years ago
Jonas Schnelli
f19025106d
[Wallet] Add simplest BIP32/deterministic key generation implementation
9 years ago
Pieter Wuille
fa2637a3be
Always require OS randomness when generating secret keys
9 years ago
Patrick Strateman
380498aba4
Move BackupWallet to CWallet::BackupWallet
9 years ago
Patrick Strateman
ecb9741ec3
Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance
9 years ago
Gregory Maxwell
d87b198b73
Remove unneeded feerate param from RelayTransaction/AcceptToMemoryPool.
9 years ago
Cory Fields
34ed64a404
crypter: add tests for crypter
...
Verify that results correct (match known values), consistent (encrypt->decrypt
matches the original), and compatible with the previous openssl implementation.
Also check that failed encrypts/decrypts fail the exact same way as openssl.
9 years ago
Cory Fields
976f9ec264
crypter: add a BytesToKey clone to replace the use of openssl
...
BytesToKeySHA512AES should be functionally identical to EVP_BytesToKey, but
drops the dependency on openssl.
9 years ago
Cory Fields
9049cde4d9
crypter: hook up the new aes cbc classes
9 years ago
Cory Fields
fb96831c1f
crypter: constify encrypt/decrypt
...
This makes CCrypter easier to pass aroundf for tests
9 years ago
Cory Fields
1c391a5866
crypter: fix the stored initialization vector size
...
AES IV's are 16bytes, not 32. This was harmless but confusing.
Add WALLET_CRYPTO_IV_SIZE to make its usage explicit.
9 years ago