b2c9254205
Check interruptNet during dnsseed lookups
8 years ago
883154cbcb
[rpc] rename disconnectnode argument
8 years ago
9fececb2cb
Remove CValidationInterface::UpdatedTransaction
...
This removes another callback from block connection logic, making it
easier to reason about the wallet-RPCs-returns-stale-info issue.
UpdatedTransaction was previously used by the GUI to display
coinbase transactions only after they have a block built on top of
them. This worked fine for in most cases, but only worked due to a
corner case if the user received a coinbase payout in a block
immediately prior to restart. In that case, the normal process of
caching the most recent coinbase transaction's hash would not work,
and instead it would only work because of the on-load -checkblocks
calling DisconnectBlock and ConnectBlock on the current tip.
In order to make this more robust, a full mapWallet loop after the
first block which is connected after restart was added.
8 years ago
c37e32af0d
[Wallet] Prevent CInputCoin to be in a null state
8 years ago
f597dcb7c8
[Wallet] Simplify code using CInputCoin
8 years ago
e78bc45810
[Wallet] Decouple CInputCoin from CWalletTx
8 years ago
f9c88079df
Deduplicate SignatureCacheHasher
...
This moves the SignatureCacheHasher to the sigcache header, out of the anonymous
namespace, so that the tests can import it.
8 years ago
c851be4b25
net: define NodeId as an int64_t
...
This should make occurances of NodeId wrapping essentially impossible for
real-world usage.
8 years ago
d0cd0bd6d9
Make CWallet::SyncTransactions() interface friendlier
8 years ago
714e4ad13d
AddToWalletIfInvolvingMe should test pIndex, not posInBlock
8 years ago
7fd50c3b70
allow libevent logging to be updated during runtime
8 years ago
5255aca3f4
[rpc] Add logging RPC
...
Adds an RPC to get and set currently active logging categories.
8 years ago
4d9950d3bc
Set BCLog::LIBEVENT correctly for old libevent versions.
8 years ago
d89f8adf25
Make DisconnectBlock and ConnectBlock static in validation.cpp
8 years ago
8c3e6c6987
Changed "Send" button default status from true to false
...
Changed the "Send" button's default status from true to false to prevent
quirky Windows autofocus behavior.
8 years ago
e9ff818b69
Fix for issues with startup and multiple monitors on windows.
8 years ago
fd44ac1e8b
[Wallet] Rename std::pair<const CWalletTx*, unsigned int> to CInputCoin
8 years ago
dd7e43e438
Fix build warning from #error text
8 years ago
bcca57eff0
[trivial] Fix typo ("improssible" → "impossible")
8 years ago
b1a6d4cd56
Take a CTransactionRef in AddToWalletIfInvolvingMe to avoid a copy
8 years ago
1c95e2f9c9
Use std::shared_ptr instead of boost::shared_ptr in ScriptForMining
8 years ago
91f1e6ce5e
Remove dead-code tracking of requests for blocks we generated
8 years ago
acad82f375
Add override to functions using CValidationInterface methods
8 years ago
e6d5e6cbbe
Hold cs_wallet for whole block [dis]connection processing
...
This simplifies fixing the wallet-returns-stale-info issue as we
now hold cs_wallet across an entire block instead of only per-tx.
8 years ago
461e49fee2
SyncTransaction->TxAddedToMempool/BlockConnected/Disconnected
...
This simplifies fixing the wallet-returns-stale-info issue as we
can now hold cs_wallet across an entire block instead of only
per-tx (though we only actually do so in the next commit).
This change also removes the NOT_IN_BLOCK constant in favor of only
passing the CBlockIndex* parameter to SyncTransactions when a new
block is being connected, instead of also when a block is being
disconnected.
This change adds a parameter to BlockConnectedDisconnected which
lists the transactions which were removed from mempool due to
confliction as a result of this operation. While its somewhat of a
shame to make block-validation-logic generate a list of mempool
changes to be included in its generated callbacks, fixing this isnt
too hard.
Further in this change-set, CValidationInterface starts listening
to mempool directly, placing it in the middle and giving it a bit
of logic to know how to route notifications from block-validation,
mempool, etc (though not listening for conflicted-removals yet).
8 years ago
f404334910
Handle SyncTransaction in ActivateBestChain instead of ConnectTrace
...
This makes a later change to move it all into one per-block callback
simpler.
8 years ago
a1476877ce
Keep conflictedTxs in ConnectTrace per-block
8 years ago
d3167ba9bb
Handle conflicted transactions directly in ConnectTrace
8 years ago
29e6e231c8
Make ConnectTrace::blocksConnected private, hide behind accessors
8 years ago
822000cf82
Add pblock to connectTrace at the end of ConnectTip, not start
...
This makes ConnectTip responsible for the ConnectTrace instead
of splitting the logic between ActivateBestChainStep and ConnectTip
8 years ago
f5e9a019a4
Include missing #include in zmqnotificationinterface.h
8 years ago
3491476b6f
Wallet: reduce excess logic InMemPool()
...
removed the excess logic, return directly instead of using if-statement.
8 years ago
1352092dbd
Log calls to getblocktemplate
8 years ago
08d9aee3eb
build: Remove duplicate version information from src/clientversion.h
...
Fail when the version information is not defined otherwise when
HAVE_CONFIG_H is not set.
8 years ago
faafa801e8
init: Remove redundant logging code
8 years ago
faab6241d0
logging: Fix off-by-one for shrinkdebugfile
8 years ago
cd7f39467a
initialize flag variable to 0 (and continue if GetLogCategory() fails)
8 years ago
9bef02e365
Bugfix: ancestor modifed fees were incorrect for descendants
...
If prioritisetransaction was called for a tx with in-mempool
descendants, the modified ancestor fee values for those descendants was
incorrect.
8 years ago
bf1026412d
Run bitcoin_test-qt under minimal QPA platform
...
Fixes broken "make check" reported by Matt Corallo <git@bluematt.me> in
https://github.com/bitcoin/bitcoin/issues/10110
Fix was suggested and initially implemented by
Cory Fields <cory-nospam-@coryfields.com> in
https://github.com/bitcoin/bitcoin/pull/10117#issuecomment-290275236
8 years ago
3bde556429
Add -debugexclude option to switch off logging for specified components
8 years ago
f110272dc9
Remove `namespace fs=fs`
...
Having these inside functions is silly and redundant now.
8 years ago
75594bd7f2
torcontrol: Use fs::path instead of std::string for private key path
8 years ago
2a5f574762
Use fsbridge for fopen and freopen
...
Abstracts away how a path is opened to a `FILE*`.
Reduces the number of places where path is converted to a string
for anything else but printing.
8 years ago
bac5c9cf64
Replace uses of boost::filesystem with fs
...
Step two in abstracting away boost::filesystem.
To repeat this, simply run:
```
git ls-files \*.cpp \*.h | xargs sed -i 's/boost::filesystem/fs/g'
```
8 years ago
7d5172d354
Replace includes of boost/filesystem.h with fs.h
...
This is step one in abstracting the use of boost::filesystem.
8 years ago
19e36bbef6
Add fs.cpp/h
8 years ago
30f30c0f99
Add braces to submitblock per current style.
8 years ago
4f15ea102d
Check transaction count early in submitblock.
...
There is no point in even hashing a submitted block which doesn't have
a coinbase transaction.
This also results in more useful error reporting on corrupted input.
Thanks to rawodb for the bug report.
8 years ago
ada0caa165
Make GetWitnessCommitmentIndex callable on blocks without a coinbase txn.
...
This isn't actually needed anywhere, but it's less brittle.
8 years ago
4b87973c32
[rpc] Remove auth cookie on shutdown
...
Accidentally removed in 40b556d374
8 years ago
Matt Corallo