kevacoin

15314 Commits

29 Branches

232 Tags

129 MiB

Tree: 6b58360f9b

Commit Graph

Author	SHA1	Message	Date
MarcoFalke	fae2673d5d	qa: check-rpc-mapping must not run on empty lists	7 years ago
Wladimir J. van der Laan	77aa9e59ea	test: Check RPC argument mapping Parse the dispatch tables from the server implementation files, and the conversion table from the client. Perform the following consistency checks: - Arguments defined in conversion table, must be present in dispatch table. If not, it was probably forgotten to add them to the dispatch table, and they will not work. - Arguments defined in conversion table must have the same names as in the dispatch table. If not, they will not work. - All aliases for an argument must either be present in the conversion table, or not. Anything in between means an oversight and some aliases won't work. Any of these results in an error. It also performs a consistency check to see if the same named argument is sometimes converted, and sometimes not. E.g. one RPC call might have a 'verbose' argument that is converted, another RPC call might have one that is not converted. This is not necessarily wrong, but points at a possible error (as well as makes the API harder to memorize) - so it is emitted as a warning (could upgrade this to error).	7 years ago

Author

SHA1

Message

Date

MarcoFalke

fae2673d5d

qa: check-rpc-mapping must not run on empty lists

7 years ago

Wladimir J. van der Laan

77aa9e59ea

test: Check RPC argument mapping

Parse the dispatch tables from the server implementation files,
and the conversion table from the client.

Perform the following consistency checks:

- Arguments defined in conversion table, must be present in dispatch
  table. If not, it was probably forgotten to add them to the
  dispatch table, and they will not work.

- Arguments defined in conversion table must have the same names as
  in the dispatch table. If not, they will not work.

- All aliases for an argument must either be present in the
  conversion table, or not. Anything in between means an oversight
  and some aliases won't work.

Any of these results in an error.

It also performs a consistency check to see if the same
named argument is sometimes converted, and sometimes not. E.g.
one RPC call might have a 'verbose' argument that is converted,
another RPC call might have one that is not converted. This is not
necessarily wrong, but points at a possible error (as well as
makes the API harder to memorize) - so it is emitted as a warning
(could upgrade this to error).

7 years ago

2 Commits (6b58360f9b64eb0b680a662fdfd590e47f115f44)