5995735c5b
scripted-diff: Remove #include <boost/foreach.hpp>
...
-BEGIN VERIFY SCRIPT-
sed -i ':a;N;$!ba;s/#include <boost\/foreach.hpp>\n//' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp
-END VERIFY SCRIPT-
8 years ago
61718268b5
Don't create change at the dust limit, even if it means paying more than expected
8 years ago
e9cd7786da
Pass in smart fee slider value to coin control dialog
...
Since cfe77ef41
8 years ago
1d1ea9f096
Turn TryCreateDirectory() into TryCreateDirectories()
...
Use case: TryCreateDirectory(GetDataDir() / "blocks" / "index") would
fail if the blocks directory was not explicitly created before.
The line that did so was in a weird location and could be removed as a
result.
8 years ago
1bebfc8d3a
Output Fee Estimation Calculations in CreateTransaction
8 years ago
4087d9ea7c
Remove unnecessary forward class declarations in header files
8 years ago
4265bf351a
Remove unreachable or otherwise redundant code
8 years ago
e53a0fa12a
Remove duplicate includes
8 years ago
49de096c2a
Remove unused Boost includes
8 years ago
b124cf04ea
Wallet: Replace pwalletMain with a vector of wallet pointers
8 years ago
3fb81a8480
Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
8 years ago
1238f13cf6
scripted-diff: Remove PAIRTYPE
...
-BEGIN VERIFY SCRIPT-
sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ;
-END VERIFY SCRIPT-
8 years ago
18dc3c3962
scripted-diff: Remove Q_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
8 years ago
7c00c26726
scripted-diff: Fully remove BOOST_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
8 years ago
a5410ac5ec
Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal
8 years ago
90593ed92c
Limit variable scope
8 years ago
589827975f
scripted-diff: various renames for per-utxo consistency
...
Thanks to John Newberry for pointing these out.
-BEGIN VERIFY SCRIPT-
sed -i 's/\<GetCoins\>/GetCoin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<HaveCoins\>/HaveCoin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<HaveCoinsInCache\>/HaveCoinInCache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<IsPruned\>/IsSpent/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<FetchCoins\>/FetchCoin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<CoinsEntry\>/CoinEntry/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<vHashTxnToUncache\>/coins_to_uncache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<vHashTxToUncache\>/coins_to_uncache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<fHadTxInCache\>/had_coin_in_cache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<coinbaseids\>/coinbase_coins/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<disconnectedids\>/disconnected_coins/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<duplicateids\>/duplicate_coins/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<oldcoins\>/old_coin/g' src/test/coins_tests.cpp
sed -i 's/\<origcoins\>/orig_coin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
8 years ago
5083079688
Switch CCoinsView and chainstate db from per-txid to per-txout
...
This patch makes several related changes:
* Changes the CCoinsView virtual methods (GetCoins, HaveCoins, ...)
to be COutPoint/Coin-based rather than txid/CCoins-based.
* Changes the chainstate db to a new incompatible format that is also
COutPoint/Coin based.
* Implements reconstruction code for hash_serialized_2.
* Adapts the coins_tests unit tests (thanks to Russell Yanofsky).
A side effect of the new CCoinsView model is that we can no longer
use the (unreliable) test for transaction outputs in the UTXO set
to determine whether we already have a particular transaction.
8 years ago
8906a9a0d2
Fix bumpfee test after #10449
...
Failure reported by Jorge Timón <jtimon@jtimon.cc>
https://github.com/bitcoin/bitcoin/pull/10449#issuecomment-305556569
8 years ago
620444bd59
Fix broken q4 test build
...
Error reported by Patrick Strateman <patrick.strateman@gmail.com>
https://github.com/bitcoin/bitcoin/pull/10420#issuecomment-303908782
8 years ago
6d7104c994
[Qt] make sure transaction table entry gets updated after bump
8 years ago
32325a3f58
[Qt] hide bump context menu action if tx already has been bumped
8 years ago
5749a48821
Add Qt tests for wallet spends & bumpfee
...
A few code changes were needed to accompany the test:
* Adding setObjectName() calls for a few Qt controls to make them easily
accessible from the test.
* Calling contextMenu->popup() instead of contextMenu->exec() to open
the transaction list context menu without blocking the test thread.
* Opening the context menu at the contextualMenu event point rather than
the cursor position (this change was not strictly needed to make the test
work, but is more correct).
* Updating the bumped transaction row with showTransaction=true instead of
false. This is needed to prevent the bumped tx from being hidden, so the last
part of the test which attempts to bump the bumped tx can work. (Technically
this change is a more general bugfix not limited to the testing environment,
but the bug doesn't happen outside of the testing environment because in the
full Qt client, a queued NotifyTransactionChanged notification causes the row
to be updated twice, first with showTransaction=false, then immediately after
with showTransaction=true.)
8 years ago
e49b868cfe
[qt] Remove excess logic
...
Replace …
```
if (foo) { return true; } else { return false; }
```
… with the equivalent …
```
return foo;
```
8 years ago
429aa9eb51
[test] Move some tests from qt -> wallet
...
After previous refactoring, the tests make more sense here.
8 years ago
d944bd7a27
[qt] Move some WalletModel functions into CWallet
...
Motivation for moving these is to make supporting IPC simpler (#10102 ), so
these lookups can be one-shot IPC requests, instead of back-and-forth
interactions over the IPC channel.
Also these functions are potentially useful outside of the bitcoin GUI (e.g.
for RPCs).
8 years ago
ef8ca179ef
[test] Add tests for some walletmodel functions
...
Add unit tests for some walletmodel functions that will be refactored & moved
in the next commit.
8 years ago
1b936f5926
Replace boost::function with std::function (C++11)
8 years ago
091a9ae21c
remove minimum total fee option
8 years ago
9b9ca538cd
Only update the transactionrecord if the fee bump has been commited
8 years ago
6ed4368f12
Make sure we use nTxConfirmTarget during Qt fee bumps
8 years ago
be08fc39d0
Make sure we always update the table row after a bumpfee call
8 years ago
2678d3dc63
Show old-fee, increase a new-fee in Qt fee bumper confirmation dialog
8 years ago
fbf385cc83
[Qt] simple fee bumper with user verification
8 years ago
5a5e4e9cc1
[wallet] Remove CTransaction&() helper conversion operator from wallet implementation.
8 years ago
012fa9b99d
Add OSX keystroke to clear RPCConsole
...
Currently only Ctrl-L is mentioned in help, but, (⌘)-L functions on OSX and isn't mentioned.
8 years ago
2351a064a6
Chainparams: Get rid of CChainParams& Params(std::string)
8 years ago
330bb5a456
Consensus: Minimal way to move dust out of consensus
8 years ago
fb463d1717
[qt] Don't call method on null WalletModel object
...
This doesn't crash currently because the method doesn't access any object
members, but this behavior is fragile and incompatible with #10102 .
8 years ago
71afe3c099
wallet: Introduce database handle wrapper
...
Abstract database handle from explicit strFilename into
CWalletDBWrapper.
Also move CWallet::Backup to db.cpp - as it deals with representation
details this is a database specific operation.
8 years ago
4082fb0003
Add missing <atomic> header in clientmodel.h
8 years ago
928d4a9ac5
Set both time/height header caches at the same time
8 years ago
610a91719c
Declare headers height/time cache mutable, re-set the methods const
8 years ago
cf92bce526
Update the remaining blocks left in modaloverlay at init.
8 years ago
7148f5e7d7
Reduce cs_main locks during modal overlay by adding an atomic cache
8 years ago
608bbccfb9
[qt] Stop treating coinbase outputs differently: show them at 1conf
8 years ago
1c897fc3da
Missing includes
8 years ago
c851be4b25
net: define NodeId as an int64_t
...
This should make occurances of NodeId wrapping essentially impossible for
real-world usage.
8 years ago
14e10aa842
Call estimate(Smart)Fee directly from CBlockPolicyEstimator
8 years ago
8c3e6c6987
Changed "Send" button default status from true to false
...
Changed the "Send" button's default status from true to false to prevent
quirky Windows autofocus behavior.
8 years ago
Jorge Timón