Philip Kaufmann
5eed8c21c7
minor license, header end comment etc. cleanup in /script
...
- ensure all licenses are just MIT
- add a missing header end comment
- ensure alphabetical ordering
10 years ago
Wladimir J. van der Laan
eb6b3b245c
Update English translation
10 years ago
Wladimir J. van der Laan
b9b2e3fabd
Don't translate state.Abort() messages
...
There is only one message passed to AbortNode() that makes sense to
translate to the user specifically: Disk space is low. For the others
show a generic message and refer to debug.log for details.
Reduces the number of confusing jargon translation messages.
10 years ago
jtimon
54510f2672
DRY: Avoid repetitions in script_test
10 years ago
Pieter Wuille
e790c370b5
Replace SCRIPT_VERIFY_NOCACHE by flag directly to checker
10 years ago
Pieter Wuille
5c1e798a8e
Make signature cache optional
10 years ago
Pieter Wuille
c7829ea797
Abstract out SignatureChecker
10 years ago
R E Broadley
4bb30a1eb8
Correct logging AcceptBlock()->AcceptBlockHeader()
10 years ago
Eric Shaw
bc470c43ee
Changed mixed indentation to four spaces
...
Put `test/rpc_wallet_tests.cpp` through clang-format.
10 years ago
Eric Shaw
31d6390fd1
Fixed setaccount accepting foreign address
...
Fixed issue #4209 where using setaccount with a foreign
address causes the address to be added to your receiving addresses.
10 years ago
Wladimir J. van der Laan
fbd36d8fb5
Avoid introducing a virtual into CChainParams
...
Treat fSkipProofOfWorkCheck the same as other parameters.
10 years ago
SergioDemianLerner
f0fd00cb77
Switch testing framework from MAIN to new UNITTEST network
...
UNITTEST inherites from MAIN but allows synamically changing its parameters using the ModifiableParams() interface
10 years ago
Philip Kaufmann
e2efdf3937
amount.h: update license, add header end comment + rem from util.h
10 years ago
Philip Kaufmann
938bccebf1
CAutoFile: make file private
10 years ago
Philip Kaufmann
0c35486dc9
CBufferedFile: add explicit close function
...
- also use identical close function for CAutoFile (avoids setting file to
NULL under wrong conditions)
10 years ago
Philip Kaufmann
c9fb27da0a
CBufferedFile: convert into a non-refcounted RAII wrapper
...
- it now takes over the passed file descriptor and closes it in the
destructor
- this fixes a leak in LoadExternalBlockFile(), where an exception could
cause the file to not getting closed
- disallow copies (like recently added for CAutoFile)
- make nType and nVersion private
10 years ago
Wladimir J. van der Laan
8d132431b4
Revert merge of pull #4845
...
It breaks the new mingw tests!
See
- https://travis-ci.org/bitcoin/bitcoin/jobs/36845581
- https://travis-ci.org/bitcoin/bitcoin/jobs/36845582
This reverts commit 4705902777
, 5e2e7fcb99
, a25fd6be13
.
10 years ago
Mark Friedenbach
f74fc9b22d
Print input index when signature validation fails, to aid debugging.
10 years ago
Mark Friedenbach
217a5c9238
When transaction outputs exceed inputs, show the offending amounts so as to aid debugging.
10 years ago
Wladimir J. van der Laan
c122f5528c
qt: Register CAmount metatype
...
This allows sending the type over queued connections.
Also normalize signal/slot names.
10 years ago
Philip Kaufmann
c375b5c102
remove dead/unused code in walletdb.cpp
...
- closes #5021
10 years ago
Philip Kaufmann
b5ec5fe0cb
update getnetworkinfo help with subversion
...
- add missing subversion field to getnetworkinfo help
- fix style and format errors in help string
- remove unneeded int casts
10 years ago
Cory Fields
63c17613ab
tests: fix false-positive under win64
...
BN_ULONG isn't necessarily an unsigned long, as is the case on win64.
10 years ago
Cory Fields
41d67c78bf
tests: fix python test-runner for windows
...
Windows needed a few fixups to get the tests running:
1. bitcoin-tx needs a file extension in Windows. Take this opportunity to
add an env file, which pulls variables out of our build config. This can
be extended as needed, for now it's very simple.
2. After #1 , split the args out of the exec key in the test data.
3. Correct the line-endings from windows stdout
10 years ago
Pieter Wuille
68af7d02cf
Fix vector out of bounds in script tests
10 years ago
Wladimir J. van der Laan
4705902777
Avoid introducing a virtual into CChainParams
...
Treat fSkipProofOfWorkCheck the same as other parameters.
10 years ago
SergioDemianLerner
5e2e7fcb99
Suggested corrections on comments, variable names.
...
Also new test case testing the PoW skip in UNITTEST.
10 years ago
SergioDemianLerner
a25fd6be13
Switch testing framework from MAIN to new UNITTEST network
...
UNITTEST inherites from MAIN but allows synamically changing its parameters using the ModifiableParams() interface
10 years ago
Philip Kaufmann
7bec6dd230
cleanup license and header end comment in chain.cpp/.h
10 years ago
Philip Kaufmann
0db65d8798
update license of compat and crypto
...
- change license to be just MIT for all files in compat and crypto
- also add missing header end comments
- ensure default header include style
10 years ago
sinetek
775b7b8d70
LLu is standard, but not portable. use ULL
10 years ago
Mark Friedenbach
a372168e77
Use a typedef for monetary values
10 years ago
Pieter Wuille
8138cbea3c
Add automatic script test generation, and actual checksig tests
10 years ago
Cory Fields
6eb67b0ed2
autofile: Disallow by-value copies of CAutoFile
...
One might assume that CAutoFile would be ref-counted so that a copied object
would delay closing the underlying file until all copies have gone out of
scope. Since that's not the case with CAutoFile, explicitly disable copying.
10 years ago
Cory Fields
eee030f6bc
autofile: don't copy CAutoFile by value
10 years ago
Cory Fields
be6d87aa60
script: don't read past the end
10 years ago
Cory Fields
a94496fbb6
tests: don't split an empty string
10 years ago
ENikS
1e73504865
Fixing C4146 warning
...
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
10 years ago
Philip Kaufmann
20a11ffabf
minor variable init changes in init.cpp
...
- explicit init of pcoinsdbview and pwalletMain (even if not needed, as
globals are init to NULL, it seems cleaner)
- remove check if (pwalletMain) in Shutdown() as delete is valid even if
pwalletMain is NULL
10 years ago
Wladimir J. van der Laan
d14d7deff0
SanitizeString: allow '(' and ')'
...
'(' and ')' are valid in user agent strings, so should be reported
as such in RPC `getpeerinfo`.
Fixes #4537 .
10 years ago
ENikS
219372f1dd
script: Fix reference into empty vector run time exception
...
Edit by laanwj: `begin_ptr(sourcedata) + sourcedata.size()` -> `end_ptr(sourcedata)`
10 years ago
Jeff Garzik
ff36cbe8d0
RPC getnetworkinfo: export local node's client sub-version string
10 years ago
Philip Kaufmann
e6beedc496
[Qt] add more NULL pointer checks in bitcoingui
...
- add missing checks for clientModel and optionsModel
- small cleanups for an #ifdef on Mac
- remove an unneeded else
10 years ago
Pieter Wuille
cf42c36e99
Apply clang-format on crypto/* and compat/*
10 years ago
Pieter Wuille
584a358997
Do merkle root and txid duplicates check simultaneously
...
Move the txid duplicates check into BuildMerkleTree, where it can be done
much more efficiently (without needing to build a full txid set to detect
duplicates).
The previous version (using the std::set<uint256> to detect duplicates) was
also slightly too weak. A block mined with actual duplicate transactions
(which is invalid, due to the inputs of the duplicated transactions being
seen as double spends) would trigger the duplicates logic, resulting in the
block not being stored on disk, and rerequested. This change fixes that by
only triggering in the case of duplicated transactions that can actually
result in an identical merkle root.
10 years ago
ENikS
cda45b5131
Reinitializing list's begin iterator after few elements were erased from the head
10 years ago
ENikS
459a2d25e0
Avoiding referencing elements of an empty vector
10 years ago
ENikS
c8063b5712
Fixing out of bounds asses error
10 years ago
ENikS
6f3ae9b5df
Fixing out of bounds error in GetKey()
10 years ago
Philip Kaufmann
bb26e2c896
[Qt] minor changes in splashscreen.cpp
...
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
10 years ago