4b0deb3b2d
Clean up CMerkleTx::SetMerkleBranch.
...
The case SetMerkleBranch(NULL) was never actually used, and thus the
involved code (loading the block from disk) can be removed and the
implementation simplified.
10 years ago
e84843c0db
Broken addresses on command line no longer trigger testnet.
...
When passing a bitcoin: URI on the command line, invalid addresses do not incorrectly send the
user to the test network.
10 years ago
9f3d476779
changed field types in some structures to equivalent unambiguous types
...
Conflicts:
src/core.cpp
Rebased-By: Wladimir J. van der Laan
Github-Pull: #4180
10 years ago
bac5586b10
Replace weird characters by normal spaces
10 years ago
e9dd83f0a9
missing include boost/algorithm/string/replace.hpp
10 years ago
0101483f46
Move CMerkleTx to wallet.cpp/h
...
It is only used by the wallet so it has no place in main.
10 years ago
57153d4e1a
rpc: Compute number of confirmations of a block from block height
...
Currently this uses a CMerkleTx, but that makes no sense as we
have the CBlockIndex available. As noted by @jgarzik .
10 years ago
fbe0fcae76
[Qt] minor watch-only changes
...
- use watch-only, not watchonly
- add back a tooltip hint when hovering addresses and attach
"(watch-only)" at the end
10 years ago
bbad683224
[Qt] simplify return code and return values in txtablemodel
...
- also move an added space in a string where it belongs
10 years ago
21f1516468
[Qt] add all used colors in txtablemodel to guiconstants
...
- add colors used in TX status decoration
10 years ago
187115c01d
cleanup include of assert.h
10 years ago
4d04492bf2
add missing copyright headers
10 years ago
093303a887
add missing header end comments
...
- ensures a consistent usage in header files
- also add a blank line after the copyright header where missing
- also remove orphan new-lines at the end of some files
10 years ago
8bdd2877c4
Fix a few "Uninitialized scalar field" warnings
...
Fix a few warnings reported by Coverity.
None of these is critical, but making sure that class fields are
initialized can avoid heisenbugs.
10 years ago
11a899445e
qt/splashscreen: #include version.h
...
Needed to build breakage reported by Arnavion on IRC:
qt/splashscreen.cpp: In constructor 'SplashScreen::SplashScreen(const QPixmap&, Qt::WindowFlags, bool)':
qt/splashscreen.cpp:33:98: error: 'FormatFullVersion' was not declared in this scope
10 years ago
87d9819d4d
fix comments ExtractAddress() -> ExtractDestination()
10 years ago
d2d6f708e4
Fix build with DEBUG_LOCKORDER
...
Fixes #4771
10 years ago
70352e11c0
Revert "Add a getutxos command to the p2p protocol. It allows querying of the UTXO set"
...
This reverts commit da2ec100f3
10 years ago
2e280311b8
Perform CVerifyDB on pcoinsdbview instead of pcoinsTip
...
Bypassing the main coins cache allows more thorough checking with the same
memory budget.
This has no effect on performance because everything ends up in the child
cache created by VerifyDB itself.
It has bugged me ever since #4675 , which effectively reduced the
number of checked blocks to reduce peak memory usage.
- Pass the coinsview to use as argument to VerifyDB
- This also avoids that the first `pcoinsTip->Flush()` after VerifyDB
writes a large slew of unchanged coin records back to the database.
10 years ago
9f7f504efc
build: add -DMINIUPNP_STATICLIB for new version
...
libminiupnpc changed their required static define to the much more sane
"MINIUPNP_STATICLIB". Sadly, they don't respect the old "STATICLIB" for
back-compat. Define them both since the old one didn't seem to be conflicting
anywhere.
Also go ahead and split out the cppflags so that they can be applied only where
they're needed. This will help us to build dll's from our libs without having
their import/export declspecs poisoned.
10 years ago
80daee0fb5
[Qt] Call checkBalanceChanged() periodically instead for every updated transaction
10 years ago
f30801afbd
qt: Add null check in setClientModel(0)
...
Don't clear tray icon menu if it was never created.
Necessary precaution after #4649 .
10 years ago
ad49c256c3
Split up util.cpp/h
...
Split up util.cpp/h into:
- string utilities (hex, base32, base64): no internal dependencies, no dependency on boost (apart from foreach)
- money utilities (parsesmoney, formatmoney)
- time utilities (gettime*, sleep, format date):
- and the rest (logging, argument parsing, config file parsing)
The latter is basically the environment and OS handling,
and is stripped of all utility functions, so we may want to
rename it to something else than util.cpp/h for clarity (Matt suggested
osinterface).
Breaks dependency of sha256.cpp on all the things pulled in by util.
10 years ago
f841aa2892
Move `COIN` and `CENT` to core.h
...
Eventually these should end up in `money.h` after monetary
amounts are typedef'ed, but at least they don't belong in `util.h`.
10 years ago
6e5fd003e0
Move `*Version()` functions to version.h/cpp
10 years ago
b4aa769bcb
Move `S_I*` constants and `MSG_NOSIGNAL` to compat.h
10 years ago
af8297c010
Move functions in wallet.h to implementation file
...
Breaks compile-time dependency of wallet.h on util.
10 years ago
651480c8e4
move functions in main and net to implementation files
10 years ago
610a8c0759
Move SetThreadPriority implementation to util.cpp instead of the header
...
Put the THREAD_* and PRIO_ constants in compat.h.
10 years ago
f780e65ac6
Remove unused function `ByteReverse` from util.h
10 years ago
121d6ad9db
Remove unused `alignup` function from util.h
10 years ago
d1e26d4e71
Move CMedianFilter to timedata.cpp
...
Now that we no longer use the median filter to keep track of
the number of blocks of peers, that's the only place it is used.
10 years ago
d0867acb0e
Use const CCoinsView's at some places.
...
At some places where it is possible (e. g., CheckInputs), use a const
version of CCoinsView instead of a non-const one.
10 years ago
a3dc587a62
Make appropriate getter-routines "const" in CCoinsView.
...
Mark the "Get"/"Have" routines in CCoinsView and subclasses as "const".
10 years ago
ffb4c210bc
Mark LevelDB "Read" and "Exists" functions as const.
...
Mark the "Read" and "Exists" functions in CLevelDBWrapper as "const".
They do not change anything in the DB, by definition.
10 years ago
92bb6f2f17
Bypass reloading blocks from disk
10 years ago
aa41ac216e
Test IsPushOnly() with invalid push
10 years ago
fff7455ded
Make CScript::clear() release its memory
10 years ago
b0875eb3fe
Allow BatchWrite to destroy its input, reducing copying
10 years ago
654871d436
replace ComputeMinWork with CheckMinWork
10 years ago
b343c1a1e3
Move CBlockIndex::GetBlockWork() to pow::GetProofIncrement(nBits)
10 years ago
c2c02f3fa9
Move UpdateTime to pow
10 years ago
7f836c66bd
rpc_tests: use BOOST_CHECK_EQUAL
...
Upon failure, BOOST_CHECK_EQUAL provides additional diagnostic information,
displaying that data that failed to match.
10 years ago
3802224110
Remove all other print() methods
...
All unused.
10 years ago
9b6d4c5cdc
Move strprintf define to tinyformat.h
...
This avoids a dependency on util.h if just tinyformat is needed.
10 years ago
81212588c0
Remove print() from core functions
...
Break dependency on util.
10 years ago
dc271fc025
UniValue tests: use more BOOST_CHECK()
10 years ago
e85267be63
UniValue: add unit tests
10 years ago
dee9324a0b
UniValue: compact (!pretty) output should not include extra whitespace
10 years ago
42642c9695
UniValue: use correct setNumStr() input val, when setting number values
10 years ago
Daniel Kraft